Files

T

harry 0d4de1a768 Add implement skill; default review-loop to Smartypants and 5 rounds

review-loop: Smartypants when no reviewer is named, up to five rounds, a verdict with Purpose, Merge-ready and Not verified lines, and a one-line update after each round.
ship: allow a mechanical merge from base, watch the rollout when the repo requires it, and finish with one report and request_close.
implement: build on a branch, open the PR and review-loop it until GREEN. It never merges.
bro: agents can run it, but only when Harry asks.

2026-10-07 16:12:47 +02:00

2.2 KiB

Raw Blame History

name, description

name	description
implement	Do a piece of work on its own branch, open a PR, and run `review-loop` until it is GREEN, then hand Harry the verdict. Use when Harry says "/implement", "do this in a PR and review-loop it", "make a PR and get it green". Never merges or ships.

Implement

Takes a task from "do this" to a GREEN PR without Harry having to drive each step. It ends at GREEN. Shipping is a separate step under the ship skill, and only when Harry says so.

1. Set up

Work in a fresh worktree off the latest base branch. In Patterm, use worktree.create. Elsewhere, follow the repo's branch convention.
If the task needs a product or design decision you can't make from the request, the code or the repo's docs, ask before writing code. Otherwise, start.

2. Build it

Make the smallest change that does the task well. Add or update tests for what you change.
Run the checks the repo's AGENTS.md lists, and fix what fails.
If the task turns out much bigger than it looked, or needs a different approach than the one Harry named, stop and tell him before carrying on.

3. Open the PR

Don't ask whether to commit or open the PR. That is the point of this skill.

Commit, push the branch, and open the PR with the remote's own tool.
Start the PR description with one plain sentence on what it solves. Follow it with how you tested it.
In Patterm, attach the PR URL to your session with reference.attach.

4. Review until GREEN

Run review-loop on the PR, with yourself as the implementer. Use the reviewers Harry named, or Smartypants if he named none. Let its rules on scope, round limits and stopping for Harry apply as written.

5. Report

When the loop ends, send Harry the review-loop verdict and the PR link. If the PR is GREEN, say it's ready to ship. Leave the worktree and branch in place for ship.

If a parent agent started you, send the verdict with report_to_parent and leave relaying to Harry to the parent.

Boundaries

Never merge, approve or close the PR, even when it's GREEN. If Harry also asked to ship, the ship skill does that after this one ends.
No production writes, deploys or changes to live services.
Commit only to the task's branch, never to main.

2.2 KiB Raw Blame History