Compare commits
32 Commits
v0.0.3
...
ec0c148164
| Author | SHA1 | Date | |
|---|---|---|---|
| ec0c148164 | |||
| 9aecc8b7a2 | |||
| e63bdad5e1 | |||
| b72a32bbc6 | |||
| da46340a82 | |||
| d2342f99cf | |||
| 178b4437b1 | |||
| 0725375755 | |||
| 3022e4adeb | |||
| 7b5a22618f | |||
| 53f06b604f | |||
| 50fd7be70d | |||
| 96f7c66d5f | |||
| f61788eff2 | |||
| c1b66f9f8a | |||
| fe25fcf043 | |||
| 2fa00ad510 | |||
| 412b1167a2 | |||
| 34b41be1df | |||
| de60b93bc6 | |||
| 67b994f629 | |||
| f10598601f | |||
| cadd4c8f64 | |||
| 98d1c059cf | |||
| cf65d5d707 | |||
| ef9b8e71c6 | |||
| e64060e40f | |||
| e4ab8c2136 | |||
| f312b6d345 | |||
| e6f5a94fae | |||
| c1ecba0624 | |||
| 878e9370bc |
@@ -11,14 +11,19 @@ jobs:
|
|||||||
steps:
|
steps:
|
||||||
- uses: actions/checkout@v4
|
- uses: actions/checkout@v4
|
||||||
|
|
||||||
- uses: actions/setup-go@v5
|
- uses: jdx/mise-action@v2
|
||||||
with:
|
with:
|
||||||
go-version-file: go.mod
|
|
||||||
cache: true
|
cache: true
|
||||||
|
|
||||||
- uses: mlugg/setup-zig@v2
|
- name: Cache Go modules
|
||||||
|
uses: actions/cache@v4
|
||||||
with:
|
with:
|
||||||
version: 0.15.2
|
path: |
|
||||||
|
~/.cache/go-build
|
||||||
|
~/go/pkg/mod
|
||||||
|
key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
|
||||||
|
restore-keys: |
|
||||||
|
${{ runner.os }}-go-
|
||||||
|
|
||||||
- name: Build libghostty-vt
|
- name: Build libghostty-vt
|
||||||
run: make deps
|
run: make deps
|
||||||
|
|||||||
1
.gitignore
vendored
1
.gitignore
vendored
@@ -7,4 +7,5 @@ spike-report-*.txt
|
|||||||
/bin/
|
/bin/
|
||||||
/spike
|
/spike
|
||||||
/.worktrees/
|
/.worktrees/
|
||||||
|
/.claude/worktrees/
|
||||||
internal/harness/.artifacts/
|
internal/harness/.artifacts/
|
||||||
|
|||||||
@@ -3,6 +3,8 @@
|
|||||||
# libghostty-vt is built from a pinned upstream Ghostty commit; that
|
# libghostty-vt is built from a pinned upstream Ghostty commit; that
|
||||||
# commit's build.zig.zon pins minimum_zig_version = 0.15.2. We match
|
# commit's build.zig.zon pins minimum_zig_version = 0.15.2. We match
|
||||||
# it here so contributors don't have to puzzle out the version from
|
# it here so contributors don't have to puzzle out the version from
|
||||||
# a deep upstream file.
|
# a deep upstream file. The go pin matches go.mod so CI and local
|
||||||
|
# builds use the same toolchain.
|
||||||
[tools]
|
[tools]
|
||||||
zig = "0.15.2"
|
zig = "0.15.2"
|
||||||
|
go = "1.26.3"
|
||||||
|
|||||||
146
CHANGELOG.md
146
CHANGELOG.md
@@ -6,6 +6,150 @@ loosely follows [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
|
|||||||
|
|
||||||
## [Unreleased]
|
## [Unreleased]
|
||||||
|
|
||||||
|
### Added
|
||||||
|
- MCP clients can now call `scratchpad_delete` with a scratchpad name
|
||||||
|
to remove a shared project scratchpad.
|
||||||
|
|
||||||
|
### Changed
|
||||||
|
- The tab bar now shows each visible agent tab's own summary instead
|
||||||
|
of only rendering the focused tab's summary.
|
||||||
|
- Grid-mode `get_process_output` now returns whitespace-normalized
|
||||||
|
text to avoid sending padded terminal rows and repeated blank lines
|
||||||
|
over MCP.
|
||||||
|
|
||||||
|
### Fixed
|
||||||
|
- Injected agent input now sends the submit Enter as a separated,
|
||||||
|
settled keystroke so messages reliably submit instead of sometimes
|
||||||
|
sitting unsent in the composer.
|
||||||
|
- Codex agents are no longer reported idle while a turn is still
|
||||||
|
running.
|
||||||
|
- Slow MCP tool calls such as `wait_for_pattern` no longer block later
|
||||||
|
tool calls on the same MCP connection.
|
||||||
|
- Closing an agent now escalates from SIGTERM to SIGKILL when needed,
|
||||||
|
so agents that ignore SIGTERM disappear from the running tab bar
|
||||||
|
after one Close action while keeping their exited pane readable.
|
||||||
|
- Sidebar timer indicators now repaint as their visible countdown
|
||||||
|
value changes, so labels progress from minutes to seconds without
|
||||||
|
waiting for unrelated terminal output or focus changes.
|
||||||
|
- Raw terminal focused actions now show a single `Close` row instead
|
||||||
|
of separate stop/delete-style lifecycle choices that did the same
|
||||||
|
thing for ephemeral terminal panes.
|
||||||
|
- Restarting a process from the palette now restores the focused pane
|
||||||
|
and host chrome before waiting for the old process to exit, so the
|
||||||
|
tab bar and sidebar do not disappear during slow restarts.
|
||||||
|
- Deleting the focused scratchpad now moves focus to another
|
||||||
|
scratchpad when one exists, or back to a running terminal/agent
|
||||||
|
instead of dropping into the empty state.
|
||||||
|
- Multiline paste into raw terminal and command panes no longer pays
|
||||||
|
the agent-specific per-Enter delay, making large pasted input arrive
|
||||||
|
as one PTY write outside Claude/Codex/OpenCode panes.
|
||||||
|
|
||||||
|
## [0.0.7] - 2026-05-18
|
||||||
|
|
||||||
|
### Added
|
||||||
|
- The top tab bar now prefixes each agent tab's label with its
|
||||||
|
idle-state glyph (✕ error, ? permission, ◐ thinking, ○ idle, ●
|
||||||
|
working), matching the sidebar's vocabulary so the state of every
|
||||||
|
open agent is visible without opening or focusing each tab.
|
||||||
|
|
||||||
|
### Changed
|
||||||
|
- Built-in agent presets (`claude`, `codex`, `opencode`) now live in
|
||||||
|
memory and user preset files merge over them by name instead of
|
||||||
|
patterm writing default preset files into `$XDG_CONFIG_HOME`. Add
|
||||||
|
`"disabled": true` in a matching user preset to hide a built-in.
|
||||||
|
- Generated MCP config files for agent launches now live under the
|
||||||
|
runtime agent directory instead of `$XDG_CONFIG_HOME/patterm/mcp`.
|
||||||
|
- Auto-summarization settings now save as soon as a changed row is
|
||||||
|
applied, including cadence/provider/toggle changes and model edits,
|
||||||
|
without requiring a separate save step.
|
||||||
|
- The Agents / Auto-summarization settings screen no longer shows
|
||||||
|
explicit Save, Cancel, or Back rows, and its footer copy no longer
|
||||||
|
describes a separate save/cancel flow.
|
||||||
|
- Auto-summarization setting rows now visually separate grey labels
|
||||||
|
from regular-colour values.
|
||||||
|
- The active-thread summary in the tab bar is now constrained to the
|
||||||
|
active tab's width instead of spanning the whole top row.
|
||||||
|
- Sidebar summary text now wraps from the full summary text instead of
|
||||||
|
using an ellipsized single-line value.
|
||||||
|
|
||||||
|
### Fixed
|
||||||
|
- Claude permission prompts are now detected from the rendered pane as
|
||||||
|
well as the recent output tail, so the sidebar marks the pane as
|
||||||
|
waiting for permission even while `Calling patterm...` continues to
|
||||||
|
repaint.
|
||||||
|
- Removed the redundant "Back to Settings" row from the
|
||||||
|
Agents / Auto-summarization settings screen.
|
||||||
|
- Pending `timer_*` entries are now cancelled when their owning or
|
||||||
|
watched child is closed via `close_process`, preventing stale
|
||||||
|
timer bodies from being re-delivered to the orchestrator pane
|
||||||
|
after the work has already been handled.
|
||||||
|
|
||||||
|
## [0.0.6] - 2026-05-15
|
||||||
|
|
||||||
|
### Changed
|
||||||
|
- Toast notifications now reserve three content rows and word-wrap
|
||||||
|
the message body inside the box, replacing the previous
|
||||||
|
single-line+ellipsis layout. The `Ctrl-N · N more` inline hint is
|
||||||
|
gone; instead the host status strip surfaces a `Ctrl-N · dismiss`
|
||||||
|
hint, shown only while a notification is on screen so the chord
|
||||||
|
doesn't advertise itself when it has nothing to dismiss.
|
||||||
|
|
||||||
|
### Fixed
|
||||||
|
- Auto-summary no longer fails immediately with `codex summarizer:
|
||||||
|
error: unexpected argument '--ask-for-approval' found`. The codex
|
||||||
|
CLI dropped that flag; we now rely on `--sandbox read-only` (which
|
||||||
|
already implies no approvals) instead of passing it.
|
||||||
|
- Toast box no longer flickers / half-erases while the focused
|
||||||
|
child (claude, codex, opencode, etc.) repaints its TUI. The
|
||||||
|
overlay is now stitched onto the end of the per-chunk PTY write
|
||||||
|
under `outMu`, and wrapped in DECSET 2026 (synchronized output)
|
||||||
|
brackets so terminals that support it batch the child's redraw +
|
||||||
|
the box paint into a single frame instead of racing cell-by-cell.
|
||||||
|
|
||||||
|
## [0.0.5] - 2026-05-15
|
||||||
|
|
||||||
|
### Changed
|
||||||
|
- Replaced the single-slot status-line "flash" with a stackable toast
|
||||||
|
surface anchored at the top-right of the focused pane. `flashError`,
|
||||||
|
`flashTransient`, and MCP `request_human_attention` now push onto
|
||||||
|
the toast stack (cap 5, oldest drops). Toasts persist until
|
||||||
|
dismissed with `Ctrl-N`, or cleared via the new
|
||||||
|
"Clear notifications" palette command. The status line no longer
|
||||||
|
shows the `[!]` prefix.
|
||||||
|
- `Ctrl-N` is consumed by the host only when there is a toast to
|
||||||
|
dismiss; an empty stack lets `Ctrl-N` pass through to the focused
|
||||||
|
child so readline / nano / emacs / opencode keep their bindings.
|
||||||
|
- Command palette is calmer when something is focused. Focused-section
|
||||||
|
rows now read as bare verbs (`Rename`, `Close`, `Stop`, `Restart`,
|
||||||
|
`Delete`, `Edit`) instead of repeating the focused name (`Close
|
||||||
|
agent: codex`); the title bar's `on: codex` / `pad: notes.md`
|
||||||
|
carries the subject. Fuzzy queries still match the dropped context
|
||||||
|
through the row hint (e.g. typing `close codex` still finds the
|
||||||
|
Close row).
|
||||||
|
- Dashed `── Focused ──` / `── Open ──` / `── Spawn ──` section
|
||||||
|
banners are gone. Sections are separated by a single blank spacer
|
||||||
|
row, so the action labels themselves carry the visual weight.
|
||||||
|
- The Open section no longer lists a `Switch to <current>` row for
|
||||||
|
the pane you're already focused on.
|
||||||
|
|
||||||
|
## [0.0.4] - 2026-05-15
|
||||||
|
|
||||||
|
### Changed
|
||||||
|
- Release workflow (`.gitea/workflows/release.yml`) now provisions
|
||||||
|
Zig and Go through `jdx/mise-action@v2`, reading the versions from
|
||||||
|
`.mise.toml` (zig 0.15.2, go 1.26.3). Both toolchains were
|
||||||
|
previously installed via `mlugg/setup-zig` and `actions/setup-go`,
|
||||||
|
whose mirror chase / GitHub fetch combined for ~8 minutes per run
|
||||||
|
before any patterm code compiled. mise pulls each tool once and
|
||||||
|
caches the install dir, so subsequent runs hit the cache instead of
|
||||||
|
re-downloading. `make deps` still resolves zig via `mise which zig`
|
||||||
|
with a PATH fallback; `go.mod` already pinned `go 1.26.3`, so the
|
||||||
|
new `go` entry in `.mise.toml` just keeps CI and local builds on
|
||||||
|
the same toolchain.
|
||||||
|
- A Go module/build cache step (`actions/cache@v4`, keyed on
|
||||||
|
`go.sum`) was added so `go build` doesn't re-download dependencies
|
||||||
|
on every tag push.
|
||||||
|
|
||||||
## [0.0.3] - 2026-05-15
|
## [0.0.3] - 2026-05-15
|
||||||
|
|
||||||
### Added
|
### Added
|
||||||
@@ -70,6 +214,8 @@ loosely follows [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
|
|||||||
the command field.
|
the command field.
|
||||||
|
|
||||||
### Fixed
|
### Fixed
|
||||||
|
- Error/status flashes now restore the currently focused pane instead
|
||||||
|
of drawing the empty-state hint over a running agent or process.
|
||||||
- Release workflow (`.gitea/workflows/release.yml`) now uses
|
- Release workflow (`.gitea/workflows/release.yml`) now uses
|
||||||
`mlugg/setup-zig@v2` instead of the deprecated `@v1`. v1 hard-coded
|
`mlugg/setup-zig@v2` instead of the deprecated `@v1`. v1 hard-coded
|
||||||
the pre-0.14 tarball name (`zig-linux-x86_64-<ver>.tar.xz`), so
|
the pre-0.14 tarball name (`zig-linux-x86_64-<ver>.tar.xz`), so
|
||||||
|
|||||||
23
SPEC.md
23
SPEC.md
@@ -39,7 +39,7 @@ The tool is one Go process that owns: the TUI, all PTYs, vt-emulated grids, sess
|
|||||||
|
|
||||||
## 3. Project state layout
|
## 3. Project state layout
|
||||||
|
|
||||||
Scratchpads (user data) live under `$XDG_DATA_HOME`; presets and config live under `$XDG_CONFIG_HOME`.
|
Scratchpads (user data) live under `$XDG_DATA_HOME`; user-authored preset overlays and config live under `$XDG_CONFIG_HOME`.
|
||||||
|
|
||||||
```
|
```
|
||||||
$XDG_DATA_HOME/patterm/
|
$XDG_DATA_HOME/patterm/
|
||||||
@@ -53,12 +53,12 @@ $XDG_DATA_HOME/patterm/
|
|||||||
└── <agent-written>.md
|
└── <agent-written>.md
|
||||||
|
|
||||||
$XDG_CONFIG_HOME/patterm/
|
$XDG_CONFIG_HOME/patterm/
|
||||||
├── config.json # global settings (theme, default keymap, etc.)
|
├── settings.json # global settings, written only after the user changes settings
|
||||||
└── presets/
|
└── presets/
|
||||||
├── agents/
|
├── agents/
|
||||||
│ ├── claude.json # ships as default
|
│ ├── claude.json # optional overlay for built-in claude
|
||||||
│ ├── codex.json # ships as default
|
│ ├── codex.json # optional overlay for built-in codex
|
||||||
│ ├── opencode.json # ships as default
|
│ ├── opencode.json # optional overlay for built-in opencode
|
||||||
│ └── <user-defined>.json
|
│ └── <user-defined>.json
|
||||||
└── processes/
|
└── processes/
|
||||||
├── dev.json # e.g. { "name": "bun run dev", "argv": ["bun", "run", "dev"] }
|
├── dev.json # e.g. { "name": "bun run dev", "argv": ["bun", "run", "dev"] }
|
||||||
@@ -66,7 +66,7 @@ $XDG_CONFIG_HOME/patterm/
|
|||||||
└── <user-defined>.json
|
└── <user-defined>.json
|
||||||
```
|
```
|
||||||
|
|
||||||
Both preset directories are scanned at startup; every file found becomes a palette entry ("Spawn agent: claude", "Run process: bun run dev", …). Presets are project-agnostic in v1 — the same set is available in every project. Per-project overrides can be added later.
|
patterm always has built-in agent presets for `claude`, `codex`, and `opencode`. User preset files are scanned at startup and merged into matching built-ins by `name`, or added as standalone custom presets when the name is new. A matching file with `"disabled": true` hides a built-in. Startup does not write default preset files. Presets are project-agnostic in v1 — the same set is available in every project. Per-project overrides can be added later.
|
||||||
|
|
||||||
Project key = `sha256(realpath(project_dir))[:16]`. Used only as a scratchpad directory name — there is no daemon to look up.
|
Project key = `sha256(realpath(project_dir))[:16]`. Used only as a scratchpad directory name — there is no daemon to look up.
|
||||||
|
|
||||||
@@ -121,7 +121,7 @@ Scratchpads and command-preset trust grants persist across runs. Sessions and ch
|
|||||||
Almost all application functions are driven through a single command palette opened with `Ctrl-K`. The palette is a fuzzy-searchable list of commands, scoped to whatever makes sense for the current focus. Two kinds of entries appear:
|
Almost all application functions are driven through a single command palette opened with `Ctrl-K`. The palette is a fuzzy-searchable list of commands, scoped to whatever makes sense for the current focus. Two kinds of entries appear:
|
||||||
|
|
||||||
- **Built-in commands** — "Switch to session…", "Focus pane…", "Take input control", "Release control to orchestrator", "Open scratchpad…", "Kill child…", "Quit", etc.
|
- **Built-in commands** — "Switch to session…", "Focus pane…", "Take input control", "Release control to orchestrator", "Open scratchpad…", "Kill child…", "Quit", etc.
|
||||||
- **Preset commands** — one entry per file under `$XDG_CONFIG_HOME/patterm/presets/`. Agent presets surface as "Spawn agent: codex" / "Spawn agent: claude" / …; process presets surface as "Run process: bun run dev" / "Run process: vitest" / …. The label comes from the preset's `name` field; the action is "launch this preset into a new pane."
|
- **Preset commands** — one entry per built-in or user-defined preset. Agent presets surface as "Spawn agent: codex" / "Spawn agent: claude" / …; process presets surface as "Run process: bun run dev" / "Run process: vitest" / …. The label comes from the preset's `name` field; the action is "launch this preset into a new pane."
|
||||||
|
|
||||||
Selecting a preset either launches it immediately (no required args) or opens a sub-palette for optional args — namely an **initial prompt** (agent presets only), which patterm injects into the spawned PTY's input after the agent is ready (§8). The orchestrator equivalent of this — `spawn_agent` / `spawn_process` MCP tools — uses the exact same machinery: pick a preset by name, optionally supply an initial prompt, patterm handles the rest.
|
Selecting a preset either launches it immediately (no required args) or opens a sub-palette for optional args — namely an **initial prompt** (agent presets only), which patterm injects into the spawned PTY's input after the agent is ready (§8). The orchestrator equivalent of this — `spawn_agent` / `spawn_process` MCP tools — uses the exact same machinery: pick a preset by name, optionally supply an initial prompt, patterm handles the rest.
|
||||||
|
|
||||||
@@ -365,11 +365,11 @@ Risks acknowledged: the orchestrator's reading of the prompt is a vision/parsing
|
|||||||
|
|
||||||
## 10. Presets
|
## 10. Presets
|
||||||
|
|
||||||
Presets are user-editable JSON files that describe how to launch something. patterm itself has no hard-coded agent or process types — every spawnable thing is a preset. Two flavours:
|
Presets describe how to launch something. patterm has built-in defaults for common agent CLIs, and user-editable JSON files can override, disable, or add presets. Two flavours:
|
||||||
|
|
||||||
### Agent presets
|
### Agent presets
|
||||||
|
|
||||||
`$XDG_CONFIG_HOME/patterm/presets/agents/<name>.json`. Launches a vendor LLM CLI with MCP wired up and the conversation-protocol addendum injected.
|
Built-in agent presets launch vendor LLM CLIs with MCP wired up and the conversation-protocol addendum injected. `$XDG_CONFIG_HOME/patterm/presets/agents/<name>.json` can overlay a built-in by `name` or define a new agent preset.
|
||||||
|
|
||||||
| Field | Purpose |
|
| Field | Purpose |
|
||||||
|---|---|
|
|---|---|
|
||||||
@@ -377,17 +377,18 @@ Presets are user-editable JSON files that describe how to launch something. patt
|
|||||||
| `argv` | Full launch argv (e.g. `["claude"]`, `["codex", "--no-tui-banner"]`) |
|
| `argv` | Full launch argv (e.g. `["claude"]`, `["codex", "--no-tui-banner"]`) |
|
||||||
| `env` | Env vars to set (merged over inherited env) |
|
| `env` | Env vars to set (merged over inherited env) |
|
||||||
| `working_dir` | Defaults to the project root |
|
| `working_dir` | Defaults to the project root |
|
||||||
|
| `disabled` | If `true`, hides a built-in preset with the same `name` |
|
||||||
| `mcp_injection` | How to point this CLI at patterm's stdio proxy. One of: `{ "kind": "flag", "flag": "--mcp-config", "config_path": "..." }`, `{ "kind": "config_file", "path": "~/.codex/config.toml", "merge_key": "mcp_servers" }`, `{ "kind": "env_var", "var": "MCP_CONFIG_PATH" }` |
|
| `mcp_injection` | How to point this CLI at patterm's stdio proxy. One of: `{ "kind": "flag", "flag": "--mcp-config", "config_path": "..." }`, `{ "kind": "config_file", "path": "~/.codex/config.toml", "merge_key": "mcp_servers" }`, `{ "kind": "env_var", "var": "MCP_CONFIG_PATH" }` |
|
||||||
| `ready_signal` | How to detect the TUI is ready (default: 1s idle after launch). Override per-CLI if needed. |
|
| `ready_signal` | How to detect the TUI is ready (default: 1s idle after launch). Override per-CLI if needed. |
|
||||||
| `chrome_trim_hints` | Optional regexes / row ranges for stripping vendor chrome in grid reads |
|
| `chrome_trim_hints` | Optional regexes / row ranges for stripping vendor chrome in grid reads |
|
||||||
|
|
||||||
Default presets shipped: `claude`, `codex`, `opencode`. Authoring these is per-vendor research — each CLI has its own MCP config conventions, ready states, and TUI chrome. Users can copy and edit them, or add new ones (e.g. a second `claude` preset that launches with a specific model or system prompt file).
|
Built-in presets: `claude`, `codex`, `opencode`. Authoring these is per-vendor research — each CLI has its own MCP config conventions, ready states, idle detection, and TUI chrome. Users can add small overlay files for built-ins, disable built-ins, or add new presets (e.g. a second `claude-sonnet` preset that launches with a specific model or system prompt file).
|
||||||
|
|
||||||
MCP config flow: at startup, for each agent preset, patterm renders a small JSON pointing at its own `mcp-stdio` proxy subcommand (`patterm mcp-stdio --socket <pid-sock> --identity <token>`) into a per-preset temp file. The launch then uses the preset's `mcp_injection` strategy to hand that path to the CLI. The user's global vendor config is never mutated.
|
MCP config flow: at startup, for each agent preset, patterm renders a small JSON pointing at its own `mcp-stdio` proxy subcommand (`patterm mcp-stdio --socket <pid-sock> --identity <token>`) into a per-preset temp file. The launch then uses the preset's `mcp_injection` strategy to hand that path to the CLI. The user's global vendor config is never mutated.
|
||||||
|
|
||||||
### Process presets
|
### Process presets
|
||||||
|
|
||||||
`$XDG_CONFIG_HOME/patterm/presets/processes/<name>.json`. Launches a raw command in a PTY — no MCP, no addendum, no system prompt.
|
`$XDG_CONFIG_HOME/patterm/presets/processes/<name>.json`. Launches a raw command in a PTY — no MCP, no addendum, no system prompt. There are no built-in process presets.
|
||||||
|
|
||||||
| Field | Purpose |
|
| Field | Purpose |
|
||||||
|---|---|
|
|---|---|
|
||||||
|
|||||||
115
TODO.md
115
TODO.md
@@ -1,115 +0,0 @@
|
|||||||
# Perf Audit (reviewed 2026-05-15)
|
|
||||||
Findings that survived the 2026-05-15 review pass. Low and marginal
|
|
||||||
items from the original sweep were removed; remaining items have enough
|
|
||||||
measured or workflow evidence to justify action.
|
|
||||||
|
|
||||||
Baseline benchmark numbers (`go test -bench=. ./internal/app/`, AMD
|
|
||||||
Ryzen 7 7800X3D, libghostty-vt **ReleaseFast** after the Makefile
|
|
||||||
fix landed):
|
|
||||||
|
|
||||||
```
|
|
||||||
# Renderer alone
|
|
||||||
ViewportRenderer_PlainASCII 229 MB/s 1.3 KB/op 6 allocs/op
|
|
||||||
ViewportRenderer_StyledLines 89 MB/s 91 KB/op 4325 allocs/op
|
|
||||||
ViewportRenderer_RatatuiBurst 40 MB/s 365 KB/op 17306 allocs/op
|
|
||||||
RendererThroughput_ReuseInstance 90 MB/s 316 KB/op 17380 allocs/op
|
|
||||||
ContainsOSC_NoOSC 3050 MB/s 0 B/op 0 allocs/op
|
|
||||||
|
|
||||||
# ASCII-video stream (renderer only — 3 sec at the target fps)
|
|
||||||
ASCIIVideo_Stream_8Color_120fps 260 µs/frame 3845 fps_ceiling 3.1% budget
|
|
||||||
ASCIIVideo_Stream_TrueColor_120fps 576 µs/frame 1735 fps_ceiling 6.9% budget
|
|
||||||
|
|
||||||
# Full pipeline (em.Write + renderer + io.Discard write)
|
|
||||||
Pipeline_ASCIIVideo_8Color_120fps 493 µs/frame 2030 fps_ceiling 5.9% budget
|
|
||||||
Pipeline_ASCIIVideo_TrueColor_120fps 1075 µs/frame 931 fps_ceiling 12.9% budget
|
|
||||||
|
|
||||||
# Emulator alone (libghostty-vt CSI/SGR parser)
|
|
||||||
Emulator_Write_Stream_8Color_120fps 257 µs/frame 3890 fps_ceiling
|
|
||||||
Emulator_Write_Stream_TrueColor_120fps 488 µs/frame 2051 fps_ceiling
|
|
||||||
```
|
|
||||||
|
|
||||||
The current pipeline still has large 120 fps headroom. The remaining
|
|
||||||
renderer concern is multi-MiB styled replay latency and allocation
|
|
||||||
churn, not normal steady-state frame budget.
|
|
||||||
|
|
||||||
|
|
||||||
- [ ] **viewport renderer allocates heavily on SGR/CSI-heavy chunks.** [MEDIUM]
|
|
||||||
- Review evidence: five benchmark reps confirmed
|
|
||||||
`ViewportRenderer_StyledLines` at about 4,325 allocs per 16 KiB
|
|
||||||
chunk (~91.5 KB/op, roughly 1 alloc per 3.8 input bytes), and
|
|
||||||
`ViewportRenderer_RatatuiBurst` at about 17,306 allocs per chunk
|
|
||||||
(~365 KB/op). A 5 MiB styled resume benchmark allocated about
|
|
||||||
31 MB across 1.38M objects.
|
|
||||||
- Likely hot paths: generic CSI/SGR output in
|
|
||||||
`internal/app/viewport_renderer.go` sends many sequences through
|
|
||||||
`vr.shifter.Shift(vr.buf)`, while `internal/app/cursorshift.go`
|
|
||||||
returns a fresh `[]byte` via `pending.String()` on every
|
|
||||||
`Shift` call and parses CSI params through `string(raw)` /
|
|
||||||
`strings.Split`. The mode-helper `string(params)` conversions
|
|
||||||
are real, but probably not the main SGR-heavy cost.
|
|
||||||
- Fix direction: make `cursorShifter` write into caller-owned
|
|
||||||
scratch output or directly into the viewport renderer's pending
|
|
||||||
builder; parse CSI params from byte slices; pre-grow/reuse
|
|
||||||
renderer and shifter buffers. Re-run styled-lines, ratatui, and
|
|
||||||
5 MiB resume benchmarks; use pprof when available to confirm the
|
|
||||||
top allocation sites.
|
|
||||||
|
|
||||||
- [ ] **large styled resume/replay dumps spend visible time in viewport rendering.** [MEDIUM]
|
|
||||||
- Review evidence: `BenchmarkSessionResume_5MiBStyled` measured
|
|
||||||
about 58 ms median and 63 ms p95 over five reps. The plain 5 MiB
|
|
||||||
benchmark was about 23-24 ms with only 21 allocs. The live path
|
|
||||||
renders focused PTY chunks through `renderer.Render`, then still
|
|
||||||
pays emulator writes, ring writes, event dispatch, stdout writes,
|
|
||||||
and real terminal paint.
|
|
||||||
- Scope: this is not a Codex steady-state throughput limit. A
|
|
||||||
100 KB/s stream is far below the styled renderer's ~80-90 MB/s
|
|
||||||
ceiling. It matters for multi-MiB burst replay, resume/startup
|
|
||||||
dumps, and dense full-screen churn.
|
|
||||||
- Fix direction: do the allocation fix first, since it should also
|
|
||||||
improve throughput. After that, invest further only if styled
|
|
||||||
resume traces remain user-visible or the styled-lines benchmark
|
|
||||||
is still under roughly 300 MB/s.
|
|
||||||
|
|
||||||
- [ ] **wait_for_pattern re-scans the entire stream/grid while waiting.** [MEDIUM]
|
|
||||||
- `internal/app/host.go:476-493` (the `check` closure). On
|
|
||||||
`scope="scrollback"` it calls `c.StreamRead(0)` followed by
|
|
||||||
`stripANSIBytes(nil, b)`, so each check can copy, strip, and
|
|
||||||
search the full 1 MiB ring. On `scope="grid"` it calls
|
|
||||||
`PlainText()` and runs the regex against the full grid string.
|
|
||||||
- Caveat from review: the current chunk notifier coalesces bursts
|
|
||||||
with a buffered channel and has a 500 ms fallback, so this is not
|
|
||||||
necessarily one full scan per PTY chunk. It is still meaningful
|
|
||||||
for active waits on chatty panes.
|
|
||||||
- Fix direction: for `scrollback`, track the last checked stream
|
|
||||||
offset and search only new output plus a bounded overlap/scratch
|
|
||||||
buffer so matches spanning chunks are not missed. For `grid`,
|
|
||||||
dedupe on `ScreenVersion()` and skip work when the version has
|
|
||||||
not changed.
|
|
||||||
|
|
||||||
- [ ] **search_output rebuilds and searches whole scrollback on every call.** [MEDIUM]
|
|
||||||
- `internal/app/host.go:428-437` compiles a fresh regex, reads the
|
|
||||||
stream from offset 0, strips ANSI for `kind="rendered"`, converts
|
|
||||||
the full buffer to a string, and splits it into lines before
|
|
||||||
applying `limit`. This is meaningful when agents poll the same
|
|
||||||
pattern; it is low impact for ad hoc searches.
|
|
||||||
- Fix direction: cache compiled regexes by pattern; cache stripped
|
|
||||||
rendered output by child id and stream end offset; avoid
|
|
||||||
`strings.Split` over the whole ring when only the first `limit`
|
|
||||||
matches are needed. Prefer an incremental search shape if this
|
|
||||||
becomes the standard "watch for marker" path.
|
|
||||||
|
|
||||||
# On Hold
|
|
||||||
- [ ] There's a unicode <?> being displayed in opencode [ON HOLD]
|
|
||||||
- Investigated 2026-05-14: patterm passes ghostty grapheme codepoints
|
|
||||||
through unchanged (vt/ghostty.go:452-462), so the `<?>` glyph is
|
|
||||||
most likely the *host* terminal's font fallback for opencode's
|
|
||||||
Nerd Font private-use codepoints, not a patterm substitution.
|
|
||||||
Need a concrete reproduction (which codepoint, which host
|
|
||||||
terminal/font) before changing rendering.
|
|
||||||
- [ ] After codex rips for like 15 minutes, the terminal becomes quite slow. [ON HOLD / VERIFYING]
|
|
||||||
- 2026-05-14: Perf plan P1-P11 landed (see CHANGELOG). Needs a real
|
|
||||||
long-running codex session to confirm whether the steady-state
|
|
||||||
slowdown is gone or some hotspot remains. Capture a pprof if it
|
|
||||||
still feels slow after ≥15 minutes — the structural drivers the
|
|
||||||
audit named are all addressed, so a remaining symptom is a new
|
|
||||||
one and probably wants fresh profiling.
|
|
||||||
|
|||||||
@@ -108,7 +108,7 @@ func run(argv []string, cols, rows uint16, idleMS int, followHost, stdinPassthro
|
|||||||
}
|
}
|
||||||
defer em.Close()
|
defer em.Close()
|
||||||
|
|
||||||
child, err := pty.Start(argv, nil, cols, rows)
|
child, err := pty.Start(argv, nil, "", cols, rows)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return fmt.Errorf("pty: %w", err)
|
return fmt.Errorf("pty: %w", err)
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -1,61 +0,0 @@
|
|||||||
claude + new │ Processes
|
|
||||||
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━───────│ ─────────────────────────
|
|
||||||
- abc1234 if no tag exists yet
|
|
||||||
|
|
||||||
4. Wire version into the release workflow
|
|
||||||
|
|
||||||
Update .gitea/workflows/release.yml lines 31-35 to inject the pushed tag:
|
|
||||||
|
|
||||||
go build -trimpath \
|
|
||||||
-ldflags="-s -w -X main.version=${{ github.ref_name }}" \
|
|
||||||
-o dist/patterm-${{ github.ref_name }}-linux-amd64 \
|
|
||||||
./cmd/patterm
|
|
||||||
|
|
||||||
github.ref_name is the tag name (e.g. v0.0.1) because the workflow only
|
|
||||||
triggers on tags: ['v*'].
|
|
||||||
|
|
||||||
5. Update inline doc comment
|
|
||||||
|
|
||||||
cmd/patterm/main.go header comment (lines 5-11) — add the --version form
|
|
||||||
to the usage block. SPEC.md/CLAUDE.md already use --, no change needed there.
|
|
||||||
|
|
||||||
Out of scope
|
|
||||||
|
|
||||||
- Surfacing version in MCP whoami (the hardcoded "version": "0.1.0" in
|
|
||||||
internal/mcp/protocol.go:27 is the MCP protocol version, not the patterm
|
|
||||||
binary version — leave it).
|
|
||||||
- Renaming any existing flags.
|
|
||||||
- Adding short forms like -p for --project.
|
|
||||||
|
|
||||||
Critical files
|
|
||||||
|
|
||||||
- cmd/patterm/main.go — import swap, --version wiring, version var, header comment
|
|
||||||
- cmd/patterm/debug_harness.go — import swap
|
|
||||||
- Makefile lines 38-39 — VERSION var + ldflags
|
|
||||||
- .gitea/workflows/release.yml lines 31-35 — ldflags
|
|
||||||
- go.mod / go.sum — add github.com/spf13/pflag
|
|
||||||
|
|
||||||
Verification
|
|
||||||
|
|
||||||
1. go build -o ./bin/patterm ./cmd/patterm (without Makefile) → still builds, version reports dev.
|
|
||||||
2. make patterm → ./bin/patterm --version prints patterm v0.0.1 (commit <sha>, built <date>).
|
|
||||||
3. ./bin/patterm -h → help text shows --project string and --version lines.
|
|
||||||
4. ./bin/patterm -project /tmp → pflag rejects with usage error (confirms -- is enforced).
|
|
||||||
5. ./bin/patterm --project /tmp → starts normally.
|
|
||||||
6. ./bin/patterm mcp-stdio --socket /tmp/s --identity x → existing path still works (will fail to connect, but should parse flags fine).
|
|
||||||
7. ./bin/patterm debug-harness --scenario internal/harness/scenarios/spawn_process_via_palette.json → harness still runs.
|
|
||||||
8. go test ./... and go test ./internal/harness/... — both green.
|
|
||||||
9. Push a temporary tag locally and inspect git describe output; confirm release workflow's ${{ github.ref_name }} substitution matches the tag.
|
|
||||||
╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌
|
|
||||||
|
|
||||||
Claude has written up a plan and is ready to execute. Would you like to proceed?
|
|
||||||
|
|
||||||
❯ 1. Yes, and use auto mode
|
|
||||||
2. Yes, manually approve edits
|
|
||||||
3. No, refine with Ultraplan on Claude Code on the web
|
|
||||||
4. Tell Claude what to change
|
|
||||||
shift+tab to approve with this feedback
|
|
||||||
|
|
||||||
ctrl-g to edit in VS Code · ~/.claude/plans/flags-in-this-project-vectorized-gosling.md
|
|
||||||
|
|
||||||
claude · you have control Ctrl-A/D · tabs · Ctrl-W/S · tree · Ctrl-K · palette
|
|
||||||
@@ -161,6 +161,21 @@ func Run(ctx context.Context, opts Options) error {
|
|||||||
// ctx is cancelled.
|
// ctx is cancelled.
|
||||||
go sess.runClassifier(ctx)
|
go sess.runClassifier(ctx)
|
||||||
|
|
||||||
|
core := &headlessCore{
|
||||||
|
projectDir: opts.ProjectDir,
|
||||||
|
projectKey: opts.ProjectKey,
|
||||||
|
presets: presets,
|
||||||
|
settings: appSettings,
|
||||||
|
pads: pads,
|
||||||
|
trustStore: trustStore,
|
||||||
|
persistStore: persistStore,
|
||||||
|
mcpSrv: mcpSrv,
|
||||||
|
sess: sess,
|
||||||
|
launcher: launcher,
|
||||||
|
host: host,
|
||||||
|
}
|
||||||
|
_ = core
|
||||||
|
|
||||||
st := &uiState{
|
st := &uiState{
|
||||||
sess: sess,
|
sess: sess,
|
||||||
presets: presets,
|
presets: presets,
|
||||||
@@ -171,6 +186,12 @@ func Run(ctx context.Context, opts Options) error {
|
|||||||
timers: host.timers,
|
timers: host.timers,
|
||||||
hostCols: cols,
|
hostCols: cols,
|
||||||
hostRows: rows,
|
hostRows: rows,
|
||||||
|
view: ClientView{
|
||||||
|
ID: "loopback",
|
||||||
|
ProjectKey: opts.ProjectKey,
|
||||||
|
Cols: cols,
|
||||||
|
Rows: rows,
|
||||||
|
},
|
||||||
stdinTTY: term.IsTerminal(int(os.Stdin.Fd())),
|
stdinTTY: term.IsTerminal(int(os.Stdin.Fd())),
|
||||||
metrics: metrics,
|
metrics: metrics,
|
||||||
settings: appSettings,
|
settings: appSettings,
|
||||||
@@ -187,9 +208,7 @@ func Run(ctx context.Context, opts Options) error {
|
|||||||
}, func(_ string, result summaryState) {
|
}, func(_ string, result summaryState) {
|
||||||
if result.Error != "" {
|
if result.Error != "" {
|
||||||
st.flashError(fmt.Sprintf("summary: %v", result.Error))
|
st.flashError(fmt.Sprintf("summary: %v", result.Error))
|
||||||
return
|
|
||||||
}
|
}
|
||||||
st.flashTransient("summary updated")
|
|
||||||
})
|
})
|
||||||
sess.SetMetrics(metrics)
|
sess.SetMetrics(metrics)
|
||||||
host.attention = st
|
host.attention = st
|
||||||
@@ -254,6 +273,7 @@ func Run(ctx context.Context, opts Options) error {
|
|||||||
}
|
}
|
||||||
st.dimsMu.Lock()
|
st.dimsMu.Lock()
|
||||||
st.hostCols, st.hostRows = c, r
|
st.hostCols, st.hostRows = c, r
|
||||||
|
st.view.Resize(c, r)
|
||||||
l := st.layoutLocked()
|
l := st.layoutLocked()
|
||||||
st.dimsMu.Unlock()
|
st.dimsMu.Unlock()
|
||||||
st.mu.Lock()
|
st.mu.Lock()
|
||||||
@@ -328,6 +348,15 @@ func Run(ctx context.Context, opts Options) error {
|
|||||||
}
|
}
|
||||||
}()
|
}()
|
||||||
|
|
||||||
|
// Timer sidebar refresher: countdown labels are computed at draw
|
||||||
|
// time, so wake the sidebar when the next visible timer bucket is
|
||||||
|
// due to change even if no child PTY output arrives.
|
||||||
|
wg.Add(1)
|
||||||
|
go func() {
|
||||||
|
defer wg.Done()
|
||||||
|
st.runTimerSidebarRefresher(ctx)
|
||||||
|
}()
|
||||||
|
|
||||||
// Marquee ticker: while a focused sidebar row's name overflows the
|
// Marquee ticker: while a focused sidebar row's name overflows the
|
||||||
// rail width, advance the pause-scroll-pause animation by marking
|
// rail width, advance the pause-scroll-pause animation by marking
|
||||||
// the sidebar dirty every marqueeStep. The chrome ticker above does
|
// the sidebar dirty every marqueeStep. The chrome ticker above does
|
||||||
@@ -401,6 +430,7 @@ type uiState struct {
|
|||||||
outMu sync.Mutex
|
outMu sync.Mutex
|
||||||
|
|
||||||
mu sync.Mutex
|
mu sync.Mutex
|
||||||
|
view ClientView
|
||||||
palette *paletteState
|
palette *paletteState
|
||||||
focusedID string
|
focusedID string
|
||||||
focusedName string
|
focusedName string
|
||||||
@@ -432,10 +462,11 @@ type uiState struct {
|
|||||||
repaintNextPTY string
|
repaintNextPTY string
|
||||||
repaintNextPTYBudget int
|
repaintNextPTYBudget int
|
||||||
|
|
||||||
// attention is the latest request_human_attention surfaced via MCP;
|
// toasts is the stackable notification surface. flashError,
|
||||||
// rendered in the status line until cleared.
|
// flashTransient, and notifyAttention all push onto it; the user
|
||||||
attentionText string
|
// dismisses entries with Ctrl-N or the "Clear notifications"
|
||||||
attentionAt string
|
// palette command.
|
||||||
|
toasts toastStack
|
||||||
|
|
||||||
// pendingTrust is the most recent trust prompt — surfaced in the
|
// pendingTrust is the most recent trust prompt — surfaced in the
|
||||||
// status line until the user resolves it with Ctrl-K. v1 keeps the
|
// status line until the user resolves it with Ctrl-K. v1 keeps the
|
||||||
@@ -506,7 +537,32 @@ func (st *uiState) dbgf(format string, args ...any) {
|
|||||||
}
|
}
|
||||||
|
|
||||||
func (st *uiState) activeSummaryText(width int) string {
|
func (st *uiState) activeSummaryText(width int) string {
|
||||||
if width <= 0 || st.summaries == nil {
|
st.mu.Lock()
|
||||||
|
active := st.activeAgentID
|
||||||
|
st.mu.Unlock()
|
||||||
|
return st.summaryTextFor(active, width)
|
||||||
|
}
|
||||||
|
|
||||||
|
func (st *uiState) summaryTextFor(childID string, width int) string {
|
||||||
|
text := st.summaryRawFor(childID)
|
||||||
|
if text == "" || width <= 0 {
|
||||||
|
return ""
|
||||||
|
}
|
||||||
|
if visibleLen(text) > width {
|
||||||
|
text = clipRunes(text, width-1) + "…"
|
||||||
|
}
|
||||||
|
return text
|
||||||
|
}
|
||||||
|
|
||||||
|
func (st *uiState) activeSummaryRaw() string {
|
||||||
|
st.mu.Lock()
|
||||||
|
active := st.activeAgentID
|
||||||
|
st.mu.Unlock()
|
||||||
|
return st.summaryRawFor(active)
|
||||||
|
}
|
||||||
|
|
||||||
|
func (st *uiState) summaryRawFor(childID string) string {
|
||||||
|
if st.summaries == nil || childID == "" {
|
||||||
return ""
|
return ""
|
||||||
}
|
}
|
||||||
st.settingsMu.Lock()
|
st.settingsMu.Lock()
|
||||||
@@ -515,20 +571,11 @@ func (st *uiState) activeSummaryText(width int) string {
|
|||||||
if !enabled {
|
if !enabled {
|
||||||
return ""
|
return ""
|
||||||
}
|
}
|
||||||
st.mu.Lock()
|
sum := st.summaries.Summary(childID)
|
||||||
active := st.activeAgentID
|
|
||||||
st.mu.Unlock()
|
|
||||||
if active == "" {
|
|
||||||
return ""
|
|
||||||
}
|
|
||||||
sum := st.summaries.Summary(active)
|
|
||||||
text := strings.TrimSpace(sum.Text)
|
text := strings.TrimSpace(sum.Text)
|
||||||
if text == "" {
|
if text == "" {
|
||||||
return ""
|
return ""
|
||||||
}
|
}
|
||||||
if visibleLen(text) > width {
|
|
||||||
text = clipRunes(text, width-1) + "…"
|
|
||||||
}
|
|
||||||
return text
|
return text
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -550,6 +597,21 @@ func (st *uiState) promptTrust(processID, presetName, reason string) {
|
|||||||
st.drawStatusLine()
|
st.drawStatusLine()
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func (st *uiState) focusChildLocked(c *Child) {
|
||||||
|
st.focusedPad = ""
|
||||||
|
st.focusedID = c.ID
|
||||||
|
st.focusedName = c.DisplayName()
|
||||||
|
st.view.FocusChild(c.ID)
|
||||||
|
}
|
||||||
|
|
||||||
|
func (st *uiState) focusPadLocked(name string) {
|
||||||
|
st.view.FocusPad(name)
|
||||||
|
st.focusedPad = st.view.FocusedPad
|
||||||
|
st.focusedID = st.view.FocusedID
|
||||||
|
st.padOffset = st.view.PadOffset
|
||||||
|
st.padOffsetName = st.view.PadOffsetName
|
||||||
|
}
|
||||||
|
|
||||||
// focusProcess is the SPEC §7 select_process hook. Routes through the
|
// focusProcess is the SPEC §7 select_process hook. Routes through the
|
||||||
// normal focus-change path; only takes effect if the process exists.
|
// normal focus-change path; only takes effect if the process exists.
|
||||||
func (st *uiState) focusProcess(processID string) {
|
func (st *uiState) focusProcess(processID string) {
|
||||||
@@ -562,9 +624,7 @@ func (st *uiState) focusProcess(processID string) {
|
|||||||
onAlt := childIsOnAlt(c)
|
onAlt := childIsOnAlt(c)
|
||||||
st.mu.Lock()
|
st.mu.Lock()
|
||||||
leavingPad := st.focusedPad != ""
|
leavingPad := st.focusedPad != ""
|
||||||
st.focusedPad = ""
|
st.focusChildLocked(c)
|
||||||
st.focusedID = c.ID
|
|
||||||
st.focusedName = c.DisplayName()
|
|
||||||
st.updateActiveAgentLocked(c)
|
st.updateActiveAgentLocked(c)
|
||||||
r := newViewportRenderer(layout)
|
r := newViewportRenderer(layout)
|
||||||
r.SetChildOnAlt(onAlt)
|
r.SetChildOnAlt(onAlt)
|
||||||
@@ -627,12 +687,7 @@ func (st *uiState) focusScratchpad(name string) {
|
|||||||
}
|
}
|
||||||
st.marquee.reset()
|
st.marquee.reset()
|
||||||
st.mu.Lock()
|
st.mu.Lock()
|
||||||
if st.padOffsetName != name {
|
st.focusPadLocked(name)
|
||||||
st.padOffset = 0
|
|
||||||
st.padOffsetName = name
|
|
||||||
}
|
|
||||||
st.focusedPad = name
|
|
||||||
st.focusedID = ""
|
|
||||||
st.focusedName = name
|
st.focusedName = name
|
||||||
st.renderer = nil
|
st.renderer = nil
|
||||||
st.mu.Unlock()
|
st.mu.Unlock()
|
||||||
@@ -664,6 +719,20 @@ func (st *uiState) clearViewportArea() {
|
|||||||
_, _ = os.Stdout.WriteString(b.String())
|
_, _ = os.Stdout.WriteString(b.String())
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func (st *uiState) repaintFocusedWithChrome() {
|
||||||
|
st.mu.Lock()
|
||||||
|
padFocused := st.focusedPad != ""
|
||||||
|
st.mu.Unlock()
|
||||||
|
if padFocused {
|
||||||
|
st.repaintFocusedPad()
|
||||||
|
} else {
|
||||||
|
st.repaintFocused()
|
||||||
|
}
|
||||||
|
st.drawTabBar()
|
||||||
|
st.drawSidebar()
|
||||||
|
st.drawStatusLine()
|
||||||
|
}
|
||||||
|
|
||||||
func (st *uiState) restartFocusedCommand(processID string) {
|
func (st *uiState) restartFocusedCommand(processID string) {
|
||||||
c := st.sess.FindChild(processID)
|
c := st.sess.FindChild(processID)
|
||||||
if c == nil || c.Kind != KindCommand {
|
if c == nil || c.Kind != KindCommand {
|
||||||
@@ -673,21 +742,24 @@ func (st *uiState) restartFocusedCommand(processID string) {
|
|||||||
layout := st.layoutSnapshot()
|
layout := st.layoutSnapshot()
|
||||||
renderer := newViewportRenderer(layout)
|
renderer := newViewportRenderer(layout)
|
||||||
st.mu.Lock()
|
st.mu.Lock()
|
||||||
st.focusedID = c.ID
|
st.focusChildLocked(c)
|
||||||
st.focusedName = c.DisplayName()
|
|
||||||
st.renderer = renderer
|
st.renderer = renderer
|
||||||
st.repaintNextPTY = c.ID
|
st.repaintNextPTY = c.ID
|
||||||
st.repaintNextPTYBudget = 2
|
st.repaintNextPTYBudget = 2
|
||||||
st.mu.Unlock()
|
st.mu.Unlock()
|
||||||
|
|
||||||
st.outMu.Lock()
|
st.repaintFocusedWithChrome()
|
||||||
_, _ = os.Stdout.Write(renderer.ClearViewport())
|
|
||||||
st.outMu.Unlock()
|
|
||||||
|
|
||||||
if err := st.sess.Restart(c.ID, syscall.SIGTERM, layout.childCols(), layout.childRows()); err != nil {
|
if err := st.sess.Restart(c.ID, syscall.SIGTERM, layout.childCols(), layout.childRows()); err != nil {
|
||||||
st.flashError(fmt.Sprintf("restart %s: %v", c.DisplayName(), err))
|
st.flashError(fmt.Sprintf("restart %s: %v", c.DisplayName(), err))
|
||||||
|
st.drawTabBar()
|
||||||
|
st.drawSidebar()
|
||||||
|
st.drawStatusLine()
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
|
st.outMu.Lock()
|
||||||
|
_, _ = os.Stdout.Write(renderer.ClearViewport())
|
||||||
|
st.outMu.Unlock()
|
||||||
st.moveToViewportOrigin()
|
st.moveToViewportOrigin()
|
||||||
st.drawTabBar()
|
st.drawTabBar()
|
||||||
st.drawSidebar()
|
st.drawSidebar()
|
||||||
@@ -705,6 +777,7 @@ func (st *uiState) updateActiveAgentLocked(c *Child) {
|
|||||||
}
|
}
|
||||||
if c.ParentID == "" {
|
if c.ParentID == "" {
|
||||||
st.activeAgentID = c.ID
|
st.activeAgentID = c.ID
|
||||||
|
st.view.ActiveAgentID = c.ID
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
// Walk up to the top-level agent.
|
// Walk up to the top-level agent.
|
||||||
@@ -718,33 +791,24 @@ func (st *uiState) updateActiveAgentLocked(c *Child) {
|
|||||||
}
|
}
|
||||||
if root.Kind == KindAgent && root.ParentID == "" {
|
if root.Kind == KindAgent && root.ParentID == "" {
|
||||||
st.activeAgentID = root.ID
|
st.activeAgentID = root.ID
|
||||||
|
st.view.ActiveAgentID = root.ID
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
// notifyAttention is the request_human_attention sink (SPEC §7). We
|
// notifyAttention is the request_human_attention sink (SPEC §7). We
|
||||||
// surface a one-line toast in the status row and remember the most
|
// push a toast onto the stack; the focused-pane render path picks it
|
||||||
// recent ask so the status line keeps showing it. The sidebar-blink is
|
// up. The sidebar-blink is deferred until the §4 chrome lands.
|
||||||
// deferred until the §4 chrome lands.
|
|
||||||
func (st *uiState) notifyAttention(childID, reason string) {
|
func (st *uiState) notifyAttention(childID, reason string) {
|
||||||
c := st.sess.FindChild(childID)
|
c := st.sess.FindChild(childID)
|
||||||
name := childID
|
name := childID
|
||||||
if c != nil {
|
if c != nil {
|
||||||
name = c.DisplayName()
|
name = c.DisplayName()
|
||||||
}
|
}
|
||||||
st.mu.Lock()
|
st.notifyToast(toastAttention, fmt.Sprintf("%s — %s", name, reason))
|
||||||
st.attentionText = fmt.Sprintf("attention: %s — %s", name, reason)
|
|
||||||
st.attentionAt = childID
|
|
||||||
st.mu.Unlock()
|
|
||||||
st.drawStatusLine()
|
|
||||||
}
|
}
|
||||||
|
|
||||||
func (st *uiState) scratchpadsChanged() {
|
func (st *uiState) scratchpadsChanged() {
|
||||||
st.padsCacheMu.Lock()
|
st.invalidateScratchpadsCache()
|
||||||
st.padsCache = nil
|
|
||||||
st.padsCacheMu.Unlock()
|
|
||||||
st.chromeCacheMu.Lock()
|
|
||||||
st.sidebarCache = ""
|
|
||||||
st.chromeCacheMu.Unlock()
|
|
||||||
st.drawSidebar()
|
st.drawSidebar()
|
||||||
st.mu.Lock()
|
st.mu.Lock()
|
||||||
focusedPad := st.focusedPad
|
focusedPad := st.focusedPad
|
||||||
@@ -754,6 +818,15 @@ func (st *uiState) scratchpadsChanged() {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func (st *uiState) invalidateScratchpadsCache() {
|
||||||
|
st.padsCacheMu.Lock()
|
||||||
|
st.padsCache = nil
|
||||||
|
st.padsCacheMu.Unlock()
|
||||||
|
st.chromeCacheMu.Lock()
|
||||||
|
st.sidebarCache = ""
|
||||||
|
st.chromeCacheMu.Unlock()
|
||||||
|
}
|
||||||
|
|
||||||
// OnChildSpawned auto-focuses the new child when the spawn came from
|
// OnChildSpawned auto-focuses the new child when the spawn came from
|
||||||
// the user (palette, persistence restore, or an external MCP client with
|
// the user (palette, persistence restore, or an external MCP client with
|
||||||
// no resolved identity). When ParentID is set — meaning a patterm-managed
|
// no resolved identity). When ParentID is set — meaning a patterm-managed
|
||||||
@@ -781,9 +854,7 @@ func (st *uiState) OnChildSpawned(c *Child) {
|
|||||||
layout := st.layoutSnapshot()
|
layout := st.layoutSnapshot()
|
||||||
onAlt := childIsOnAlt(c)
|
onAlt := childIsOnAlt(c)
|
||||||
st.mu.Lock()
|
st.mu.Lock()
|
||||||
st.focusedPad = ""
|
st.focusChildLocked(c)
|
||||||
st.focusedID = c.ID
|
|
||||||
st.focusedName = c.DisplayName()
|
|
||||||
st.updateActiveAgentLocked(c)
|
st.updateActiveAgentLocked(c)
|
||||||
renderer := newViewportRenderer(layout)
|
renderer := newViewportRenderer(layout)
|
||||||
renderer.SetChildOnAlt(onAlt)
|
renderer.SetChildOnAlt(onAlt)
|
||||||
@@ -827,14 +898,21 @@ func (st *uiState) OnChildSpawned(c *Child) {
|
|||||||
st.drawStatusLine()
|
st.drawStatusLine()
|
||||||
}
|
}
|
||||||
|
|
||||||
// OnChildStateChanged repaints the sidebar whenever a child's
|
// OnChildStateChanged repaints the sidebar and tab bar whenever a
|
||||||
// idle-state badge flips. Cheap — the badge is the only chrome that
|
// child's idle-state badge flips. Cheap — both draws bail when the
|
||||||
// reflects state today, and drawSidebar bails when the cached frame
|
// cached frame hasn't changed.
|
||||||
// hasn't changed.
|
|
||||||
func (st *uiState) OnChildStateChanged(string, IdleState) {
|
func (st *uiState) OnChildStateChanged(string, IdleState) {
|
||||||
|
st.drawTabBar()
|
||||||
st.drawSidebar()
|
st.drawSidebar()
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// OnChildClosed is the explicit-removal hook (close_process or the
|
||||||
|
// terminal-corpse cleanup in reapChild). The UI already reflects
|
||||||
|
// removals via the OnChildExited path and the children-map view, so
|
||||||
|
// this is a no-op here — the timerManager is the consumer that
|
||||||
|
// cares.
|
||||||
|
func (st *uiState) OnChildClosed(string) {}
|
||||||
|
|
||||||
// OnChildExited drops focus and shows the empty state if it was the
|
// OnChildExited drops focus and shows the empty state if it was the
|
||||||
// focused child.
|
// focused child.
|
||||||
func (st *uiState) OnChildExited(c *Child) {
|
func (st *uiState) OnChildExited(c *Child) {
|
||||||
@@ -851,10 +929,10 @@ func (st *uiState) OnChildExited(c *Child) {
|
|||||||
if next == nil {
|
if next == nil {
|
||||||
st.focusedID = ""
|
st.focusedID = ""
|
||||||
st.focusedName = ""
|
st.focusedName = ""
|
||||||
|
st.view.FocusedID = ""
|
||||||
renderEmpty = true
|
renderEmpty = true
|
||||||
} else {
|
} else {
|
||||||
st.focusedID = next.ID
|
st.focusChildLocked(next)
|
||||||
st.focusedName = next.DisplayName()
|
|
||||||
st.updateActiveAgentLocked(next)
|
st.updateActiveAgentLocked(next)
|
||||||
st.renderer = newViewportRenderer(layout)
|
st.renderer = newViewportRenderer(layout)
|
||||||
}
|
}
|
||||||
@@ -863,6 +941,7 @@ func (st *uiState) OnChildExited(c *Child) {
|
|||||||
// The active agent died; pin the agent tree to whatever agent
|
// The active agent died; pin the agent tree to whatever agent
|
||||||
// root is still running, or clear it if none remain.
|
// root is still running, or clear it if none remain.
|
||||||
st.activeAgentID = firstRunningAgentID(st.sess.Children())
|
st.activeAgentID = firstRunningAgentID(st.sess.Children())
|
||||||
|
st.view.ActiveAgentID = st.activeAgentID
|
||||||
}
|
}
|
||||||
if st.palette != nil {
|
if st.palette != nil {
|
||||||
st.palette.children = st.sess.Children()
|
st.palette.children = st.sess.Children()
|
||||||
@@ -973,14 +1052,19 @@ func (st *uiState) OnPTYOut(childID string, chunk []byte) {
|
|||||||
st.metrics.recordRender(time.Since(rstart))
|
st.metrics.recordRender(time.Since(rstart))
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
// One write covers the autowrap-disable prelude, the chunk, and the
|
// One write covers the autowrap-disable prelude, the chunk, the
|
||||||
// autowrap-restore postlude — three syscalls collapsed into one
|
// autowrap-restore postlude, and (when a toast is up) the toast
|
||||||
// under outMu. The three sequences were already emitted atomically
|
// overlay — four syscalls collapsed into one under outMu. The
|
||||||
// under the lock; coalescing just halves the syscall count.
|
// sequences were already emitted atomically under the lock;
|
||||||
wrapped := make([]byte, 0, len(out)+10)
|
// coalescing just halves the syscall count and makes claude's
|
||||||
|
// continuous redraws + our toast layer land in the same frame so
|
||||||
|
// the box doesn't flicker as the child paints over its cells.
|
||||||
|
overlay := st.toastOverlayBytes()
|
||||||
|
wrapped := make([]byte, 0, len(out)+len(overlay)+10)
|
||||||
wrapped = append(wrapped, "\x1b[?7l"...)
|
wrapped = append(wrapped, "\x1b[?7l"...)
|
||||||
wrapped = append(wrapped, out...)
|
wrapped = append(wrapped, out...)
|
||||||
wrapped = append(wrapped, "\x1b[?7h"...)
|
wrapped = append(wrapped, "\x1b[?7h"...)
|
||||||
|
wrapped = append(wrapped, overlay...)
|
||||||
var wstart time.Time
|
var wstart time.Time
|
||||||
if st.metrics != nil {
|
if st.metrics != nil {
|
||||||
wstart = time.Now()
|
wstart = time.Now()
|
||||||
@@ -1129,6 +1213,55 @@ func (st *uiState) markSidebarDirty() {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func (st *uiState) runTimerSidebarRefresher(ctx context.Context) {
|
||||||
|
if st.timers == nil {
|
||||||
|
<-ctx.Done()
|
||||||
|
return
|
||||||
|
}
|
||||||
|
changes := st.timers.changeEvents()
|
||||||
|
var timer *time.Timer
|
||||||
|
var timerC <-chan time.Time
|
||||||
|
stop := func() {
|
||||||
|
if timer == nil {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
if !timer.Stop() {
|
||||||
|
select {
|
||||||
|
case <-timer.C:
|
||||||
|
default:
|
||||||
|
}
|
||||||
|
}
|
||||||
|
timer = nil
|
||||||
|
timerC = nil
|
||||||
|
}
|
||||||
|
arm := func() {
|
||||||
|
stop()
|
||||||
|
wait, ok := st.timers.nextSidebarRefreshAfter(time.Now())
|
||||||
|
if !ok {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
if wait < timerSidebarMinRefresh {
|
||||||
|
wait = timerSidebarMinRefresh
|
||||||
|
}
|
||||||
|
timer = time.NewTimer(wait)
|
||||||
|
timerC = timer.C
|
||||||
|
}
|
||||||
|
defer stop()
|
||||||
|
arm()
|
||||||
|
for {
|
||||||
|
select {
|
||||||
|
case <-ctx.Done():
|
||||||
|
return
|
||||||
|
case <-changes:
|
||||||
|
st.markSidebarDirty()
|
||||||
|
arm()
|
||||||
|
case <-timerC:
|
||||||
|
st.markSidebarDirty()
|
||||||
|
arm()
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
func (st *uiState) invalidateChromeCache() {
|
func (st *uiState) invalidateChromeCache() {
|
||||||
st.chromeCacheMu.Lock()
|
st.chromeCacheMu.Lock()
|
||||||
st.tabBarCache = ""
|
st.tabBarCache = ""
|
||||||
@@ -1167,8 +1300,6 @@ func (st *uiState) drawStatusLine() {
|
|||||||
palOpen := st.palette != nil
|
palOpen := st.palette != nil
|
||||||
focusID := st.focusedID
|
focusID := st.focusedID
|
||||||
focusName := st.focusedName
|
focusName := st.focusedName
|
||||||
attention := st.attentionText
|
|
||||||
attentionAt := st.attentionAt
|
|
||||||
var trustMsg string
|
var trustMsg string
|
||||||
if st.pendingTrust != nil {
|
if st.pendingTrust != nil {
|
||||||
trustMsg = fmt.Sprintf("trust preset %q? [y]es / [n]o", st.pendingTrust.presetName)
|
trustMsg = fmt.Sprintf("trust preset %q? [y]es / [n]o", st.pendingTrust.presetName)
|
||||||
@@ -1208,13 +1339,6 @@ func (st *uiState) drawStatusLine() {
|
|||||||
left = owner
|
left = owner
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
if attention != "" && attentionAt == focusID {
|
|
||||||
left = "[!] " + attention
|
|
||||||
}
|
|
||||||
if attention != "" && attentionAt == "" {
|
|
||||||
// Sticky attention/flash from somewhere outside the focused pane.
|
|
||||||
left = "[!] " + attention
|
|
||||||
}
|
|
||||||
if trustMsg != "" {
|
if trustMsg != "" {
|
||||||
left = "[trust] " + trustMsg
|
left = "[trust] " + trustMsg
|
||||||
}
|
}
|
||||||
@@ -1232,6 +1356,12 @@ func (st *uiState) drawStatusLine() {
|
|||||||
hints = append(hints, "Ctrl-R · restart")
|
hints = append(hints, "Ctrl-R · restart")
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
// Surface the toast-dismiss chord only while a notification is on
|
||||||
|
// screen — the hint is noise otherwise, and Ctrl-N falls through
|
||||||
|
// to the focused PTY when the stack is empty.
|
||||||
|
if st.toasts.length() > 0 {
|
||||||
|
hints = append(hints, "Ctrl-N · dismiss")
|
||||||
|
}
|
||||||
right := strings.Join(hints, " · ")
|
right := strings.Join(hints, " · ")
|
||||||
for len(hints) > 1 && int(cols)-len(left)-len(right) < 1 {
|
for len(hints) > 1 && int(cols)-len(left)-len(right) < 1 {
|
||||||
hints = hints[1:]
|
hints = hints[1:]
|
||||||
@@ -1270,8 +1400,6 @@ func (st *uiState) drawStatusLine() {
|
|||||||
// child is focused.
|
// child is focused.
|
||||||
func (st *uiState) renderEmptyState() {
|
func (st *uiState) renderEmptyState() {
|
||||||
layout := st.layoutSnapshot()
|
layout := st.layoutSnapshot()
|
||||||
st.outMu.Lock()
|
|
||||||
defer st.outMu.Unlock()
|
|
||||||
line := "Press Ctrl-K to spawn an agent or process"
|
line := "Press Ctrl-K to spawn an agent or process"
|
||||||
row := int(layout.mainTop) + (int(layout.childRows()) / 2)
|
row := int(layout.mainTop) + (int(layout.childRows()) / 2)
|
||||||
col := int(layout.mainLeft) + ((int(layout.childCols()) - len(line)) / 2)
|
col := int(layout.mainLeft) + ((int(layout.childCols()) - len(line)) / 2)
|
||||||
@@ -1281,14 +1409,20 @@ func (st *uiState) renderEmptyState() {
|
|||||||
if col < int(layout.mainLeft) {
|
if col < int(layout.mainLeft) {
|
||||||
col = int(layout.mainLeft)
|
col = int(layout.mainLeft)
|
||||||
}
|
}
|
||||||
|
st.outMu.Lock()
|
||||||
fmt.Fprintf(os.Stdout, "\x1b[?25l\x1b[H\x1b[2J\x1b[%d;%dH\x1b[2m%s\x1b[0m", row, col, line)
|
fmt.Fprintf(os.Stdout, "\x1b[?25l\x1b[H\x1b[2J\x1b[%d;%dH\x1b[2m%s\x1b[0m", row, col, line)
|
||||||
|
st.outMu.Unlock()
|
||||||
|
st.renderToasts()
|
||||||
}
|
}
|
||||||
|
|
||||||
func (st *uiState) hostSizeSnapshot() (uint16, uint16) {
|
func (st *uiState) hostSizeSnapshot() (uint16, uint16) {
|
||||||
st.dimsMu.Lock()
|
st.dimsMu.Lock()
|
||||||
defer st.dimsMu.Unlock()
|
defer st.dimsMu.Unlock()
|
||||||
|
if st.view.Cols == 0 || st.view.Rows == 0 {
|
||||||
return st.hostCols, st.hostRows
|
return st.hostCols, st.hostRows
|
||||||
}
|
}
|
||||||
|
return st.view.Cols, st.view.Rows
|
||||||
|
}
|
||||||
|
|
||||||
func (st *uiState) layoutSnapshot() terminalLayout {
|
func (st *uiState) layoutSnapshot() terminalLayout {
|
||||||
st.dimsMu.Lock()
|
st.dimsMu.Lock()
|
||||||
@@ -1297,8 +1431,11 @@ func (st *uiState) layoutSnapshot() terminalLayout {
|
|||||||
}
|
}
|
||||||
|
|
||||||
func (st *uiState) layoutLocked() terminalLayout {
|
func (st *uiState) layoutLocked() terminalLayout {
|
||||||
|
if st.view.Cols == 0 || st.view.Rows == 0 {
|
||||||
return newTerminalLayout(st.hostCols, st.hostRows)
|
return newTerminalLayout(st.hostCols, st.hostRows)
|
||||||
}
|
}
|
||||||
|
return newTerminalLayout(st.view.Cols, st.view.Rows)
|
||||||
|
}
|
||||||
|
|
||||||
// splitOnEnter walks input and returns each Enter byte (CR or LF) as
|
// splitOnEnter walks input and returns each Enter byte (CR or LF) as
|
||||||
// its own slice, with the surrounding non-Enter bytes batched between.
|
// its own slice, with the surrounding non-Enter bytes batched between.
|
||||||
@@ -1412,6 +1549,7 @@ func (st *uiState) processStdin(chunk []byte) {
|
|||||||
var pendingViewportBottom bool
|
var pendingViewportBottom bool
|
||||||
var pendingPadStep int
|
var pendingPadStep int
|
||||||
var pendingPadExit bool
|
var pendingPadExit bool
|
||||||
|
var pendingDismissToast bool
|
||||||
|
|
||||||
flushForward := func() {
|
flushForward := func() {
|
||||||
if len(forward) == 0 {
|
if len(forward) == 0 {
|
||||||
@@ -1420,9 +1558,10 @@ func (st *uiState) processStdin(chunk []byte) {
|
|||||||
if st.focusedID != "" {
|
if st.focusedID != "" {
|
||||||
if c := st.sess.FindChild(st.focusedID); c != nil && c.Status() == StatusRunning {
|
if c := st.sess.FindChild(st.focusedID); c != nil && c.Status() == StatusRunning {
|
||||||
prev := c.Owner()
|
prev := c.Owner()
|
||||||
// InjectAsUser splits Enter bytes onto their own
|
// Agent panes split Enter bytes onto their own writes
|
||||||
// writes so claude / codex / opencode don't treat a
|
// so claude / codex / opencode don't treat a
|
||||||
// "text\r" batch as a paste.
|
// "text\r" batch as a paste. Raw terminals keep paste
|
||||||
|
// bytes batched.
|
||||||
_ = c.InjectAsUser(forward)
|
_ = c.InjectAsUser(forward)
|
||||||
if st.summaries != nil {
|
if st.summaries != nil {
|
||||||
st.summaries.ObserveHumanInput(c.ID, forward)
|
st.summaries.ObserveHumanInput(c.ID, forward)
|
||||||
@@ -1598,6 +1737,11 @@ func (st *uiState) processStdin(chunk []byte) {
|
|||||||
} else if hit, _ := matchCtrlChar(chunk, i, 'd'); hit {
|
} else if hit, _ := matchCtrlChar(chunk, i, 'd'); hit {
|
||||||
} else if hit, _ := matchCtrlChar(chunk, i, 'w'); hit {
|
} else if hit, _ := matchCtrlChar(chunk, i, 'w'); hit {
|
||||||
} else if hit, _ := matchCtrlChar(chunk, i, 's'); hit {
|
} else if hit, _ := matchCtrlChar(chunk, i, 's'); hit {
|
||||||
|
} else if hit, _ := matchCtrlChar(chunk, i, 'n'); hit {
|
||||||
|
// Ctrl-N is the toast dismiss key. In pad view we
|
||||||
|
// allow it through the chord block so the handler
|
||||||
|
// below can fire even though pads otherwise swallow
|
||||||
|
// bytes.
|
||||||
} else {
|
} else {
|
||||||
i++
|
i++
|
||||||
continue
|
continue
|
||||||
@@ -1623,6 +1767,11 @@ func (st *uiState) processStdin(chunk []byte) {
|
|||||||
adv = 1
|
adv = 1
|
||||||
}
|
}
|
||||||
i += adv
|
i += adv
|
||||||
|
if action.kind == "settings-save" {
|
||||||
|
st.applySettingsAction(action)
|
||||||
|
st.renderPaletteLocked()
|
||||||
|
continue
|
||||||
|
}
|
||||||
if done {
|
if done {
|
||||||
a := action
|
a := action
|
||||||
pendingAction = &a
|
pendingAction = &a
|
||||||
@@ -1696,6 +1845,22 @@ func (st *uiState) processStdin(chunk []byte) {
|
|||||||
break
|
break
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
// Ctrl-N dismisses the most recent toast. We only consume the
|
||||||
|
// chord when there's actually a toast to dismiss; otherwise the
|
||||||
|
// bytes fall through to the focused PTY so readline /
|
||||||
|
// nano / emacs / opencode keep working in shells and editors.
|
||||||
|
if hit, adv := matchCtrlChar(chunk, i, 'n'); hit {
|
||||||
|
if st.toasts.length() > 0 {
|
||||||
|
flushForward()
|
||||||
|
pendingDismissToast = true
|
||||||
|
i += adv
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
forward = append(forward, chunk[i:i+adv]...)
|
||||||
|
i += adv
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
|
||||||
// Ctrl-B snaps the focused child's emulator viewport back to the
|
// Ctrl-B snaps the focused child's emulator viewport back to the
|
||||||
// active area. Use this as the escape hatch from a scrolled-up
|
// active area. Use this as the escape hatch from a scrolled-up
|
||||||
// state — wheel scrolls move the viewport into the libghostty
|
// state — wheel scrolls move the viewport into the libghostty
|
||||||
@@ -1777,6 +1942,11 @@ func (st *uiState) processStdin(chunk []byte) {
|
|||||||
if pendingPadExit {
|
if pendingPadExit {
|
||||||
st.exitPadView()
|
st.exitPadView()
|
||||||
}
|
}
|
||||||
|
if pendingDismissToast {
|
||||||
|
if st.toasts.dismissTop() {
|
||||||
|
st.refreshToastSurface()
|
||||||
|
}
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
// scrollFocusedViewport scrolls the focused child's emulator viewport by
|
// scrollFocusedViewport scrolls the focused child's emulator viewport by
|
||||||
@@ -1953,9 +2123,7 @@ func (st *uiState) closePalette(action paletteAction) {
|
|||||||
layout := st.layoutSnapshot()
|
layout := st.layoutSnapshot()
|
||||||
st.mu.Lock()
|
st.mu.Lock()
|
||||||
leavingPad := st.focusedPad != ""
|
leavingPad := st.focusedPad != ""
|
||||||
st.focusedPad = ""
|
st.focusChildLocked(c)
|
||||||
st.focusedID = action.childID
|
|
||||||
st.focusedName = c.DisplayName()
|
|
||||||
st.updateActiveAgentLocked(c)
|
st.updateActiveAgentLocked(c)
|
||||||
st.renderer = newViewportRenderer(layout)
|
st.renderer = newViewportRenderer(layout)
|
||||||
st.mu.Unlock()
|
st.mu.Unlock()
|
||||||
@@ -1985,6 +2153,11 @@ func (st *uiState) closePalette(action paletteAction) {
|
|||||||
case "quit":
|
case "quit":
|
||||||
st.requestExit()
|
st.requestExit()
|
||||||
|
|
||||||
|
case "toasts-clear":
|
||||||
|
if st.toasts.clear() {
|
||||||
|
st.refreshToastSurface()
|
||||||
|
}
|
||||||
|
|
||||||
case "pad-delete":
|
case "pad-delete":
|
||||||
st.handlePadDelete(action.padName)
|
st.handlePadDelete(action.padName)
|
||||||
|
|
||||||
@@ -2006,13 +2179,6 @@ func (st *uiState) closePalette(action paletteAction) {
|
|||||||
case "proc-restart":
|
case "proc-restart":
|
||||||
st.handleProcRestart(action.childID)
|
st.handleProcRestart(action.childID)
|
||||||
|
|
||||||
case "settings-close":
|
|
||||||
st.applySettingsAction(action)
|
|
||||||
restoreView()
|
|
||||||
st.drawTabBar()
|
|
||||||
st.drawSidebar()
|
|
||||||
st.drawStatusLine()
|
|
||||||
|
|
||||||
case "settings-test":
|
case "settings-test":
|
||||||
st.applySettingsAction(action)
|
st.applySettingsAction(action)
|
||||||
restoreView()
|
restoreView()
|
||||||
@@ -2089,20 +2255,45 @@ func (st *uiState) handlePadDelete(name string) {
|
|||||||
st.repaintFocused()
|
st.repaintFocused()
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
|
st.mu.Lock()
|
||||||
|
wasFocused := st.focusedPad == name
|
||||||
|
st.mu.Unlock()
|
||||||
if err := st.pads.Delete(name); err != nil {
|
if err := st.pads.Delete(name); err != nil {
|
||||||
st.flashError(fmt.Sprintf("delete %s: %v", name, err))
|
st.flashError(fmt.Sprintf("delete %s: %v", name, err))
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
|
if wasFocused {
|
||||||
|
st.invalidateScratchpadsCache()
|
||||||
|
if entries := st.padsList(); len(entries) > 0 {
|
||||||
|
next := entries[0].Name
|
||||||
st.mu.Lock()
|
st.mu.Lock()
|
||||||
if st.focusedPad == name {
|
st.focusPadLocked(next)
|
||||||
st.focusedPad = ""
|
st.focusedName = next
|
||||||
}
|
|
||||||
st.mu.Unlock()
|
st.mu.Unlock()
|
||||||
st.scratchpadsChanged()
|
st.repaintFocusedWithChrome()
|
||||||
st.repaintFocused()
|
return
|
||||||
|
}
|
||||||
|
if next := firstRunningTopLevel(st.sess.Children()); next != nil {
|
||||||
|
st.focusProcess(next.ID)
|
||||||
|
return
|
||||||
|
}
|
||||||
|
st.mu.Lock()
|
||||||
|
st.focusedPad = ""
|
||||||
|
st.view.FocusedPad = ""
|
||||||
|
st.focusedName = ""
|
||||||
|
st.padOffset = 0
|
||||||
|
st.padOffsetName = ""
|
||||||
|
st.view.PadOffset = 0
|
||||||
|
st.view.PadOffsetName = ""
|
||||||
|
st.mu.Unlock()
|
||||||
|
st.renderEmptyState()
|
||||||
st.drawTabBar()
|
st.drawTabBar()
|
||||||
st.drawSidebar()
|
st.drawSidebar()
|
||||||
st.drawStatusLine()
|
st.drawStatusLine()
|
||||||
|
return
|
||||||
|
}
|
||||||
|
st.scratchpadsChanged()
|
||||||
|
st.repaintFocusedWithChrome()
|
||||||
}
|
}
|
||||||
|
|
||||||
func (st *uiState) handlePadRename(oldName, newName string) {
|
func (st *uiState) handlePadRename(oldName, newName string) {
|
||||||
@@ -2120,7 +2311,7 @@ func (st *uiState) handlePadRename(oldName, newName string) {
|
|||||||
}
|
}
|
||||||
st.mu.Lock()
|
st.mu.Lock()
|
||||||
if st.focusedPad == oldName {
|
if st.focusedPad == oldName {
|
||||||
st.focusedPad = newName
|
st.focusPadLocked(newName)
|
||||||
}
|
}
|
||||||
st.mu.Unlock()
|
st.mu.Unlock()
|
||||||
st.scratchpadsChanged()
|
st.scratchpadsChanged()
|
||||||
@@ -2195,11 +2386,9 @@ func (st *uiState) handleChildRename(childID, newName string) {
|
|||||||
st.drawStatusLine()
|
st.drawStatusLine()
|
||||||
}
|
}
|
||||||
|
|
||||||
// handleChildClose removes a child entry entirely. For agents this is
|
// handleChildClose removes a child entry entirely for process deletes.
|
||||||
// equivalent to a SIGTERM kill (the entry is ephemeral and disappears
|
// For agent Close, it terminates the PTY with escalation but preserves
|
||||||
// from the session once the PTY exits). For command processes it's
|
// the exited pane so the user can still read the corpse.
|
||||||
// equivalent to the MCP close_process tool: SIGKILL if alive, then
|
|
||||||
// drop the entry so it stops appearing in the switch/restart lists.
|
|
||||||
func (st *uiState) handleChildClose(childID string, kill bool) {
|
func (st *uiState) handleChildClose(childID string, kill bool) {
|
||||||
if childID == "" {
|
if childID == "" {
|
||||||
st.repaintFocused()
|
st.repaintFocused()
|
||||||
@@ -2214,7 +2403,11 @@ func (st *uiState) handleChildClose(childID string, kill bool) {
|
|||||||
if kill {
|
if kill {
|
||||||
_ = st.sess.Close(childID, syscall.SIGKILL)
|
_ = st.sess.Close(childID, syscall.SIGKILL)
|
||||||
} else {
|
} else {
|
||||||
_ = st.sess.Kill(childID, syscall.SIGTERM)
|
go func() {
|
||||||
|
if err := st.sess.Terminate(childID, syscall.SIGTERM); err != nil {
|
||||||
|
logf("terminate child %s: %v", childID, err)
|
||||||
|
}
|
||||||
|
}()
|
||||||
}
|
}
|
||||||
st.repaintFocused()
|
st.repaintFocused()
|
||||||
st.drawTabBar()
|
st.drawTabBar()
|
||||||
@@ -2251,8 +2444,19 @@ func (st *uiState) handleProcRestart(childID string) {
|
|||||||
return
|
return
|
||||||
}
|
}
|
||||||
layout := st.layoutSnapshot()
|
layout := st.layoutSnapshot()
|
||||||
|
st.mu.Lock()
|
||||||
|
if c.ID == st.focusedID {
|
||||||
|
st.renderer = newViewportRenderer(layout)
|
||||||
|
st.repaintNextPTY = c.ID
|
||||||
|
st.repaintNextPTYBudget = 2
|
||||||
|
}
|
||||||
|
st.mu.Unlock()
|
||||||
|
st.repaintFocusedWithChrome()
|
||||||
if err := st.sess.Restart(childID, syscall.SIGTERM, layout.childCols(), layout.childRows()); err != nil {
|
if err := st.sess.Restart(childID, syscall.SIGTERM, layout.childCols(), layout.childRows()); err != nil {
|
||||||
st.flashError(fmt.Sprintf("restart %s: %v", c.DisplayName(), err))
|
st.flashError(fmt.Sprintf("restart %s: %v", c.DisplayName(), err))
|
||||||
|
st.drawTabBar()
|
||||||
|
st.drawSidebar()
|
||||||
|
st.drawStatusLine()
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
st.repaintFocused()
|
st.repaintFocused()
|
||||||
@@ -2261,28 +2465,18 @@ func (st *uiState) handleProcRestart(childID string) {
|
|||||||
st.drawStatusLine()
|
st.drawStatusLine()
|
||||||
}
|
}
|
||||||
|
|
||||||
// flashError surfaces a spawn/etc. failure in the status line until the
|
// flashError surfaces a spawn/etc. failure as an error toast over the
|
||||||
// next attention update overwrites it. stderr is hidden under the alt
|
// focused pane. stderr is hidden under the alt screen so we can't rely
|
||||||
// screen so we can't rely on Fprintln(os.Stderr).
|
// on Fprintln(os.Stderr).
|
||||||
func (st *uiState) flashError(msg string) {
|
func (st *uiState) flashError(msg string) {
|
||||||
st.mu.Lock()
|
st.notifyToast(toastError, msg)
|
||||||
st.attentionText = msg
|
|
||||||
st.attentionAt = "" // shows on every focus until cleared
|
|
||||||
st.mu.Unlock()
|
|
||||||
st.renderEmptyState()
|
|
||||||
st.drawTabBar()
|
|
||||||
st.drawSidebar()
|
|
||||||
st.drawStatusLine()
|
|
||||||
}
|
}
|
||||||
|
|
||||||
// flashTransient is the softer cousin of flashError used for
|
// flashTransient is the softer cousin of flashError used for
|
||||||
// trust-prompt resolutions. Same status-line surface; the prefix differs.
|
// trust-prompt resolutions and other ack-style notices. Same
|
||||||
|
// stackable surface, info styling.
|
||||||
func (st *uiState) flashTransient(msg string) {
|
func (st *uiState) flashTransient(msg string) {
|
||||||
st.mu.Lock()
|
st.notifyToast(toastInfo, msg)
|
||||||
st.attentionText = msg
|
|
||||||
st.attentionAt = ""
|
|
||||||
st.mu.Unlock()
|
|
||||||
st.drawStatusLine()
|
|
||||||
}
|
}
|
||||||
|
|
||||||
// repaintFocused redraws the current focused child's screen snapshot.
|
// repaintFocused redraws the current focused child's screen snapshot.
|
||||||
@@ -2326,8 +2520,9 @@ func (st *uiState) repaintFocused() {
|
|||||||
}
|
}
|
||||||
st.mu.Unlock()
|
st.mu.Unlock()
|
||||||
st.outMu.Lock()
|
st.outMu.Lock()
|
||||||
defer st.outMu.Unlock()
|
|
||||||
_, _ = os.Stdout.Write(out)
|
_, _ = os.Stdout.Write(out)
|
||||||
|
st.outMu.Unlock()
|
||||||
|
st.renderToasts()
|
||||||
}
|
}
|
||||||
|
|
||||||
// repaintFocusedPad paints the focused scratchpad's content into the
|
// repaintFocusedPad paints the focused scratchpad's content into the
|
||||||
@@ -2351,8 +2546,9 @@ func (st *uiState) repaintFocusedPad() {
|
|||||||
return
|
return
|
||||||
}
|
}
|
||||||
st.outMu.Lock()
|
st.outMu.Lock()
|
||||||
defer st.outMu.Unlock()
|
|
||||||
_, _ = os.Stdout.Write(out)
|
_, _ = os.Stdout.Write(out)
|
||||||
|
st.outMu.Unlock()
|
||||||
|
st.renderToasts()
|
||||||
}
|
}
|
||||||
|
|
||||||
// renderPadView builds the bytes that paint a scratchpad's content
|
// renderPadView builds the bytes that paint a scratchpad's content
|
||||||
@@ -2386,6 +2582,7 @@ func (st *uiState) renderPadView(name, content string, layout terminalLayout) []
|
|||||||
st.padOffset = 0
|
st.padOffset = 0
|
||||||
}
|
}
|
||||||
offset := st.padOffset
|
offset := st.padOffset
|
||||||
|
st.view.PadOffset = offset
|
||||||
st.mu.Unlock()
|
st.mu.Unlock()
|
||||||
|
|
||||||
var b strings.Builder
|
var b strings.Builder
|
||||||
@@ -2443,6 +2640,7 @@ func (st *uiState) exitPadView() {
|
|||||||
return
|
return
|
||||||
}
|
}
|
||||||
st.focusedPad = ""
|
st.focusedPad = ""
|
||||||
|
st.view.FocusedPad = ""
|
||||||
st.focusedName = ""
|
st.focusedName = ""
|
||||||
st.mu.Unlock()
|
st.mu.Unlock()
|
||||||
st.clearViewportArea()
|
st.clearViewportArea()
|
||||||
@@ -2469,6 +2667,7 @@ func (st *uiState) padScroll(delta int) {
|
|||||||
if st.padOffset < 0 {
|
if st.padOffset < 0 {
|
||||||
st.padOffset = 0
|
st.padOffset = 0
|
||||||
}
|
}
|
||||||
|
st.view.PadOffset = st.padOffset
|
||||||
st.mu.Unlock()
|
st.mu.Unlock()
|
||||||
st.repaintFocusedPad()
|
st.repaintFocusedPad()
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -26,6 +26,11 @@ import (
|
|||||||
// false positives (timestamps, exit codes, etc.).
|
// false positives (timestamps, exit codes, etc.).
|
||||||
var portRegex = regexp.MustCompile(`https?://[^\s:/]+:(\d{2,5})(?:/[^\s]*)?`)
|
var portRegex = regexp.MustCompile(`https?://[^\s:/]+:(\d{2,5})(?:/[^\s]*)?`)
|
||||||
|
|
||||||
|
const (
|
||||||
|
agentInterPieceDelay = 15 * time.Millisecond
|
||||||
|
agentSubmitSettleDelay = 100 * time.Millisecond
|
||||||
|
)
|
||||||
|
|
||||||
type ChildStatus string
|
type ChildStatus string
|
||||||
|
|
||||||
const (
|
const (
|
||||||
@@ -223,7 +228,7 @@ func (c *Child) startPTY(cols, rows uint16) (uint64, error) {
|
|||||||
}
|
}
|
||||||
starting := StatusStarting
|
starting := StatusStarting
|
||||||
c.status.Store(&starting)
|
c.status.Store(&starting)
|
||||||
p, err := pkgpty.Start(c.Argv, c.Env, cols, rows)
|
p, err := pkgpty.Start(c.Argv, c.Env, c.WorkDir, cols, rows)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
em.Close()
|
em.Close()
|
||||||
errored := StatusErrored
|
errored := StatusErrored
|
||||||
@@ -625,25 +630,25 @@ func (c *Child) InjectAsOrchestrator(b []byte) error {
|
|||||||
}
|
}
|
||||||
|
|
||||||
// writeInput is the shared PTY write path used by both injection
|
// writeInput is the shared PTY write path used by both injection
|
||||||
// flavours. Each Enter byte (CR or LF) is split onto its own write
|
// flavours. Agent panes split each Enter byte (CR or LF) onto its own
|
||||||
// with a brief delay so TUI agents with paste-detection (claude,
|
// write with a brief delay so TUI agents with paste-detection (claude,
|
||||||
// codex, opencode) don't coalesce a trailing CR into the text that
|
// codex, opencode) don't coalesce a trailing CR into the text that
|
||||||
// preceded it. Without the split, `pty.Write([]byte("hello\r"))`
|
// preceded it. Raw terminals and command panes receive the original
|
||||||
// arrives at the agent as one read() and gets treated as multi-line
|
// byte stream in one write; otherwise a multiline paste pays the agent
|
||||||
// pasted content rather than "key Enter".
|
// workaround's delay once per line.
|
||||||
func (c *Child) writeInput(b []byte) error {
|
func (c *Child) writeInput(b []byte) error {
|
||||||
pty := c.PTY()
|
pty := c.PTY()
|
||||||
if pty == nil {
|
if pty == nil {
|
||||||
return errors.New("child has no pty")
|
return errors.New("child has no pty")
|
||||||
}
|
}
|
||||||
pieces := splitOnEnter(b)
|
pieces := inputWritePieces(c.Kind, b)
|
||||||
if len(pieces) <= 1 {
|
if len(pieces) <= 1 {
|
||||||
_, err := pty.Write(b)
|
_, err := pty.Write(b)
|
||||||
return err
|
return err
|
||||||
}
|
}
|
||||||
for i, piece := range pieces {
|
for i, piece := range pieces {
|
||||||
if i > 0 {
|
if delay := pieceWriteDelay(i, len(pieces), piece); delay > 0 {
|
||||||
time.Sleep(15 * time.Millisecond)
|
time.Sleep(delay)
|
||||||
}
|
}
|
||||||
if _, err := pty.Write(piece); err != nil {
|
if _, err := pty.Write(piece); err != nil {
|
||||||
return err
|
return err
|
||||||
@@ -652,6 +657,27 @@ func (c *Child) writeInput(b []byte) error {
|
|||||||
return nil
|
return nil
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func inputWritePieces(kind ChildKind, b []byte) [][]byte {
|
||||||
|
if kind != KindAgent {
|
||||||
|
return [][]byte{b}
|
||||||
|
}
|
||||||
|
return splitOnEnter(b)
|
||||||
|
}
|
||||||
|
|
||||||
|
func pieceWriteDelay(index, total int, piece []byte) time.Duration {
|
||||||
|
if index == 0 {
|
||||||
|
return 0
|
||||||
|
}
|
||||||
|
if index == total-1 && isLoneEnter(piece) {
|
||||||
|
return agentSubmitSettleDelay
|
||||||
|
}
|
||||||
|
return agentInterPieceDelay
|
||||||
|
}
|
||||||
|
|
||||||
|
func isLoneEnter(piece []byte) bool {
|
||||||
|
return len(piece) == 1 && (piece[0] == '\r' || piece[0] == '\n')
|
||||||
|
}
|
||||||
|
|
||||||
func mintIdentity() string {
|
func mintIdentity() string {
|
||||||
var buf [12]byte
|
var buf [12]byte
|
||||||
_, _ = rand.Read(buf[:])
|
_, _ = rand.Read(buf[:])
|
||||||
|
|||||||
90
internal/app/child_input_test.go
Normal file
90
internal/app/child_input_test.go
Normal file
@@ -0,0 +1,90 @@
|
|||||||
|
package app
|
||||||
|
|
||||||
|
import (
|
||||||
|
"bytes"
|
||||||
|
"testing"
|
||||||
|
"time"
|
||||||
|
)
|
||||||
|
|
||||||
|
func TestInputWritePiecesOnlySplitAgentEnters(t *testing.T) {
|
||||||
|
in := []byte("alpha\nbeta\rgamma")
|
||||||
|
for _, kind := range []ChildKind{KindTerminal, KindCommand} {
|
||||||
|
t.Run(string(kind), func(t *testing.T) {
|
||||||
|
got := inputWritePieces(kind, in)
|
||||||
|
if len(got) != 1 || !bytes.Equal(got[0], in) {
|
||||||
|
t.Fatalf("inputWritePieces(%s) = %#v, want one original chunk", kind, got)
|
||||||
|
}
|
||||||
|
})
|
||||||
|
}
|
||||||
|
|
||||||
|
got := inputWritePieces(KindAgent, in)
|
||||||
|
if len(got) != 5 {
|
||||||
|
t.Fatalf("agent pieces len = %d, want 5 (%#v)", len(got), got)
|
||||||
|
}
|
||||||
|
want := [][]byte{[]byte("alpha"), []byte("\n"), []byte("beta"), []byte("\r"), []byte("gamma")}
|
||||||
|
for i := range want {
|
||||||
|
if !bytes.Equal(got[i], want[i]) {
|
||||||
|
t.Fatalf("agent piece %d = %q, want %q", i, got[i], want[i])
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestPieceWriteDelay(t *testing.T) {
|
||||||
|
cases := []struct {
|
||||||
|
name string
|
||||||
|
index int
|
||||||
|
total int
|
||||||
|
piece []byte
|
||||||
|
want time.Duration
|
||||||
|
}{
|
||||||
|
{
|
||||||
|
name: "first piece",
|
||||||
|
index: 0,
|
||||||
|
total: 3,
|
||||||
|
piece: []byte("body"),
|
||||||
|
want: 0,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "middle body piece",
|
||||||
|
index: 1,
|
||||||
|
total: 3,
|
||||||
|
piece: []byte("body"),
|
||||||
|
want: agentInterPieceDelay,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "final carriage return submit",
|
||||||
|
index: 1,
|
||||||
|
total: 2,
|
||||||
|
piece: []byte("\r"),
|
||||||
|
want: agentSubmitSettleDelay,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "final newline submit",
|
||||||
|
index: 1,
|
||||||
|
total: 2,
|
||||||
|
piece: []byte("\n"),
|
||||||
|
want: agentSubmitSettleDelay,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "final non-enter piece",
|
||||||
|
index: 2,
|
||||||
|
total: 3,
|
||||||
|
piece: []byte("tail"),
|
||||||
|
want: agentInterPieceDelay,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "standalone enter fast path",
|
||||||
|
index: 0,
|
||||||
|
total: 1,
|
||||||
|
piece: []byte("\r"),
|
||||||
|
want: 0,
|
||||||
|
},
|
||||||
|
}
|
||||||
|
for _, tc := range cases {
|
||||||
|
t.Run(tc.name, func(t *testing.T) {
|
||||||
|
if got := pieceWriteDelay(tc.index, tc.total, tc.piece); got != tc.want {
|
||||||
|
t.Fatalf("pieceWriteDelay(%d, %d, %q) = %s, want %s", tc.index, tc.total, tc.piece, got, tc.want)
|
||||||
|
}
|
||||||
|
})
|
||||||
|
}
|
||||||
|
}
|
||||||
78
internal/app/chrome_model.go
Normal file
78
internal/app/chrome_model.go
Normal file
@@ -0,0 +1,78 @@
|
|||||||
|
package app
|
||||||
|
|
||||||
|
import "github.com/hjbdev/patterm/internal/scratchpad"
|
||||||
|
|
||||||
|
// chromeModel is the semantic host chrome state. Renderers continue to own
|
||||||
|
// ANSI output; this model is the serializable shape a client can draw locally.
|
||||||
|
type chromeModel struct {
|
||||||
|
ProjectKey string `json:"project_key"`
|
||||||
|
FocusedID string `json:"focused_id,omitempty"`
|
||||||
|
FocusedPad string `json:"focused_pad,omitempty"`
|
||||||
|
ActiveAgentID string `json:"active_agent_id,omitempty"`
|
||||||
|
Tabs []childModel `json:"tabs"`
|
||||||
|
Processes []childModel `json:"processes"`
|
||||||
|
AgentTree []childModel `json:"agent_tree"`
|
||||||
|
Sidebar []navEntryModel `json:"sidebar"`
|
||||||
|
Scratchpads []scratchpadModel `json:"scratchpads"`
|
||||||
|
}
|
||||||
|
|
||||||
|
type childModel struct {
|
||||||
|
ID string `json:"id"`
|
||||||
|
Name string `json:"name"`
|
||||||
|
Kind string `json:"kind"`
|
||||||
|
ParentID string `json:"parent_id,omitempty"`
|
||||||
|
Status string `json:"status"`
|
||||||
|
Owner string `json:"owner"`
|
||||||
|
}
|
||||||
|
|
||||||
|
type navEntryModel struct {
|
||||||
|
ChildID string `json:"child_id,omitempty"`
|
||||||
|
Pad string `json:"pad,omitempty"`
|
||||||
|
}
|
||||||
|
|
||||||
|
type scratchpadModel struct {
|
||||||
|
Name string `json:"name"`
|
||||||
|
}
|
||||||
|
|
||||||
|
func buildChromeModel(projectKey string, view ClientView, children []*Child, pads []scratchpad.Entry) chromeModel {
|
||||||
|
active := view.ActiveAgentID
|
||||||
|
if active == "" {
|
||||||
|
active = activeRootID(children, view.FocusedID)
|
||||||
|
}
|
||||||
|
model := chromeModel{
|
||||||
|
ProjectKey: projectKey,
|
||||||
|
FocusedID: view.FocusedID,
|
||||||
|
FocusedPad: view.FocusedPad,
|
||||||
|
ActiveAgentID: active,
|
||||||
|
}
|
||||||
|
for _, c := range runningTopLevels(children) {
|
||||||
|
model.Tabs = append(model.Tabs, serializeChildModel(c))
|
||||||
|
}
|
||||||
|
for _, c := range processList(children) {
|
||||||
|
model.Processes = append(model.Processes, serializeChildModel(c))
|
||||||
|
}
|
||||||
|
for _, c := range visibleAgentTree(children, active) {
|
||||||
|
model.AgentTree = append(model.AgentTree, serializeChildModel(c))
|
||||||
|
}
|
||||||
|
for _, n := range sidebarNav(children, active, pads) {
|
||||||
|
model.Sidebar = append(model.Sidebar, navEntryModel{ChildID: n.childID, Pad: n.pad})
|
||||||
|
}
|
||||||
|
for _, p := range pads {
|
||||||
|
model.Scratchpads = append(model.Scratchpads, scratchpadModel{Name: p.Name})
|
||||||
|
}
|
||||||
|
return model
|
||||||
|
}
|
||||||
|
|
||||||
|
func serializeChildModel(c *Child) childModel {
|
||||||
|
if c == nil {
|
||||||
|
return childModel{}
|
||||||
|
}
|
||||||
|
return childModel{
|
||||||
|
ID: c.ID,
|
||||||
|
Name: c.DisplayName(),
|
||||||
|
Kind: string(c.Kind),
|
||||||
|
ParentID: c.ParentID,
|
||||||
|
Status: string(c.Status()),
|
||||||
|
Owner: string(c.Owner()),
|
||||||
|
}
|
||||||
|
}
|
||||||
24
internal/app/chrome_model_test.go
Normal file
24
internal/app/chrome_model_test.go
Normal file
@@ -0,0 +1,24 @@
|
|||||||
|
package app
|
||||||
|
|
||||||
|
import "testing"
|
||||||
|
|
||||||
|
func TestBuildChromeModelSeparatesProcessesTabsAndSidebar(t *testing.T) {
|
||||||
|
running := StatusRunning
|
||||||
|
proc := testProcess("p1", "server", running)
|
||||||
|
agent := testAgent("a1", "codex", "", running)
|
||||||
|
sub := testAgent("a2", "worker", "a1", running)
|
||||||
|
|
||||||
|
model := buildChromeModel("project", ClientView{FocusedID: "p1", ActiveAgentID: "a1"}, []*Child{proc, agent, sub}, nil)
|
||||||
|
if len(model.Tabs) != 1 || model.Tabs[0].ID != "a1" {
|
||||||
|
t.Fatalf("tabs = %#v, want only top-level agent", model.Tabs)
|
||||||
|
}
|
||||||
|
if len(model.Processes) != 1 || model.Processes[0].ID != "p1" {
|
||||||
|
t.Fatalf("processes = %#v, want process section", model.Processes)
|
||||||
|
}
|
||||||
|
if len(model.AgentTree) != 2 || model.AgentTree[0].ID != "a1" || model.AgentTree[1].ID != "a2" {
|
||||||
|
t.Fatalf("agent tree = %#v", model.AgentTree)
|
||||||
|
}
|
||||||
|
if len(model.Sidebar) != 3 || model.Sidebar[0].ChildID != "p1" || model.Sidebar[1].ChildID != "a1" {
|
||||||
|
t.Fatalf("sidebar = %#v", model.Sidebar)
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -50,8 +50,14 @@ func (s *Session) classifyOne(c *Child) {
|
|||||||
idleMS := c.IdleMS()
|
idleMS := c.IdleMS()
|
||||||
titleIdleMS := c.TitleIdleMS()
|
titleIdleMS := c.TitleIdleMS()
|
||||||
title := c.Title()
|
title := c.Title()
|
||||||
tail := c.tailBytes(classifierTailBytes)
|
tail := stripANSIBytes(nil, c.tailBytes(classifierTailBytes))
|
||||||
state, reason := classify(c.idleDetection, exited, exitNonZero, idleMS, titleIdleMS, title, tail)
|
var screen []byte
|
||||||
|
if em := c.Emulator(); em != nil {
|
||||||
|
if txt, err := em.ScreenText(); err == nil {
|
||||||
|
screen = []byte(txt)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
state, reason := classify(c.idleDetection, exited, exitNonZero, idleMS, titleIdleMS, title, tail, screen)
|
||||||
if c.setIdleState(state, reason) {
|
if c.setIdleState(state, reason) {
|
||||||
s.emitStateChanged(c.ID, state)
|
s.emitStateChanged(c.ID, state)
|
||||||
}
|
}
|
||||||
|
|||||||
122
internal/app/client_subscriber.go
Normal file
122
internal/app/client_subscriber.go
Normal file
@@ -0,0 +1,122 @@
|
|||||||
|
package app
|
||||||
|
|
||||||
|
import (
|
||||||
|
"encoding/json"
|
||||||
|
"sync"
|
||||||
|
|
||||||
|
"github.com/hjbdev/patterm/internal/protocol"
|
||||||
|
)
|
||||||
|
|
||||||
|
const defaultClientSubscriberQueue = 256
|
||||||
|
|
||||||
|
// clientSubscriber is the daemon-to-client event bridge. Unlike daemon-local
|
||||||
|
// listeners such as timers, debug capture, and waiters, it never blocks the PTY
|
||||||
|
// pump: PTY chunks are copied before enqueue, and overflow marks the pane as
|
||||||
|
// needing a fresh snapshot.
|
||||||
|
type clientSubscriber struct {
|
||||||
|
projectKey string
|
||||||
|
frames chan protocol.Frame
|
||||||
|
|
||||||
|
mu sync.Mutex
|
||||||
|
snapshotRequired map[string]bool
|
||||||
|
lifecycleDirty bool
|
||||||
|
}
|
||||||
|
|
||||||
|
func newClientSubscriber(projectKey string, size int) *clientSubscriber {
|
||||||
|
if size <= 0 {
|
||||||
|
size = defaultClientSubscriberQueue
|
||||||
|
}
|
||||||
|
return &clientSubscriber{
|
||||||
|
projectKey: projectKey,
|
||||||
|
frames: make(chan protocol.Frame, size),
|
||||||
|
snapshotRequired: make(map[string]bool),
|
||||||
|
lifecycleDirty: false,
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func (s *clientSubscriber) Recv() (protocol.Frame, bool) {
|
||||||
|
f, ok := <-s.frames
|
||||||
|
return f, ok
|
||||||
|
}
|
||||||
|
|
||||||
|
func (s *clientSubscriber) SnapshotRequired(childID string) bool {
|
||||||
|
s.mu.Lock()
|
||||||
|
defer s.mu.Unlock()
|
||||||
|
return s.snapshotRequired[childID]
|
||||||
|
}
|
||||||
|
|
||||||
|
func (s *clientSubscriber) OnChildSpawned(c *Child) {
|
||||||
|
s.sendLifecycle(protocol.LifecycleSpawned, c, "")
|
||||||
|
}
|
||||||
|
|
||||||
|
func (s *clientSubscriber) OnChildExited(c *Child) {
|
||||||
|
s.sendLifecycle(protocol.LifecycleExited, c, "")
|
||||||
|
}
|
||||||
|
|
||||||
|
func (s *clientSubscriber) OnChildClosed(id string) {
|
||||||
|
s.sendFrame(protocol.Frame{Type: protocol.FrameLifecycle, Payload: mustJSON(protocol.Lifecycle{
|
||||||
|
Kind: protocol.LifecycleClosed,
|
||||||
|
ProjectKey: s.projectKey,
|
||||||
|
ChildID: id,
|
||||||
|
})})
|
||||||
|
}
|
||||||
|
|
||||||
|
func (s *clientSubscriber) OnChildStateChanged(id string, state IdleState) {
|
||||||
|
s.sendFrame(protocol.Frame{Type: protocol.FrameLifecycle, Payload: mustJSON(protocol.Lifecycle{
|
||||||
|
Kind: protocol.LifecycleStateChanged,
|
||||||
|
ProjectKey: s.projectKey,
|
||||||
|
ChildID: id,
|
||||||
|
State: string(state),
|
||||||
|
})})
|
||||||
|
}
|
||||||
|
|
||||||
|
func (s *clientSubscriber) OnPTYOut(childID string, chunk []byte) {
|
||||||
|
cp := append([]byte(nil), chunk...)
|
||||||
|
f, err := protocol.NewFrame(protocol.FramePaneChunk, protocol.PaneChunk{PaneID: childID, Bytes: cp})
|
||||||
|
if err != nil {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
select {
|
||||||
|
case s.frames <- f:
|
||||||
|
default:
|
||||||
|
s.mu.Lock()
|
||||||
|
s.snapshotRequired[childID] = true
|
||||||
|
s.mu.Unlock()
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func (s *clientSubscriber) sendLifecycle(kind protocol.LifecycleKind, c *Child, state string) {
|
||||||
|
var child json.RawMessage
|
||||||
|
if c != nil {
|
||||||
|
child = mustJSON(serializeChildModel(c))
|
||||||
|
}
|
||||||
|
childID := ""
|
||||||
|
if c != nil {
|
||||||
|
childID = c.ID
|
||||||
|
}
|
||||||
|
s.sendFrame(protocol.Frame{Type: protocol.FrameLifecycle, Payload: mustJSON(protocol.Lifecycle{
|
||||||
|
Kind: kind,
|
||||||
|
ProjectKey: s.projectKey,
|
||||||
|
ChildID: childID,
|
||||||
|
Child: child,
|
||||||
|
State: state,
|
||||||
|
})})
|
||||||
|
}
|
||||||
|
|
||||||
|
func (s *clientSubscriber) sendFrame(f protocol.Frame) {
|
||||||
|
select {
|
||||||
|
case s.frames <- f:
|
||||||
|
default:
|
||||||
|
s.mu.Lock()
|
||||||
|
s.lifecycleDirty = true
|
||||||
|
s.mu.Unlock()
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func mustJSON(v any) json.RawMessage {
|
||||||
|
b, err := json.Marshal(v)
|
||||||
|
if err != nil {
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
return b
|
||||||
|
}
|
||||||
32
internal/app/client_subscriber_test.go
Normal file
32
internal/app/client_subscriber_test.go
Normal file
@@ -0,0 +1,32 @@
|
|||||||
|
package app
|
||||||
|
|
||||||
|
import (
|
||||||
|
"testing"
|
||||||
|
|
||||||
|
"github.com/hjbdev/patterm/internal/protocol"
|
||||||
|
)
|
||||||
|
|
||||||
|
func TestClientSubscriberCopiesChunksAndMarksSnapshotOnOverflow(t *testing.T) {
|
||||||
|
sub := newClientSubscriber("project", 1)
|
||||||
|
chunk := []byte("first")
|
||||||
|
sub.OnPTYOut("p_123456", chunk)
|
||||||
|
chunk[0] = 'X'
|
||||||
|
|
||||||
|
f, ok := sub.Recv()
|
||||||
|
if !ok {
|
||||||
|
t.Fatalf("Recv closed")
|
||||||
|
}
|
||||||
|
payload, err := protocol.Decode[protocol.PaneChunk](f)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("Decode: %v", err)
|
||||||
|
}
|
||||||
|
if string(payload.Bytes) != "first" {
|
||||||
|
t.Fatalf("payload retained pump buffer: %q", string(payload.Bytes))
|
||||||
|
}
|
||||||
|
|
||||||
|
sub.OnPTYOut("p_123456", []byte("queued"))
|
||||||
|
sub.OnPTYOut("p_123456", []byte("dropped"))
|
||||||
|
if !sub.SnapshotRequired("p_123456") {
|
||||||
|
t.Fatalf("overflow did not mark pane snapshot required")
|
||||||
|
}
|
||||||
|
}
|
||||||
39
internal/app/client_view.go
Normal file
39
internal/app/client_view.go
Normal file
@@ -0,0 +1,39 @@
|
|||||||
|
package app
|
||||||
|
|
||||||
|
// ClientView is the per-client UI cursor over daemon-owned project/process
|
||||||
|
// state. In loopback mode there is one view, owned by uiState; future network
|
||||||
|
// clients will each get their own copy.
|
||||||
|
type ClientView struct {
|
||||||
|
ID string
|
||||||
|
ProjectKey string
|
||||||
|
FocusedID string
|
||||||
|
FocusedPad string
|
||||||
|
ActiveAgentID string
|
||||||
|
PadOffset int
|
||||||
|
PadOffsetName string
|
||||||
|
Cols uint16
|
||||||
|
Rows uint16
|
||||||
|
}
|
||||||
|
|
||||||
|
func (v *ClientView) FocusChild(id string) {
|
||||||
|
v.FocusedID = id
|
||||||
|
v.FocusedPad = ""
|
||||||
|
}
|
||||||
|
|
||||||
|
func (v *ClientView) FocusPad(name string) {
|
||||||
|
v.FocusedID = ""
|
||||||
|
v.FocusedPad = name
|
||||||
|
if v.PadOffsetName != name {
|
||||||
|
v.PadOffset = 0
|
||||||
|
v.PadOffsetName = name
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func (v *ClientView) ClearPadFocus() {
|
||||||
|
v.FocusedPad = ""
|
||||||
|
}
|
||||||
|
|
||||||
|
func (v *ClientView) Resize(cols, rows uint16) {
|
||||||
|
v.Cols = cols
|
||||||
|
v.Rows = rows
|
||||||
|
}
|
||||||
29
internal/app/daemon_core.go
Normal file
29
internal/app/daemon_core.go
Normal file
@@ -0,0 +1,29 @@
|
|||||||
|
package app
|
||||||
|
|
||||||
|
import (
|
||||||
|
"github.com/hjbdev/patterm/internal/mcp"
|
||||||
|
"github.com/hjbdev/patterm/internal/persist"
|
||||||
|
"github.com/hjbdev/patterm/internal/preset"
|
||||||
|
"github.com/hjbdev/patterm/internal/scratchpad"
|
||||||
|
"github.com/hjbdev/patterm/internal/trust"
|
||||||
|
)
|
||||||
|
|
||||||
|
// headlessCore is the daemon-owned half of today's single-process app. It is
|
||||||
|
// intentionally small for the foundation phase: it groups process/project
|
||||||
|
// state while the existing loopback client still renders in-process.
|
||||||
|
type headlessCore struct {
|
||||||
|
projectDir string
|
||||||
|
projectKey string
|
||||||
|
|
||||||
|
presets preset.Set
|
||||||
|
settings settings
|
||||||
|
|
||||||
|
pads *scratchpad.Store
|
||||||
|
trustStore *trust.Store
|
||||||
|
persistStore *persist.Store
|
||||||
|
|
||||||
|
mcpSrv *mcp.Server
|
||||||
|
sess *Session
|
||||||
|
launcher *Launcher
|
||||||
|
host *toolHost
|
||||||
|
}
|
||||||
@@ -111,6 +111,13 @@ func (d *debugCapture) OnChildStateChanged(id string, state IdleState) {
|
|||||||
})
|
})
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func (d *debugCapture) OnChildClosed(id string) {
|
||||||
|
d.writeEvent("child_closed", map[string]any{
|
||||||
|
"time": time.Now().Format(time.RFC3339Nano),
|
||||||
|
"id": id,
|
||||||
|
})
|
||||||
|
}
|
||||||
|
|
||||||
func (d *debugCapture) OnPTYOut(childID string, chunk []byte) {
|
func (d *debugCapture) OnPTYOut(childID string, chunk []byte) {
|
||||||
if len(chunk) == 0 {
|
if len(chunk) == 0 {
|
||||||
return
|
return
|
||||||
|
|||||||
@@ -7,6 +7,7 @@ import (
|
|||||||
"sync"
|
"sync"
|
||||||
"syscall"
|
"syscall"
|
||||||
"time"
|
"time"
|
||||||
|
"unicode"
|
||||||
|
|
||||||
"github.com/hjbdev/patterm/internal/mcp"
|
"github.com/hjbdev/patterm/internal/mcp"
|
||||||
"github.com/hjbdev/patterm/internal/preset"
|
"github.com/hjbdev/patterm/internal/preset"
|
||||||
@@ -86,10 +87,10 @@ func newToolHost(sess *Session, pads *scratchpad.Store, launcher *Launcher, pres
|
|||||||
return h
|
return h
|
||||||
}
|
}
|
||||||
|
|
||||||
// timerListenerAdapter forwards OnChildStateChanged into the timer
|
// timerListenerAdapter forwards OnChildStateChanged and OnChildClosed
|
||||||
// manager and ignores the other ChildEventListener methods. The
|
// into the timer manager and ignores the other ChildEventListener
|
||||||
// session's listener API is by-interface, so we wrap the manager
|
// methods. The session's listener API is by-interface, so we wrap
|
||||||
// rather than make it implement the full surface.
|
// the manager rather than make it implement the full surface.
|
||||||
type timerListenerAdapter struct{ m *timerManager }
|
type timerListenerAdapter struct{ m *timerManager }
|
||||||
|
|
||||||
func (a timerListenerAdapter) OnChildSpawned(*Child) {}
|
func (a timerListenerAdapter) OnChildSpawned(*Child) {}
|
||||||
@@ -98,6 +99,9 @@ func (a timerListenerAdapter) OnPTYOut(string, []byte) {}
|
|||||||
func (a timerListenerAdapter) OnChildStateChanged(id string, st IdleState) {
|
func (a timerListenerAdapter) OnChildStateChanged(id string, st IdleState) {
|
||||||
a.m.onChildStateChanged(id, st)
|
a.m.onChildStateChanged(id, st)
|
||||||
}
|
}
|
||||||
|
func (a timerListenerAdapter) OnChildClosed(id string) {
|
||||||
|
a.m.onChildClosed(id)
|
||||||
|
}
|
||||||
|
|
||||||
func (h *toolHost) SetSize(cols, rows uint16) {
|
func (h *toolHost) SetSize(cols, rows uint16) {
|
||||||
h.sizeMu.Lock()
|
h.sizeMu.Lock()
|
||||||
@@ -395,7 +399,7 @@ func (h *toolHost) GetProcessOutput(callerID, processID, mode string, sinceOffse
|
|||||||
if c.Kind == KindAgent {
|
if c.Kind == KindAgent {
|
||||||
txt = applyChromeTrim(txt, h.chromeHintsFor(c.PresetRef))
|
txt = applyChromeTrim(txt, h.chromeHintsFor(c.PresetRef))
|
||||||
}
|
}
|
||||||
out.Content = txt
|
out.Content = normalizeGridText(txt)
|
||||||
return out, nil
|
return out, nil
|
||||||
case "stream":
|
case "stream":
|
||||||
b, end := c.StreamRead(sinceOffset)
|
b, end := c.StreamRead(sinceOffset)
|
||||||
@@ -553,6 +557,7 @@ func (n *chunkNotifier) OnPTYOut(id string, chunk []byte) {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
func (n *chunkNotifier) OnChildStateChanged(string, IdleState) {}
|
func (n *chunkNotifier) OnChildStateChanged(string, IdleState) {}
|
||||||
|
func (n *chunkNotifier) OnChildClosed(string) {}
|
||||||
|
|
||||||
func (h *toolHost) GetProcessPorts(callerID, processID string) ([]mcp.PortSighting, error) {
|
func (h *toolHost) GetProcessPorts(callerID, processID string) ([]mcp.PortSighting, error) {
|
||||||
c := h.sess.FindChild(processID)
|
c := h.sess.FindChild(processID)
|
||||||
@@ -828,6 +833,14 @@ func (h *toolHost) ScratchpadAppend(name, content string) error {
|
|||||||
return err
|
return err
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func (h *toolHost) ScratchpadDelete(name string) error {
|
||||||
|
err := h.pads.Delete(name)
|
||||||
|
if err == nil && h.scratch != nil {
|
||||||
|
h.scratch.scratchpadsChanged()
|
||||||
|
}
|
||||||
|
return err
|
||||||
|
}
|
||||||
|
|
||||||
func (h *toolHost) WhoAmI(callerID string) mcp.WhoAmI {
|
func (h *toolHost) WhoAmI(callerID string) mcp.WhoAmI {
|
||||||
w := mcp.WhoAmI{
|
w := mcp.WhoAmI{
|
||||||
ProcessID: callerID,
|
ProcessID: callerID,
|
||||||
@@ -1006,6 +1019,30 @@ func stripANSI(s string) string {
|
|||||||
return ansiRegexp.ReplaceAllString(s, "")
|
return ansiRegexp.ReplaceAllString(s, "")
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func normalizeGridText(s string) string {
|
||||||
|
s = strings.ReplaceAll(s, "\r\n", "\n")
|
||||||
|
s = strings.ReplaceAll(s, "\r", "\n")
|
||||||
|
|
||||||
|
lines := strings.Split(s, "\n")
|
||||||
|
out := make([]string, 0, len(lines))
|
||||||
|
pendingBlank := false
|
||||||
|
for _, line := range lines {
|
||||||
|
line = strings.TrimRightFunc(line, unicode.IsSpace)
|
||||||
|
if line == "" {
|
||||||
|
if len(out) > 0 {
|
||||||
|
pendingBlank = true
|
||||||
|
}
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
if pendingBlank {
|
||||||
|
out = append(out, "")
|
||||||
|
pendingBlank = false
|
||||||
|
}
|
||||||
|
out = append(out, line)
|
||||||
|
}
|
||||||
|
return strings.Join(out, "\n")
|
||||||
|
}
|
||||||
|
|
||||||
// stripANSIBytes is the byte-slice form of stripANSI. Skips the
|
// stripANSIBytes is the byte-slice form of stripANSI. Skips the
|
||||||
// string conversion and the regex DFA — useful when the caller will
|
// string conversion and the regex DFA — useful when the caller will
|
||||||
// itself walk the result line-by-line (SearchOutput) or feed it to a
|
// itself walk the result line-by-line (SearchOutput) or feed it to a
|
||||||
@@ -1087,7 +1124,7 @@ func availableToolsForRole(role mcp.CallerRole) []string {
|
|||||||
"send_input", "send_message", "request_human_attention",
|
"send_input", "send_message", "request_human_attention",
|
||||||
"timer_wait", "timer_set", "timer_fire_when_idle_any", "timer_fire_when_idle_all",
|
"timer_wait", "timer_set", "timer_fire_when_idle_any", "timer_fire_when_idle_all",
|
||||||
"timer_cancel", "timer_pause", "timer_resume", "timer_list",
|
"timer_cancel", "timer_pause", "timer_resume", "timer_list",
|
||||||
"scratchpad_list", "scratchpad_read", "scratchpad_write", "scratchpad_append",
|
"scratchpad_list", "scratchpad_read", "scratchpad_write", "scratchpad_append", "scratchpad_delete",
|
||||||
"whoami", "help",
|
"whoami", "help",
|
||||||
}
|
}
|
||||||
if role == mcp.RoleOrchestrator {
|
if role == mcp.RoleOrchestrator {
|
||||||
@@ -1142,8 +1179,8 @@ func helpFor(topic string) mcp.HelpResponse {
|
|||||||
case "scratchpads":
|
case "scratchpads":
|
||||||
return mcp.HelpResponse{
|
return mcp.HelpResponse{
|
||||||
Topic: "scratchpads",
|
Topic: "scratchpads",
|
||||||
Content: "Project-scoped markdown files. Read returns content + revision; pass that back as expected_revision on write to get last-write-wins-with-detection. Append is unconditional.",
|
Content: "Project-scoped markdown files. Read returns content + revision; pass that back as expected_revision on write to get last-write-wins-with-detection. Append is unconditional; delete removes a pad by name.",
|
||||||
RelatedTools: []string{"scratchpad_list", "scratchpad_read", "scratchpad_write", "scratchpad_append"},
|
RelatedTools: []string{"scratchpad_list", "scratchpad_read", "scratchpad_write", "scratchpad_append", "scratchpad_delete"},
|
||||||
}
|
}
|
||||||
case "timers":
|
case "timers":
|
||||||
return mcp.HelpResponse{
|
return mcp.HelpResponse{
|
||||||
|
|||||||
@@ -118,7 +118,8 @@ func compilePatterns(ps []string) []*regexp.Regexp {
|
|||||||
// - titleIdleMS: ms since the last OSC title change (0 if no title yet)
|
// - titleIdleMS: ms since the last OSC title change (0 if no title yet)
|
||||||
// - title: current OSC title
|
// - title: current OSC title
|
||||||
// - tail: recent output bytes for regex matching
|
// - tail: recent output bytes for regex matching
|
||||||
func classify(cfg *resolvedIdleDetection, exited, exitNonZero bool, idleMS, titleIdleMS int64, title string, tail []byte) (IdleState, string) {
|
// - screen: current rendered screen text for persistent prompt matching
|
||||||
|
func classify(cfg *resolvedIdleDetection, exited, exitNonZero bool, idleMS, titleIdleMS int64, title string, tail, screen []byte) (IdleState, string) {
|
||||||
if exited {
|
if exited {
|
||||||
if exitNonZero {
|
if exitNonZero {
|
||||||
return StateError, "process exited non-zero"
|
return StateError, "process exited non-zero"
|
||||||
@@ -128,14 +129,14 @@ func classify(cfg *resolvedIdleDetection, exited, exitNonZero bool, idleMS, titl
|
|||||||
if cfg == nil {
|
if cfg == nil {
|
||||||
cfg = &resolvedIdleDetection{strategy: StrategyOutputActivity, idleThresholdMS: defaultIdleThresholdMS}
|
cfg = &resolvedIdleDetection{strategy: StrategyOutputActivity, idleThresholdMS: defaultIdleThresholdMS}
|
||||||
}
|
}
|
||||||
if len(tail) > 0 {
|
if len(tail) > 0 || len(screen) > 0 {
|
||||||
if matchAny(cfg.errorRegexes, tail) {
|
if matchAny(cfg.errorRegexes, tail, screen) {
|
||||||
return StateError, "error regex matched"
|
return StateError, "error regex matched"
|
||||||
}
|
}
|
||||||
if matchAny(cfg.permissionRegexes, tail) {
|
if matchAny(cfg.permissionRegexes, tail, screen) {
|
||||||
return StatePermission, "permission regex matched"
|
return StatePermission, "permission regex matched"
|
||||||
}
|
}
|
||||||
if matchAny(cfg.thinkingRegexes, tail) {
|
if matchAny(cfg.thinkingRegexes, tail, screen) {
|
||||||
return StateThinking, "thinking regex matched"
|
return StateThinking, "thinking regex matched"
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -172,12 +173,14 @@ func baseStateFromIdleMS(idleMS, threshold int64) (IdleState, string) {
|
|||||||
return StateIdle, "quiet for threshold"
|
return StateIdle, "quiet for threshold"
|
||||||
}
|
}
|
||||||
|
|
||||||
func matchAny(res []*regexp.Regexp, tail []byte) bool {
|
func matchAny(res []*regexp.Regexp, texts ...[]byte) bool {
|
||||||
for _, re := range res {
|
for _, re := range res {
|
||||||
if re.Match(tail) {
|
for _, text := range texts {
|
||||||
|
if len(text) > 0 && re.Match(text) {
|
||||||
return true
|
return true
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
}
|
||||||
return false
|
return false
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -30,7 +30,7 @@ func TestClassifyOutputActivity(t *testing.T) {
|
|||||||
}
|
}
|
||||||
for _, tc := range cases {
|
for _, tc := range cases {
|
||||||
t.Run(tc.name, func(t *testing.T) {
|
t.Run(tc.name, func(t *testing.T) {
|
||||||
got, _ := classify(cfg, false, false, tc.idleMS, 0, "", nil)
|
got, _ := classify(cfg, false, false, tc.idleMS, 0, "", nil, nil)
|
||||||
if got != tc.want {
|
if got != tc.want {
|
||||||
t.Fatalf("got %q want %q", got, tc.want)
|
t.Fatalf("got %q want %q", got, tc.want)
|
||||||
}
|
}
|
||||||
@@ -41,22 +41,37 @@ func TestClassifyOutputActivity(t *testing.T) {
|
|||||||
func TestClassifyTitleStability(t *testing.T) {
|
func TestClassifyTitleStability(t *testing.T) {
|
||||||
cfg := &resolvedIdleDetection{strategy: StrategyOSCTitleStability, idleThresholdMS: 2000}
|
cfg := &resolvedIdleDetection{strategy: StrategyOSCTitleStability, idleThresholdMS: 2000}
|
||||||
// Title change recent → working.
|
// Title change recent → working.
|
||||||
if got, _ := classify(cfg, false, false, 9999, 500, "step 3", nil); got != StateWorking {
|
if got, _ := classify(cfg, false, false, 9999, 500, "step 3", nil, nil); got != StateWorking {
|
||||||
t.Fatalf("recent title change: got %q", got)
|
t.Fatalf("recent title change: got %q", got)
|
||||||
}
|
}
|
||||||
// Title stable past threshold → idle.
|
// Title stable past threshold → idle.
|
||||||
if got, _ := classify(cfg, false, false, 9999, 5000, "step 3", nil); got != StateIdle {
|
if got, _ := classify(cfg, false, false, 9999, 5000, "step 3", nil, nil); got != StateIdle {
|
||||||
t.Fatalf("stable title: got %q", got)
|
t.Fatalf("stable title: got %q", got)
|
||||||
}
|
}
|
||||||
// No title yet: fall back to output activity.
|
// No title yet: fall back to output activity.
|
||||||
if got, _ := classify(cfg, false, false, 100, 0, "", nil); got != StateWorking {
|
if got, _ := classify(cfg, false, false, 100, 0, "", nil, nil); got != StateWorking {
|
||||||
t.Fatalf("no title yet, recent output: got %q", got)
|
t.Fatalf("no title yet, recent output: got %q", got)
|
||||||
}
|
}
|
||||||
if got, _ := classify(cfg, false, false, 5000, 0, "", nil); got != StateIdle {
|
if got, _ := classify(cfg, false, false, 5000, 0, "", nil, nil); got != StateIdle {
|
||||||
t.Fatalf("no title yet, output idle: got %q", got)
|
t.Fatalf("no title yet, output idle: got %q", got)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func TestClassifyTitleStabilityThinkingPatternOverridesIdle(t *testing.T) {
|
||||||
|
cfg := &resolvedIdleDetection{
|
||||||
|
strategy: StrategyOSCTitleStability,
|
||||||
|
idleThresholdMS: 2000,
|
||||||
|
thinkingRegexes: []*regexp.Regexp{mustCompile(t, `(?i)esc to interrupt`)},
|
||||||
|
}
|
||||||
|
screen := []byte("• Working (5s • esc to interrupt)")
|
||||||
|
if got, _ := classify(cfg, false, false, 9999, 5000, "codex", nil, screen); got != StateThinking {
|
||||||
|
t.Fatalf("thinking screen marker: got %q want %q", got, StateThinking)
|
||||||
|
}
|
||||||
|
if got, _ := classify(cfg, false, false, 9999, 5000, "codex", nil, []byte(">_")); got != StateIdle {
|
||||||
|
t.Fatalf("stable title without marker: got %q want %q", got, StateIdle)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
func TestClassifyTitleStatus(t *testing.T) {
|
func TestClassifyTitleStatus(t *testing.T) {
|
||||||
cfg := &resolvedIdleDetection{
|
cfg := &resolvedIdleDetection{
|
||||||
strategy: StrategyOSCTitleStatus,
|
strategy: StrategyOSCTitleStatus,
|
||||||
@@ -67,14 +82,14 @@ func TestClassifyTitleStatus(t *testing.T) {
|
|||||||
"error": StateError,
|
"error": StateError,
|
||||||
},
|
},
|
||||||
}
|
}
|
||||||
if got, _ := classify(cfg, false, false, 9999, 500, "Thinking…", nil); got != StateThinking {
|
if got, _ := classify(cfg, false, false, 9999, 500, "Thinking…", nil, nil); got != StateThinking {
|
||||||
t.Fatalf("thinking title: got %q", got)
|
t.Fatalf("thinking title: got %q", got)
|
||||||
}
|
}
|
||||||
if got, _ := classify(cfg, false, false, 9999, 500, "Waiting for permission", nil); got != StatePermission {
|
if got, _ := classify(cfg, false, false, 9999, 500, "Waiting for permission", nil, nil); got != StatePermission {
|
||||||
t.Fatalf("permission title: got %q", got)
|
t.Fatalf("permission title: got %q", got)
|
||||||
}
|
}
|
||||||
// No match in map → fall back to stability.
|
// No match in map → fall back to stability.
|
||||||
if got, _ := classify(cfg, false, false, 9999, 5000, "ready", nil); got != StateIdle {
|
if got, _ := classify(cfg, false, false, 9999, 5000, "ready", nil, nil); got != StateIdle {
|
||||||
t.Fatalf("unmatched title, stable: got %q", got)
|
t.Fatalf("unmatched title, stable: got %q", got)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -88,25 +103,30 @@ func TestClassifyPromoterRegex(t *testing.T) {
|
|||||||
thinkingRegexes: []*regexp.Regexp{mustCompile(t, `Thinking`)},
|
thinkingRegexes: []*regexp.Regexp{mustCompile(t, `Thinking`)},
|
||||||
}
|
}
|
||||||
// Permission promoter beats idle.
|
// Permission promoter beats idle.
|
||||||
if got, _ := classify(cfg, false, false, 5000, 0, "", []byte("Approve? [y/n]")); got != StatePermission {
|
if got, _ := classify(cfg, false, false, 5000, 0, "", []byte("Approve? [y/n]"), nil); got != StatePermission {
|
||||||
t.Fatalf("permission promoter: got %q", got)
|
t.Fatalf("permission promoter: got %q", got)
|
||||||
}
|
}
|
||||||
// Error trumps permission.
|
// Error trumps permission.
|
||||||
if got, _ := classify(cfg, false, false, 5000, 0, "", []byte("panic: bad\nApprove?")); got != StateError {
|
if got, _ := classify(cfg, false, false, 5000, 0, "", []byte("panic: bad\nApprove?"), nil); got != StateError {
|
||||||
t.Fatalf("error promoter beats permission: got %q", got)
|
t.Fatalf("error promoter beats permission: got %q", got)
|
||||||
}
|
}
|
||||||
// Thinking promoter on idle output.
|
// Thinking promoter on idle output.
|
||||||
if got, _ := classify(cfg, false, false, 5000, 0, "", []byte("Thinking…")); got != StateThinking {
|
if got, _ := classify(cfg, false, false, 5000, 0, "", []byte("Thinking…"), nil); got != StateThinking {
|
||||||
t.Fatalf("thinking promoter: got %q", got)
|
t.Fatalf("thinking promoter: got %q", got)
|
||||||
}
|
}
|
||||||
|
// Rendered-screen prompts still promote even when the raw tail no
|
||||||
|
// longer contains the original prompt bytes.
|
||||||
|
if got, _ := classify(cfg, false, false, 100, 0, "", []byte("Calling patterm..."), []byte("Approve? [y/n]")); got != StatePermission {
|
||||||
|
t.Fatalf("screen permission promoter: got %q", got)
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestClassifyExitTerminal(t *testing.T) {
|
func TestClassifyExitTerminal(t *testing.T) {
|
||||||
cfg := &resolvedIdleDetection{strategy: StrategyOutputActivity, idleThresholdMS: 2000}
|
cfg := &resolvedIdleDetection{strategy: StrategyOutputActivity, idleThresholdMS: 2000}
|
||||||
if got, _ := classify(cfg, true, true, 0, 0, "", nil); got != StateError {
|
if got, _ := classify(cfg, true, true, 0, 0, "", nil, nil); got != StateError {
|
||||||
t.Fatalf("non-zero exit: got %q", got)
|
t.Fatalf("non-zero exit: got %q", got)
|
||||||
}
|
}
|
||||||
if got, _ := classify(cfg, true, false, 0, 0, "", nil); got != StateIdle {
|
if got, _ := classify(cfg, true, false, 0, 0, "", nil, nil); got != StateIdle {
|
||||||
t.Fatalf("clean exit: got %q", got)
|
t.Fatalf("clean exit: got %q", got)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -261,15 +261,11 @@ func (l *Launcher) LaunchTerminal(argv []string, displayName, parentID, workDir
|
|||||||
}
|
}
|
||||||
|
|
||||||
func (l *Launcher) writeMCPConfig(identity string) (string, error) {
|
func (l *Launcher) writeMCPConfig(identity string) (string, error) {
|
||||||
dir, err := preset.ConfigDir()
|
dir, err := mcpRuntimeDir(identity)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return "", err
|
return "", err
|
||||||
}
|
}
|
||||||
dir = filepath.Join(dir, "mcp")
|
path := filepath.Join(dir, "mcp.json")
|
||||||
if err := os.MkdirAll(dir, 0o700); err != nil {
|
|
||||||
return "", err
|
|
||||||
}
|
|
||||||
path := filepath.Join(dir, identity+".json")
|
|
||||||
cfg := map[string]any{
|
cfg := map[string]any{
|
||||||
"mcpServers": map[string]any{
|
"mcpServers": map[string]any{
|
||||||
"patterm": map[string]any{
|
"patterm": map[string]any{
|
||||||
|
|||||||
30
internal/app/launch_test.go
Normal file
30
internal/app/launch_test.go
Normal file
@@ -0,0 +1,30 @@
|
|||||||
|
package app
|
||||||
|
|
||||||
|
import (
|
||||||
|
"os"
|
||||||
|
"path/filepath"
|
||||||
|
"strings"
|
||||||
|
"testing"
|
||||||
|
)
|
||||||
|
|
||||||
|
func TestWriteMCPConfigUsesRuntimeDir(t *testing.T) {
|
||||||
|
runtimeDir := t.TempDir()
|
||||||
|
configHome := filepath.Join(t.TempDir(), "config")
|
||||||
|
t.Setenv("XDG_RUNTIME_DIR", runtimeDir)
|
||||||
|
t.Setenv("XDG_CONFIG_HOME", configHome)
|
||||||
|
|
||||||
|
l := &Launcher{bin: "patterm", mcpSocket: "/tmp/patterm.sock"}
|
||||||
|
path, err := l.writeMCPConfig("abc123")
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("writeMCPConfig: %v", err)
|
||||||
|
}
|
||||||
|
if !strings.HasPrefix(path, filepath.Join(runtimeDir, "patterm", "agents", "abc123")) {
|
||||||
|
t.Fatalf("path = %q, want under runtime dir", path)
|
||||||
|
}
|
||||||
|
if _, err := os.Stat(path); err != nil {
|
||||||
|
t.Fatalf("config file stat: %v", err)
|
||||||
|
}
|
||||||
|
if _, err := os.Stat(filepath.Join(configHome, "patterm")); !os.IsNotExist(err) {
|
||||||
|
t.Fatalf("writeMCPConfig created XDG config dir or unexpected stat error: %v", err)
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -54,14 +54,6 @@ const (
|
|||||||
groupQuit
|
groupQuit
|
||||||
)
|
)
|
||||||
|
|
||||||
var groupLabels = map[int]string{
|
|
||||||
groupFocused: "Focused",
|
|
||||||
groupOpen: "Open",
|
|
||||||
groupSpawn: "Spawn",
|
|
||||||
groupSettings: "Settings",
|
|
||||||
groupQuit: "Quit",
|
|
||||||
}
|
|
||||||
|
|
||||||
type paletteItem struct {
|
type paletteItem struct {
|
||||||
label string
|
label string
|
||||||
hint string
|
hint string
|
||||||
@@ -113,7 +105,6 @@ type settingsInputForm struct {
|
|||||||
title string
|
title string
|
||||||
field string
|
field string
|
||||||
value []rune
|
value []rune
|
||||||
subtitle string
|
|
||||||
}
|
}
|
||||||
|
|
||||||
// paletteState is the in-memory model for the overlay. SPEC §4: a
|
// paletteState is the in-memory model for the overlay. SPEC §4: a
|
||||||
@@ -205,8 +196,10 @@ func (p *paletteState) rebuild() {
|
|||||||
all := p.buildItems(macro)
|
all := p.buildItems(macro)
|
||||||
|
|
||||||
if rest == "" {
|
if rest == "" {
|
||||||
// No textual filter: render with section headers between groups.
|
// No textual filter: render with blank spacer rows between
|
||||||
p.items = itemsWithHeaders(all)
|
// groups so sections read as scannable bands without dashed
|
||||||
|
// headers stealing visual weight.
|
||||||
|
p.items = itemsWithSpacers(all)
|
||||||
p.clampCursor()
|
p.clampCursor()
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
@@ -243,25 +236,28 @@ func (p *paletteState) rebuild() {
|
|||||||
}
|
}
|
||||||
|
|
||||||
// buildItems assembles every selectable row in fixed group order
|
// buildItems assembles every selectable row in fixed group order
|
||||||
// (Focused → Open → Spawn → Quit). Headers are added by
|
// (Focused → Open → Spawn → Quit). Blank spacer rows are added by
|
||||||
// itemsWithHeaders for the no-query case; scored mode drops them.
|
// itemsWithSpacers for the no-query case; scored mode drops them.
|
||||||
// When macro is non-empty the result is filtered down to the kinds
|
// When macro is non-empty the result is filtered down to the kinds
|
||||||
// that macro retains.
|
// that macro retains.
|
||||||
func (p *paletteState) buildItems(macro string) []paletteItem {
|
func (p *paletteState) buildItems(macro string) []paletteItem {
|
||||||
var out []paletteItem
|
var out []paletteItem
|
||||||
|
|
||||||
// Group 0: Focused — context-aware actions for whatever owns focus.
|
// Group 0: Focused — context-aware actions for whatever owns focus.
|
||||||
// A focused scratchpad shadows any focused child.
|
// A focused scratchpad shadows any focused child. Labels are bare
|
||||||
|
// verbs because the title bar already carries the subject ("on:
|
||||||
|
// codex" / "pad: notes.md"); the noun + name move into the hint so
|
||||||
|
// fuzzy queries like "close codex" still surface the row.
|
||||||
switch {
|
switch {
|
||||||
case p.focusedPad != "":
|
case p.focusedPad != "":
|
||||||
name := p.focusedPad
|
name := p.focusedPad
|
||||||
out = append(out,
|
out = append(out,
|
||||||
paletteItem{label: "Delete scratchpad: " + name, hint: "remove the file from disk",
|
paletteItem{label: "Edit", hint: "edit scratchpad · " + name + " (opens $EDITOR)",
|
||||||
action: paletteAction{kind: "pad-delete", padName: name}, group: groupFocused},
|
|
||||||
paletteItem{label: "Rename scratchpad: " + name, hint: "inline rename · enter to commit",
|
|
||||||
action: paletteAction{kind: "pad-rename-form", padName: name}, group: groupFocused},
|
|
||||||
paletteItem{label: "Edit scratchpad: " + name, hint: "open in external editor (zed)",
|
|
||||||
action: paletteAction{kind: "pad-edit", padName: name}, group: groupFocused},
|
action: paletteAction{kind: "pad-edit", padName: name}, group: groupFocused},
|
||||||
|
paletteItem{label: "Rename", hint: "rename scratchpad · " + name,
|
||||||
|
action: paletteAction{kind: "pad-rename-form", padName: name}, group: groupFocused},
|
||||||
|
paletteItem{label: "Delete", hint: "delete scratchpad · " + name,
|
||||||
|
action: paletteAction{kind: "pad-delete", padName: name}, group: groupFocused},
|
||||||
)
|
)
|
||||||
case p.focused != "":
|
case p.focused != "":
|
||||||
if c := findChildByID(p.children, p.focused); c != nil {
|
if c := findChildByID(p.children, p.focused); c != nil {
|
||||||
@@ -269,40 +265,48 @@ func (p *paletteState) buildItems(macro string) []paletteItem {
|
|||||||
switch c.Kind {
|
switch c.Kind {
|
||||||
case KindAgent:
|
case KindAgent:
|
||||||
out = append(out,
|
out = append(out,
|
||||||
paletteItem{label: "Rename agent: " + name, hint: "inline rename · enter to commit",
|
paletteItem{label: "Rename", hint: "rename agent · " + name,
|
||||||
action: paletteAction{kind: "agent-rename-form", childID: c.ID}, group: groupFocused},
|
action: paletteAction{kind: "agent-rename-form", childID: c.ID}, group: groupFocused},
|
||||||
paletteItem{label: "Close agent: " + name, hint: "SIGTERM " + strings.Join(c.Argv, " "),
|
paletteItem{label: "Close", hint: "close agent · " + name + " (SIGTERM, escalates)",
|
||||||
action: paletteAction{kind: "agent-close", childID: c.ID}, group: groupFocused},
|
action: paletteAction{kind: "agent-close", childID: c.ID}, group: groupFocused},
|
||||||
)
|
)
|
||||||
|
case KindTerminal:
|
||||||
|
out = append(out,
|
||||||
|
paletteItem{label: "Rename", hint: "rename terminal · " + name,
|
||||||
|
action: paletteAction{kind: "proc-rename-form", childID: c.ID}, group: groupFocused},
|
||||||
|
paletteItem{label: "Close", hint: "close terminal · " + name + " (SIGTERM)",
|
||||||
|
action: paletteAction{kind: "proc-stop", childID: c.ID}, group: groupFocused},
|
||||||
|
paletteItem{label: "Restart", hint: "restart terminal · " + name,
|
||||||
|
action: paletteAction{kind: "proc-restart", childID: c.ID}, group: groupFocused},
|
||||||
|
)
|
||||||
default:
|
default:
|
||||||
out = append(out,
|
out = append(out,
|
||||||
paletteItem{label: "Rename process: " + name, hint: "inline rename · enter to commit",
|
paletteItem{label: "Rename", hint: "rename process · " + name,
|
||||||
action: paletteAction{kind: "proc-rename-form", childID: c.ID}, group: groupFocused},
|
action: paletteAction{kind: "proc-rename-form", childID: c.ID}, group: groupFocused},
|
||||||
paletteItem{label: "Delete process: " + name, hint: "remove entry; SIGKILL if alive",
|
paletteItem{label: "Stop", hint: "stop process · " + name + " (SIGTERM, keeps entry)",
|
||||||
action: paletteAction{kind: "proc-delete", childID: c.ID}, group: groupFocused},
|
|
||||||
paletteItem{label: "Stop process: " + name, hint: "SIGTERM · keep entry for restart",
|
|
||||||
action: paletteAction{kind: "proc-stop", childID: c.ID}, group: groupFocused},
|
action: paletteAction{kind: "proc-stop", childID: c.ID}, group: groupFocused},
|
||||||
paletteItem{label: "Restart process: " + name, hint: "SIGTERM then start with same argv",
|
paletteItem{label: "Restart", hint: "restart process · " + name,
|
||||||
action: paletteAction{kind: "proc-restart", childID: c.ID}, group: groupFocused},
|
action: paletteAction{kind: "proc-restart", childID: c.ID}, group: groupFocused},
|
||||||
|
paletteItem{label: "Delete", hint: "delete process · " + name + " (SIGKILL if alive)",
|
||||||
|
action: paletteAction{kind: "proc-delete", childID: c.ID}, group: groupFocused},
|
||||||
)
|
)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
// Group 1: Open — switch entries for every running child. Dead
|
// Group 1: Open — switch entries for every running child *other than*
|
||||||
|
// the one already focused (no point offering a no-op switch). Dead
|
||||||
// agents are filtered out (no restart path); dead command processes
|
// agents are filtered out (no restart path); dead command processes
|
||||||
// remain so they can be restarted. The currently-focused child is
|
// remain so they can be restarted.
|
||||||
// marked with a leading ▶ instead of the older "• … (current)" suffix
|
|
||||||
// so the row reads cleaner.
|
|
||||||
for _, c := range p.children {
|
for _, c := range p.children {
|
||||||
|
if c.ID == p.focused {
|
||||||
|
continue
|
||||||
|
}
|
||||||
if c.Kind == KindAgent && c.Status() != StatusRunning {
|
if c.Kind == KindAgent && c.Status() != StatusRunning {
|
||||||
continue
|
continue
|
||||||
}
|
}
|
||||||
label := "Switch to " + c.DisplayName()
|
label := "Switch to " + c.DisplayName()
|
||||||
hint := strings.Join(c.Argv, " ")
|
hint := strings.Join(c.Argv, " ")
|
||||||
if c.ID == p.focused {
|
|
||||||
label = "▶ " + label
|
|
||||||
}
|
|
||||||
if c.Status() != StatusRunning {
|
if c.Status() != StatusRunning {
|
||||||
label = label + " [" + string(c.Status()) + "]"
|
label = label + " [" + string(c.Status()) + "]"
|
||||||
}
|
}
|
||||||
@@ -353,6 +357,12 @@ func (p *paletteState) buildItems(macro string) []paletteItem {
|
|||||||
action: paletteAction{kind: "settings-open"},
|
action: paletteAction{kind: "settings-open"},
|
||||||
group: groupSettings,
|
group: groupSettings,
|
||||||
})
|
})
|
||||||
|
out = append(out, paletteItem{
|
||||||
|
label: "Clear notifications",
|
||||||
|
hint: "dismiss all toasts in the top-right of the focused pane",
|
||||||
|
action: paletteAction{kind: "toasts-clear"},
|
||||||
|
group: groupSettings,
|
||||||
|
})
|
||||||
|
|
||||||
// Group 4: Quit.
|
// Group 4: Quit.
|
||||||
out = append(out, paletteItem{
|
out = append(out, paletteItem{
|
||||||
@@ -378,9 +388,11 @@ func (p *paletteState) buildItems(macro string) []paletteItem {
|
|||||||
return out
|
return out
|
||||||
}
|
}
|
||||||
|
|
||||||
// itemsWithHeaders splices a non-selectable header row in front of
|
// itemsWithSpacers splices a non-selectable blank row between groups
|
||||||
// each new group so the (unfiltered) list reads as scannable bands.
|
// so the (unfiltered) list reads as scannable bands without dashed
|
||||||
func itemsWithHeaders(items []paletteItem) []paletteItem {
|
// section headers stealing weight from the actions themselves. The
|
||||||
|
// first group never gets a leading spacer.
|
||||||
|
func itemsWithSpacers(items []paletteItem) []paletteItem {
|
||||||
if len(items) == 0 {
|
if len(items) == 0 {
|
||||||
return nil
|
return nil
|
||||||
}
|
}
|
||||||
@@ -388,17 +400,14 @@ func itemsWithHeaders(items []paletteItem) []paletteItem {
|
|||||||
currentGroup := -1
|
currentGroup := -1
|
||||||
for _, it := range items {
|
for _, it := range items {
|
||||||
if it.group != currentGroup {
|
if it.group != currentGroup {
|
||||||
currentGroup = it.group
|
if currentGroup != -1 {
|
||||||
label, ok := groupLabels[it.group]
|
|
||||||
if !ok {
|
|
||||||
label = ""
|
|
||||||
}
|
|
||||||
result = append(result, paletteItem{
|
result = append(result, paletteItem{
|
||||||
label: "── " + label + " ──",
|
|
||||||
action: paletteAction{kind: "header"},
|
action: paletteAction{kind: "header"},
|
||||||
group: it.group,
|
group: it.group,
|
||||||
})
|
})
|
||||||
}
|
}
|
||||||
|
currentGroup = it.group
|
||||||
|
}
|
||||||
result = append(result, it)
|
result = append(result, it)
|
||||||
}
|
}
|
||||||
return result
|
return result
|
||||||
@@ -1276,8 +1285,11 @@ func (p *paletteState) handleSettingsTextInput(chunk []byte, i int) (paletteActi
|
|||||||
}
|
}
|
||||||
switch b {
|
switch b {
|
||||||
case '\r', '\n':
|
case '\r', '\n':
|
||||||
p.applySettingsInput()
|
changed := p.applySettingsInput()
|
||||||
p.mode = paletteModeAutoSummary
|
p.mode = paletteModeAutoSummary
|
||||||
|
if changed {
|
||||||
|
return p.settingsAction("settings-save"), false, 1
|
||||||
|
}
|
||||||
case 0x7f, 0x08:
|
case 0x7f, 0x08:
|
||||||
if len(p.settingsInput.value) > 0 {
|
if len(p.settingsInput.value) > 0 {
|
||||||
p.settingsInput.value = p.settingsInput.value[:len(p.settingsInput.value)-1]
|
p.settingsInput.value = p.settingsInput.value[:len(p.settingsInput.value)-1]
|
||||||
@@ -1307,9 +1319,6 @@ func autoSummaryRows() []autoSummaryRow {
|
|||||||
{key: "cadence", label: "Cadence"},
|
{key: "cadence", label: "Cadence"},
|
||||||
{key: "test", label: "Test summarizer"},
|
{key: "test", label: "Test summarizer"},
|
||||||
{key: "run_now", label: "Summarize current top-level agent now"},
|
{key: "run_now", label: "Summarize current top-level agent now"},
|
||||||
{key: "save", label: "Save settings"},
|
|
||||||
{key: "cancel", label: "Cancel"},
|
|
||||||
{key: "back", label: "Back to Settings"},
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -1321,6 +1330,8 @@ func (p *paletteState) activateAutoSummaryRow() (paletteAction, bool, int) {
|
|||||||
switch rows[p.cursor].key {
|
switch rows[p.cursor].key {
|
||||||
case "enabled":
|
case "enabled":
|
||||||
p.settings.AutoSummary.Enabled = !p.settings.AutoSummary.Enabled
|
p.settings.AutoSummary.Enabled = !p.settings.AutoSummary.Enabled
|
||||||
|
p.settings.normalize()
|
||||||
|
return p.settingsAction("settings-save"), false, 1
|
||||||
case "provider":
|
case "provider":
|
||||||
switch p.settings.AutoSummary.Provider {
|
switch p.settings.AutoSummary.Provider {
|
||||||
case "codex":
|
case "codex":
|
||||||
@@ -1330,13 +1341,14 @@ func (p *paletteState) activateAutoSummaryRow() (paletteAction, bool, int) {
|
|||||||
default:
|
default:
|
||||||
p.settings.AutoSummary.Provider = "codex"
|
p.settings.AutoSummary.Provider = "codex"
|
||||||
}
|
}
|
||||||
|
p.settings.normalize()
|
||||||
|
return p.settingsAction("settings-save"), false, 1
|
||||||
case "codex_model", "opencode_model", "claude_model":
|
case "codex_model", "opencode_model", "claude_model":
|
||||||
provider := strings.TrimSuffix(rows[p.cursor].key, "_model")
|
provider := strings.TrimSuffix(rows[p.cursor].key, "_model")
|
||||||
p.settingsInput = &settingsInputForm{
|
p.settingsInput = &settingsInputForm{
|
||||||
title: provider + " model",
|
title: provider + " model",
|
||||||
field: rows[p.cursor].key,
|
field: rows[p.cursor].key,
|
||||||
value: []rune(p.settings.AutoSummary.modelFor(provider)),
|
value: []rune(p.settings.AutoSummary.modelFor(provider)),
|
||||||
subtitle: "model flag passed to " + provider,
|
|
||||||
}
|
}
|
||||||
p.mode = paletteModeSettingsInput
|
p.mode = paletteModeSettingsInput
|
||||||
case "cadence":
|
case "cadence":
|
||||||
@@ -1348,48 +1360,42 @@ func (p *paletteState) activateAutoSummaryRow() (paletteAction, bool, int) {
|
|||||||
default:
|
default:
|
||||||
p.settings.AutoSummary.Cadence = "15s"
|
p.settings.AutoSummary.Cadence = "15s"
|
||||||
}
|
}
|
||||||
|
p.settings.normalize()
|
||||||
|
return p.settingsAction("settings-save"), false, 1
|
||||||
case "test":
|
case "test":
|
||||||
return p.settingsAction("settings-test"), true, 1
|
return p.settingsAction("settings-test"), true, 1
|
||||||
case "run_now":
|
case "run_now":
|
||||||
return p.settingsAction("settings-run-now"), true, 1
|
return p.settingsAction("settings-run-now"), true, 1
|
||||||
case "save":
|
|
||||||
return p.settingsAction("settings-close"), true, 1
|
|
||||||
case "cancel":
|
|
||||||
return paletteAction{kind: "cancel"}, true, 1
|
|
||||||
case "back":
|
|
||||||
p.mode = paletteModeSettings
|
|
||||||
p.cursor = 0
|
|
||||||
p.query = nil
|
|
||||||
p.rebuildSettings()
|
|
||||||
}
|
}
|
||||||
p.settings.normalize()
|
p.settings.normalize()
|
||||||
return paletteAction{}, false, 1
|
return paletteAction{}, false, 1
|
||||||
}
|
}
|
||||||
|
|
||||||
func (p *paletteState) applySettingsInput() {
|
func (p *paletteState) applySettingsInput() bool {
|
||||||
if p.settingsInput == nil {
|
if p.settingsInput == nil {
|
||||||
return
|
return false
|
||||||
}
|
}
|
||||||
val := strings.TrimSpace(string(p.settingsInput.value))
|
val := strings.TrimSpace(string(p.settingsInput.value))
|
||||||
if val == "" {
|
if val == "" {
|
||||||
return
|
return false
|
||||||
}
|
}
|
||||||
if p.settings.AutoSummary.Models == nil {
|
if p.settings.AutoSummary.Models == nil {
|
||||||
p.settings.AutoSummary.Models = defaultSummaryModels()
|
p.settings.AutoSummary.Models = defaultSummaryModels()
|
||||||
}
|
}
|
||||||
|
changed := false
|
||||||
switch p.settingsInput.field {
|
switch p.settingsInput.field {
|
||||||
case "codex_model":
|
case "codex_model":
|
||||||
|
changed = p.settings.AutoSummary.Models["codex"] != val
|
||||||
p.settings.AutoSummary.Models["codex"] = val
|
p.settings.AutoSummary.Models["codex"] = val
|
||||||
case "opencode_model":
|
case "opencode_model":
|
||||||
|
changed = p.settings.AutoSummary.Models["opencode"] != val
|
||||||
p.settings.AutoSummary.Models["opencode"] = val
|
p.settings.AutoSummary.Models["opencode"] = val
|
||||||
case "claude_model":
|
case "claude_model":
|
||||||
|
changed = p.settings.AutoSummary.Models["claude"] != val
|
||||||
p.settings.AutoSummary.Models["claude"] = val
|
p.settings.AutoSummary.Models["claude"] = val
|
||||||
}
|
}
|
||||||
p.settings.normalize()
|
p.settings.normalize()
|
||||||
}
|
return changed
|
||||||
|
|
||||||
func (p *paletteState) settingsCloseAction() paletteAction {
|
|
||||||
return p.settingsAction("settings-close")
|
|
||||||
}
|
}
|
||||||
|
|
||||||
func (p *paletteState) settingsAction(kind string) paletteAction {
|
func (p *paletteState) settingsAction(kind string) paletteAction {
|
||||||
@@ -1398,7 +1404,7 @@ func (p *paletteState) settingsAction(kind string) paletteAction {
|
|||||||
}
|
}
|
||||||
|
|
||||||
func (p *paletteState) renderSettings(out writeFlusher, cols, rows int) {
|
func (p *paletteState) renderSettings(out writeFlusher, cols, rows int) {
|
||||||
p.renderSimplePicker(out, cols, rows, "Settings", "esc cancel", "search settings")
|
p.renderSimplePicker(out, cols, rows, "Settings", "esc close", "search settings")
|
||||||
}
|
}
|
||||||
|
|
||||||
func (p *paletteState) renderSimplePicker(out writeFlusher, cols, rows int, title, hint, placeholder string) {
|
func (p *paletteState) renderSimplePicker(out writeFlusher, cols, rows int, title, hint, placeholder string) {
|
||||||
@@ -1434,7 +1440,7 @@ func (p *paletteState) renderSimplePicker(out writeFlusher, cols, rows int, titl
|
|||||||
moveTo(&b, row, leftPad)
|
moveTo(&b, row, leftPad)
|
||||||
b.WriteString(styleBorder + "├" + strings.Repeat("─", width-2) + "┤" + styleReset)
|
b.WriteString(styleBorder + "├" + strings.Repeat("─", width-2) + "┤" + styleReset)
|
||||||
row++
|
row++
|
||||||
footer := styleHint + "↵ open · esc cancel · ↑↓ navigate" + styleReset
|
footer := styleHint + "↵ open · esc close · ↑↓ navigate" + styleReset
|
||||||
moveTo(&b, row, leftPad)
|
moveTo(&b, row, leftPad)
|
||||||
b.WriteString(styleBorder + "│" + styleReset + " " + footer + strings.Repeat(" ", max(0, content-visibleLen(footer))) + " " + styleBorder + "│" + styleReset)
|
b.WriteString(styleBorder + "│" + styleReset + " " + footer + strings.Repeat(" ", max(0, content-visibleLen(footer))) + " " + styleBorder + "│" + styleReset)
|
||||||
row++
|
row++
|
||||||
@@ -1450,7 +1456,7 @@ func (p *paletteState) renderAutoSummary(out writeFlusher, cols, rows int) {
|
|||||||
b.WriteString("\x1b[?25l\x1b[H\x1b[2J\x1b[3J")
|
b.WriteString("\x1b[?25l\x1b[H\x1b[2J\x1b[3J")
|
||||||
row := 2
|
row := 2
|
||||||
title := "Auto-summarization"
|
title := "Auto-summarization"
|
||||||
hint := "esc cancel"
|
hint := "esc close"
|
||||||
moveTo(&b, row, leftPad)
|
moveTo(&b, row, leftPad)
|
||||||
b.WriteString(styleBorder + "╭─ " + styleActive + title + styleReset + styleBorder + " " + strings.Repeat("─", max(2, width-visibleLen(title)-visibleLen(hint)-9)) + " " + styleHint + hint + styleReset + styleBorder + " ─╮" + styleReset)
|
b.WriteString(styleBorder + "╭─ " + styleActive + title + styleReset + styleBorder + " " + strings.Repeat("─", max(2, width-visibleLen(title)-visibleLen(hint)-9)) + " " + styleHint + hint + styleReset + styleBorder + " ─╮" + styleReset)
|
||||||
row++
|
row++
|
||||||
@@ -1472,7 +1478,7 @@ func (p *paletteState) renderAutoSummary(out writeFlusher, cols, rows int) {
|
|||||||
moveTo(&b, row, leftPad)
|
moveTo(&b, row, leftPad)
|
||||||
b.WriteString(styleBorder + "├" + strings.Repeat("─", width-2) + "┤" + styleReset)
|
b.WriteString(styleBorder + "├" + strings.Repeat("─", width-2) + "┤" + styleReset)
|
||||||
row++
|
row++
|
||||||
footer := styleHint + "↵ edit/toggle · cadence 15s/30s/1m · save row commits · esc cancel" + styleReset
|
footer := styleHint + "↵ edit/toggle · esc close" + styleReset
|
||||||
if visibleLen(footer) > content {
|
if visibleLen(footer) > content {
|
||||||
footer = clipRunes(footer, content-1) + "…"
|
footer = clipRunes(footer, content-1) + "…"
|
||||||
}
|
}
|
||||||
@@ -1502,7 +1508,7 @@ func (p *paletteState) autoSummaryDisplayRows() []string {
|
|||||||
var out []string
|
var out []string
|
||||||
for _, row := range autoSummaryRows() {
|
for _, row := range autoSummaryRows() {
|
||||||
if v, ok := values[row.key]; ok {
|
if v, ok := values[row.key]; ok {
|
||||||
out = append(out, row.label+": "+v)
|
out = append(out, styleHint+row.label+":"+styleReset+" "+v)
|
||||||
} else {
|
} else {
|
||||||
out = append(out, row.label)
|
out = append(out, row.label)
|
||||||
}
|
}
|
||||||
@@ -1519,19 +1525,10 @@ func (p *paletteState) renderSettingsInput(out writeFlusher, cols, rows int) {
|
|||||||
b.WriteString("\x1b[?25l\x1b[H\x1b[2J\x1b[3J")
|
b.WriteString("\x1b[?25l\x1b[H\x1b[2J\x1b[3J")
|
||||||
row := 2
|
row := 2
|
||||||
title := p.settingsInput.title
|
title := p.settingsInput.title
|
||||||
hint := "esc cancel"
|
hint := "esc back"
|
||||||
moveTo(&b, row, leftPad)
|
moveTo(&b, row, leftPad)
|
||||||
b.WriteString(styleBorder + "╭─ " + styleActive + title + styleReset + styleBorder + " " + strings.Repeat("─", max(2, width-visibleLen(title)-visibleLen(hint)-9)) + " " + styleHint + hint + styleReset + styleBorder + " ─╮" + styleReset)
|
b.WriteString(styleBorder + "╭─ " + styleActive + title + styleReset + styleBorder + " " + strings.Repeat("─", max(2, width-visibleLen(title)-visibleLen(hint)-9)) + " " + styleHint + hint + styleReset + styleBorder + " ─╮" + styleReset)
|
||||||
row++
|
row++
|
||||||
if p.settingsInput.subtitle != "" {
|
|
||||||
sub := p.settingsInput.subtitle
|
|
||||||
if visibleLen(sub) > content {
|
|
||||||
sub = clipRunes(sub, content-1) + "…"
|
|
||||||
}
|
|
||||||
moveTo(&b, row, leftPad)
|
|
||||||
b.WriteString(styleBorder + "│" + styleReset + " " + styleHint + sub + styleReset + strings.Repeat(" ", max(0, content-visibleLen(sub))) + " " + styleBorder + "│" + styleReset)
|
|
||||||
row++
|
|
||||||
}
|
|
||||||
value := string(p.settingsInput.value)
|
value := string(p.settingsInput.value)
|
||||||
if visibleLen(value) > content-2 {
|
if visibleLen(value) > content-2 {
|
||||||
value = clipRunes(value, content-3) + "…"
|
value = clipRunes(value, content-3) + "…"
|
||||||
@@ -1543,7 +1540,7 @@ func (p *paletteState) renderSettingsInput(out writeFlusher, cols, rows int) {
|
|||||||
moveTo(&b, row, leftPad)
|
moveTo(&b, row, leftPad)
|
||||||
b.WriteString(styleBorder + "├" + strings.Repeat("─", width-2) + "┤" + styleReset)
|
b.WriteString(styleBorder + "├" + strings.Repeat("─", width-2) + "┤" + styleReset)
|
||||||
row++
|
row++
|
||||||
footer := styleHint + "↵ save · esc cancel · ⌃u clear" + styleReset
|
footer := styleHint + "↵ apply · esc back · ⌃u clear" + styleReset
|
||||||
moveTo(&b, row, leftPad)
|
moveTo(&b, row, leftPad)
|
||||||
b.WriteString(styleBorder + "│" + styleReset + " " + footer + strings.Repeat(" ", max(0, content-visibleLen(footer))) + " " + styleBorder + "│" + styleReset)
|
b.WriteString(styleBorder + "│" + styleReset + " " + footer + strings.Repeat(" ", max(0, content-visibleLen(footer))) + " " + styleBorder + "│" + styleReset)
|
||||||
row++
|
row++
|
||||||
|
|||||||
@@ -31,16 +31,17 @@ func findItem(p *paletteState, want string) (int, *paletteItem) {
|
|||||||
|
|
||||||
func TestContextItemsScratchpad(t *testing.T) {
|
func TestContextItemsScratchpad(t *testing.T) {
|
||||||
p := newPalette(nil, "", "notes.md", preset.Set{})
|
p := newPalette(nil, "", "notes.md", preset.Set{})
|
||||||
// pad-delete is the first selectable row; the Focused section header
|
// With the dashed section header gone, pad-edit is the first row;
|
||||||
// (a non-selectable row) sits above it.
|
// pad-rename-form follows, with destructive pad-delete last in the
|
||||||
if i, _ := findItem(p, "pad-delete"); i != 1 {
|
// Focused section.
|
||||||
t.Fatalf("pad-delete at %d; want 1 (after Focused header)", i)
|
if i, _ := findItem(p, "pad-edit"); i != 0 {
|
||||||
|
t.Fatalf("pad-edit at %d; want 0", i)
|
||||||
}
|
}
|
||||||
if _, it := findItem(p, "pad-rename-form"); it == nil || it.action.padName != "notes.md" {
|
if _, it := findItem(p, "pad-rename-form"); it == nil || it.action.padName != "notes.md" {
|
||||||
t.Fatalf("pad-rename-form missing or wrong padName: %+v", it)
|
t.Fatalf("pad-rename-form missing or wrong padName: %+v", it)
|
||||||
}
|
}
|
||||||
if _, it := findItem(p, "pad-edit"); it == nil {
|
if i, _ := findItem(p, "pad-delete"); i < 0 {
|
||||||
t.Fatalf("pad-edit missing")
|
t.Fatalf("pad-delete missing")
|
||||||
}
|
}
|
||||||
// No focused child → no agent/proc context items.
|
// No focused child → no agent/proc context items.
|
||||||
if i, _ := findItem(p, "agent-rename-form"); i != -1 {
|
if i, _ := findItem(p, "agent-rename-form"); i != -1 {
|
||||||
@@ -82,9 +83,31 @@ func TestContextItemsProcess(t *testing.T) {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func TestContextItemsTerminalUsesCloseNotStop(t *testing.T) {
|
||||||
|
c := makeFakeChild("tid", "terminal", KindTerminal)
|
||||||
|
p := newPalette([]*Child{c}, "tid", "", preset.Set{})
|
||||||
|
if _, it := findItem(p, "proc-stop"); it == nil || it.label != "Close" {
|
||||||
|
t.Fatalf("terminal close row missing or mislabelled: %+v", it)
|
||||||
|
}
|
||||||
|
if _, it := findItem(p, "proc-restart"); it == nil {
|
||||||
|
t.Fatalf("terminal restart row missing")
|
||||||
|
}
|
||||||
|
if i, _ := findItem(p, "proc-delete"); i != -1 {
|
||||||
|
t.Fatalf("terminal should not show a separate delete/close row, found at %d", i)
|
||||||
|
}
|
||||||
|
for i, it := range p.items {
|
||||||
|
if it.label == "Stop" {
|
||||||
|
t.Fatalf("terminal should not show Stop row, found at %d", i)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
func TestContextItemsAppearAboveSwitch(t *testing.T) {
|
func TestContextItemsAppearAboveSwitch(t *testing.T) {
|
||||||
c := makeFakeChild("pid", "devserver", KindCommand)
|
// Two children so there's still a non-focused switch entry to compare
|
||||||
p := newPalette([]*Child{c}, "pid", "", preset.Set{})
|
// against (the focused child is suppressed from the Open section).
|
||||||
|
focused := makeFakeChild("pid", "devserver", KindCommand)
|
||||||
|
other := makeFakeChild("oid", "worker", KindCommand)
|
||||||
|
p := newPalette([]*Child{focused, other}, "pid", "", preset.Set{})
|
||||||
procIdx, _ := findItem(p, "proc-rename-form")
|
procIdx, _ := findItem(p, "proc-rename-form")
|
||||||
switchIdx, _ := findItem(p, "switch")
|
switchIdx, _ := findItem(p, "switch")
|
||||||
if procIdx < 0 || switchIdx < 0 {
|
if procIdx < 0 || switchIdx < 0 {
|
||||||
|
|||||||
@@ -1,6 +1,7 @@
|
|||||||
package app
|
package app
|
||||||
|
|
||||||
import (
|
import (
|
||||||
|
"bytes"
|
||||||
"strings"
|
"strings"
|
||||||
"testing"
|
"testing"
|
||||||
|
|
||||||
@@ -57,21 +58,44 @@ func TestPaletteDropsGlobalCloseList(t *testing.T) {
|
|||||||
|
|
||||||
// -- Phase 2: section headers and cursor skip ------------------------
|
// -- Phase 2: section headers and cursor skip ------------------------
|
||||||
|
|
||||||
func TestPaletteSectionHeadersPresent(t *testing.T) {
|
func TestPaletteSectionsSeparatedBySpacers(t *testing.T) {
|
||||||
|
// Section-named dashed headers are gone; groups are visually
|
||||||
|
// separated by a single non-selectable blank row. Verify that the
|
||||||
|
// build emits one such spacer between every pair of adjacent groups
|
||||||
|
// and never a leading spacer.
|
||||||
c := makeFakeChild("a", "claude", KindAgent)
|
c := makeFakeChild("a", "claude", KindAgent)
|
||||||
p := newPalette([]*Child{c}, "a", "", preset.Set{Agents: []*preset.Preset{{Name: "codex"}}})
|
other := makeFakeChild("b", "worker", KindCommand)
|
||||||
wantSections := []string{"Focused", "Open", "Spawn", "Quit"}
|
p := newPalette([]*Child{c, other}, "a", "",
|
||||||
for _, w := range wantSections {
|
preset.Set{Agents: []*preset.Preset{{Name: "codex"}}})
|
||||||
found := false
|
|
||||||
for _, it := range p.items {
|
if len(p.items) == 0 {
|
||||||
if it.action.kind == "header" && strings.Contains(it.label, w) {
|
t.Fatalf("palette built no items")
|
||||||
found = true
|
}
|
||||||
break
|
if p.items[0].action.kind == "header" {
|
||||||
|
t.Fatalf("first row is a spacer; should be a selectable item")
|
||||||
|
}
|
||||||
|
transitions := 0
|
||||||
|
prevGroup := p.items[0].group
|
||||||
|
for i := 1; i < len(p.items); i++ {
|
||||||
|
it := p.items[i]
|
||||||
|
if it.group != prevGroup {
|
||||||
|
if it.action.kind != "header" || it.label != "" {
|
||||||
|
t.Fatalf("group transition at %d not a blank spacer: %+v", i, it)
|
||||||
|
}
|
||||||
|
transitions++
|
||||||
|
// The row immediately after the spacer must be selectable.
|
||||||
|
if i+1 >= len(p.items) || p.items[i+1].action.kind == "header" {
|
||||||
|
t.Fatalf("spacer at %d not followed by selectable row", i)
|
||||||
|
}
|
||||||
|
prevGroup = p.items[i+1].group
|
||||||
|
}
|
||||||
|
// No dashed banners anywhere.
|
||||||
|
if it.action.kind == "header" && strings.Contains(it.label, "──") {
|
||||||
|
t.Errorf("dashed section header still present at %d: %q", i, it.label)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
if !found {
|
if transitions == 0 {
|
||||||
t.Errorf("section header %q missing from items", w)
|
t.Fatalf("no section transitions found in palette items")
|
||||||
}
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -333,20 +357,95 @@ func TestAutoSummaryCadenceCyclesSoloValues(t *testing.T) {
|
|||||||
if p.settings.AutoSummary.Cadence != "1m" {
|
if p.settings.AutoSummary.Cadence != "1m" {
|
||||||
t.Fatalf("initial cadence = %q", p.settings.AutoSummary.Cadence)
|
t.Fatalf("initial cadence = %q", p.settings.AutoSummary.Cadence)
|
||||||
}
|
}
|
||||||
p.activateAutoSummaryRow()
|
action, done, _ := p.activateAutoSummaryRow()
|
||||||
|
if done || action.kind != "settings-save" {
|
||||||
|
t.Fatalf("first cycle action = %+v done=%v, want settings-save without close", action, done)
|
||||||
|
}
|
||||||
if p.settings.AutoSummary.Cadence != "15s" {
|
if p.settings.AutoSummary.Cadence != "15s" {
|
||||||
t.Fatalf("first cycle cadence = %q", p.settings.AutoSummary.Cadence)
|
t.Fatalf("first cycle cadence = %q", p.settings.AutoSummary.Cadence)
|
||||||
}
|
}
|
||||||
p.activateAutoSummaryRow()
|
action, done, _ = p.activateAutoSummaryRow()
|
||||||
|
if done || action.kind != "settings-save" {
|
||||||
|
t.Fatalf("second cycle action = %+v done=%v, want settings-save without close", action, done)
|
||||||
|
}
|
||||||
if p.settings.AutoSummary.Cadence != "30s" {
|
if p.settings.AutoSummary.Cadence != "30s" {
|
||||||
t.Fatalf("second cycle cadence = %q", p.settings.AutoSummary.Cadence)
|
t.Fatalf("second cycle cadence = %q", p.settings.AutoSummary.Cadence)
|
||||||
}
|
}
|
||||||
p.activateAutoSummaryRow()
|
action, done, _ = p.activateAutoSummaryRow()
|
||||||
|
if done || action.kind != "settings-save" {
|
||||||
|
t.Fatalf("third cycle action = %+v done=%v, want settings-save without close", action, done)
|
||||||
|
}
|
||||||
if p.settings.AutoSummary.Cadence != "1m" {
|
if p.settings.AutoSummary.Cadence != "1m" {
|
||||||
t.Fatalf("third cycle cadence = %q", p.settings.AutoSummary.Cadence)
|
t.Fatalf("third cycle cadence = %q", p.settings.AutoSummary.Cadence)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func TestAutoSummaryScreenOmitsExplicitSaveCancelBackRows(t *testing.T) {
|
||||||
|
omitted := map[string]bool{
|
||||||
|
"Save settings": true,
|
||||||
|
"Cancel": true,
|
||||||
|
"Back to Settings": true,
|
||||||
|
}
|
||||||
|
for _, row := range autoSummaryRows() {
|
||||||
|
if omitted[row.label] {
|
||||||
|
t.Fatalf("auto-summary settings should not show %q", row.label)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestAutoSummaryRenderOmitsStaleSettingsHelp(t *testing.T) {
|
||||||
|
p := newPalette(nil, "", "", preset.Set{}, defaultSettings())
|
||||||
|
p.mode = paletteModeAutoSummary
|
||||||
|
var b bytes.Buffer
|
||||||
|
p.renderAutoSummary(wrapWriter(&b), 100, 30)
|
||||||
|
out := b.String()
|
||||||
|
for _, text := range []string{
|
||||||
|
"Save settings",
|
||||||
|
"Cancel",
|
||||||
|
"Back to Settings",
|
||||||
|
"changes save",
|
||||||
|
"applies immediately",
|
||||||
|
} {
|
||||||
|
if strings.Contains(out, text) {
|
||||||
|
t.Fatalf("auto-summary render should not contain %q:\n%s", text, out)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestAutoSummaryValueRowsStyleLabelAndValueSeparately(t *testing.T) {
|
||||||
|
p := newPalette(nil, "", "", preset.Set{}, defaultSettings())
|
||||||
|
rows := p.autoSummaryDisplayRows()
|
||||||
|
for _, row := range rows {
|
||||||
|
if strings.Contains(row, "Cadence:") {
|
||||||
|
if !strings.HasPrefix(row, styleHint+"Cadence:"+styleReset+" ") {
|
||||||
|
t.Fatalf("cadence row styling = %q", row)
|
||||||
|
}
|
||||||
|
if strings.Contains(strings.TrimPrefix(row, styleHint+"Cadence:"+styleReset+" "), styleHint) {
|
||||||
|
t.Fatalf("cadence value should use regular text styling: %q", row)
|
||||||
|
}
|
||||||
|
return
|
||||||
|
}
|
||||||
|
}
|
||||||
|
t.Fatal("missing cadence display row")
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestAutoSummaryTextInputSavesWhenSubmitted(t *testing.T) {
|
||||||
|
p := newPalette(nil, "", "", preset.Set{}, defaultSettings())
|
||||||
|
p.mode = paletteModeSettingsInput
|
||||||
|
p.settingsInput = &settingsInputForm{
|
||||||
|
title: "codex model",
|
||||||
|
field: "codex_model",
|
||||||
|
value: []rune("custom-model"),
|
||||||
|
}
|
||||||
|
action, done, _ := p.handleSettingsTextInput([]byte{'\r'}, 0)
|
||||||
|
if done || action.kind != "settings-save" {
|
||||||
|
t.Fatalf("submit action = %+v done=%v, want settings-save without close", action, done)
|
||||||
|
}
|
||||||
|
if got := p.settings.AutoSummary.modelFor("codex"); got != "custom-model" {
|
||||||
|
t.Fatalf("codex model = %q", got)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
func TestPaletteFormCtrlRTogglesRelaunchFromCommandField(t *testing.T) {
|
func TestPaletteFormCtrlRTogglesRelaunchFromCommandField(t *testing.T) {
|
||||||
p := newPalette(nil, "", "", preset.Set{})
|
p := newPalette(nil, "", "", preset.Set{})
|
||||||
p.mode = paletteModeSpawnForm
|
p.mode = paletteModeSpawnForm
|
||||||
|
|||||||
@@ -104,3 +104,44 @@ func TestStripANSIBytesEquivalence(t *testing.T) {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func TestNormalizeGridText(t *testing.T) {
|
||||||
|
cases := []struct {
|
||||||
|
name string
|
||||||
|
in string
|
||||||
|
want string
|
||||||
|
}{
|
||||||
|
{
|
||||||
|
name: "line endings",
|
||||||
|
in: "one\r\ntwo\rthree",
|
||||||
|
want: "one\ntwo\nthree",
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "trailing whitespace",
|
||||||
|
in: "one \ntwo\t\t\nthree",
|
||||||
|
want: "one\ntwo\nthree",
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "collapse blank runs",
|
||||||
|
in: "one\n\n\n two\n \n\t\nthree",
|
||||||
|
want: "one\n\n two\n\nthree",
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "trim leading and trailing blanks",
|
||||||
|
in: "\n \n\t\none\n\n",
|
||||||
|
want: "one",
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "already clean",
|
||||||
|
in: "one\n\ntwo\nthree",
|
||||||
|
want: "one\n\ntwo\nthree",
|
||||||
|
},
|
||||||
|
}
|
||||||
|
for _, tc := range cases {
|
||||||
|
t.Run(tc.name, func(t *testing.T) {
|
||||||
|
if got := normalizeGridText(tc.in); got != tc.want {
|
||||||
|
t.Fatalf("normalizeGridText(%q) = %q, want %q", tc.in, got, tc.want)
|
||||||
|
}
|
||||||
|
})
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|||||||
137
internal/app/scratchpad_delete_test.go
Normal file
137
internal/app/scratchpad_delete_test.go
Normal file
@@ -0,0 +1,137 @@
|
|||||||
|
package app
|
||||||
|
|
||||||
|
import (
|
||||||
|
"errors"
|
||||||
|
"io"
|
||||||
|
"os"
|
||||||
|
"testing"
|
||||||
|
|
||||||
|
"github.com/hjbdev/patterm/internal/preset"
|
||||||
|
"github.com/hjbdev/patterm/internal/scratchpad"
|
||||||
|
)
|
||||||
|
|
||||||
|
func silenceStdout(t *testing.T) {
|
||||||
|
t.Helper()
|
||||||
|
old := os.Stdout
|
||||||
|
r, w, err := os.Pipe()
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("pipe stdout: %v", err)
|
||||||
|
}
|
||||||
|
done := make(chan struct{})
|
||||||
|
go func() {
|
||||||
|
_, _ = io.Copy(io.Discard, r)
|
||||||
|
close(done)
|
||||||
|
}()
|
||||||
|
os.Stdout = w
|
||||||
|
t.Cleanup(func() {
|
||||||
|
os.Stdout = old
|
||||||
|
_ = w.Close()
|
||||||
|
<-done
|
||||||
|
_ = r.Close()
|
||||||
|
})
|
||||||
|
}
|
||||||
|
|
||||||
|
func newScratchpadDeleteTestState(t *testing.T) (*uiState, *scratchpad.Store) {
|
||||||
|
t.Helper()
|
||||||
|
t.Setenv("XDG_DATA_HOME", t.TempDir())
|
||||||
|
pads, err := scratchpad.Open("scratchpad-delete-test")
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("scratchpad.Open: %v", err)
|
||||||
|
}
|
||||||
|
sess := NewSession(t.TempDir(), "scratchpad-delete-test")
|
||||||
|
t.Cleanup(sess.Shutdown)
|
||||||
|
st := &uiState{
|
||||||
|
sess: sess,
|
||||||
|
pads: pads,
|
||||||
|
hostCols: 120,
|
||||||
|
hostRows: 40,
|
||||||
|
chromeWake: make(chan struct{}, 1),
|
||||||
|
}
|
||||||
|
return st, pads
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestDeletingFocusedScratchpadFocusesAnotherPad(t *testing.T) {
|
||||||
|
silenceStdout(t)
|
||||||
|
st, pads := newScratchpadDeleteTestState(t)
|
||||||
|
if _, err := pads.Write("alpha.md", "alpha", ""); err != nil {
|
||||||
|
t.Fatalf("write alpha: %v", err)
|
||||||
|
}
|
||||||
|
if _, err := pads.Write("beta.md", "beta", ""); err != nil {
|
||||||
|
t.Fatalf("write beta: %v", err)
|
||||||
|
}
|
||||||
|
st.focusedPad = "alpha.md"
|
||||||
|
st.focusedName = "alpha.md"
|
||||||
|
st.padOffsetName = "alpha.md"
|
||||||
|
st.padOffset = 3
|
||||||
|
|
||||||
|
st.handlePadDelete("alpha.md")
|
||||||
|
|
||||||
|
if st.focusedPad != "beta.md" {
|
||||||
|
t.Fatalf("focusedPad = %q, want beta.md", st.focusedPad)
|
||||||
|
}
|
||||||
|
if st.focusedID != "" {
|
||||||
|
t.Fatalf("focusedID = %q, want empty while another pad is focused", st.focusedID)
|
||||||
|
}
|
||||||
|
if st.padOffset != 0 || st.padOffsetName != "beta.md" {
|
||||||
|
t.Fatalf("pad offset = (%q,%d), want (beta.md,0)", st.padOffsetName, st.padOffset)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestDeletingLastFocusedScratchpadFocusesRunningChild(t *testing.T) {
|
||||||
|
silenceStdout(t)
|
||||||
|
st, pads := newScratchpadDeleteTestState(t)
|
||||||
|
if _, err := pads.Write("only.md", "only", ""); err != nil {
|
||||||
|
t.Fatalf("write only: %v", err)
|
||||||
|
}
|
||||||
|
child := makeFakeChild("pid", "devserver", KindCommand)
|
||||||
|
addChild(st.sess, child)
|
||||||
|
st.focusedPad = "only.md"
|
||||||
|
st.focusedName = "only.md"
|
||||||
|
|
||||||
|
st.handlePadDelete("only.md")
|
||||||
|
|
||||||
|
if st.focusedPad != "" {
|
||||||
|
t.Fatalf("focusedPad = %q, want empty after falling back to child", st.focusedPad)
|
||||||
|
}
|
||||||
|
if st.focusedID != "pid" {
|
||||||
|
t.Fatalf("focusedID = %q, want pid", st.focusedID)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
type scratchpadChangeRecorder struct {
|
||||||
|
count int
|
||||||
|
}
|
||||||
|
|
||||||
|
func (r *scratchpadChangeRecorder) scratchpadsChanged() {
|
||||||
|
r.count++
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestToolHostScratchpadDeleteRemovesPadAndRefreshes(t *testing.T) {
|
||||||
|
t.Setenv("XDG_DATA_HOME", t.TempDir())
|
||||||
|
pads, err := scratchpad.Open("scratchpad-delete-host-test")
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("scratchpad.Open: %v", err)
|
||||||
|
}
|
||||||
|
if _, err := pads.Write("doomed.md", "content", ""); err != nil {
|
||||||
|
t.Fatalf("write doomed.md: %v", err)
|
||||||
|
}
|
||||||
|
recorder := &scratchpadChangeRecorder{}
|
||||||
|
host := newToolHost(nil, pads, nil, preset.Set{}, nil, 120, 40)
|
||||||
|
host.scratch = recorder
|
||||||
|
|
||||||
|
if err := host.ScratchpadDelete("doomed.md"); err != nil {
|
||||||
|
t.Fatalf("ScratchpadDelete: %v", err)
|
||||||
|
}
|
||||||
|
if recorder.count != 1 {
|
||||||
|
t.Fatalf("scratchpadsChanged calls = %d, want 1", recorder.count)
|
||||||
|
}
|
||||||
|
if _, _, err := pads.Read("doomed.md"); !errors.Is(err, os.ErrNotExist) {
|
||||||
|
t.Fatalf("read deleted pad error = %v, want os.ErrNotExist", err)
|
||||||
|
}
|
||||||
|
if err := host.ScratchpadDelete("doomed.md"); !errors.Is(err, os.ErrNotExist) {
|
||||||
|
t.Fatalf("delete missing error = %v, want os.ErrNotExist", err)
|
||||||
|
}
|
||||||
|
if recorder.count != 1 {
|
||||||
|
t.Fatalf("scratchpadsChanged calls after failed delete = %d, want 1", recorder.count)
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -46,6 +46,13 @@ type Session struct {
|
|||||||
listenersMu sync.Mutex
|
listenersMu sync.Mutex
|
||||||
listeners atomic.Pointer[[]ChildEventListener]
|
listeners atomic.Pointer[[]ChildEventListener]
|
||||||
|
|
||||||
|
// clientListeners is the network-client subscriber path. These
|
||||||
|
// listeners must be non-blocking and copy PTY chunks before enqueueing;
|
||||||
|
// daemon-internal observers (timers, debug capture, waiters) stay on
|
||||||
|
// listeners above so backpressure policy is isolated to clients.
|
||||||
|
clientListenersMu sync.Mutex
|
||||||
|
clientListeners atomic.Pointer[[]ChildEventListener]
|
||||||
|
|
||||||
// persistStore records top-level command entries to a per-project
|
// persistStore records top-level command entries to a per-project
|
||||||
// JSON file so they can be re-spawned after patterm restarts.
|
// JSON file so they can be re-spawned after patterm restarts.
|
||||||
// Optional; nil means "no persistence" (used by unit tests).
|
// Optional; nil means "no persistence" (used by unit tests).
|
||||||
@@ -91,6 +98,12 @@ type ChildEventListener interface {
|
|||||||
// updates a child's IdleState. Listeners use this to repaint the
|
// updates a child's IdleState. Listeners use this to repaint the
|
||||||
// sidebar badge and to evaluate idle-aware timers.
|
// sidebar badge and to evaluate idle-aware timers.
|
||||||
OnChildStateChanged(childID string, state IdleState)
|
OnChildStateChanged(childID string, state IdleState)
|
||||||
|
// OnChildClosed fires when a child is being removed from the
|
||||||
|
// session (either via close_process, or — for agent/terminal
|
||||||
|
// kinds — when the PTY exits and the entry will never be
|
||||||
|
// restarted). It signals that any pending references to childID
|
||||||
|
// (e.g. timers owned by or watching it) should be dropped.
|
||||||
|
OnChildClosed(childID string)
|
||||||
}
|
}
|
||||||
|
|
||||||
func NewSession(projectDir, projectKey string) *Session {
|
func NewSession(projectDir, projectKey string) *Session {
|
||||||
@@ -112,6 +125,16 @@ func (s *Session) Subscribe(l ChildEventListener) {
|
|||||||
s.listeners.Store(&next)
|
s.listeners.Store(&next)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func (s *Session) SubscribeClient(l ChildEventListener) {
|
||||||
|
s.clientListenersMu.Lock()
|
||||||
|
defer s.clientListenersMu.Unlock()
|
||||||
|
prev := s.clientListenersSnapshot()
|
||||||
|
next := make([]ChildEventListener, 0, len(prev)+1)
|
||||||
|
next = append(next, prev...)
|
||||||
|
next = append(next, l)
|
||||||
|
s.clientListeners.Store(&next)
|
||||||
|
}
|
||||||
|
|
||||||
// Unsubscribe removes a previously-registered listener. Safe to call
|
// Unsubscribe removes a previously-registered listener. Safe to call
|
||||||
// with a listener that wasn't registered (no-op).
|
// with a listener that wasn't registered (no-op).
|
||||||
func (s *Session) Unsubscribe(l ChildEventListener) {
|
func (s *Session) Unsubscribe(l ChildEventListener) {
|
||||||
@@ -140,16 +163,30 @@ func (s *Session) listenersSnapshot() []ChildEventListener {
|
|||||||
return *p
|
return *p
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func (s *Session) clientListenersSnapshot() []ChildEventListener {
|
||||||
|
p := s.clientListeners.Load()
|
||||||
|
if p == nil {
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
return *p
|
||||||
|
}
|
||||||
|
|
||||||
func (s *Session) emitSpawn(c *Child) {
|
func (s *Session) emitSpawn(c *Child) {
|
||||||
for _, l := range s.listenersSnapshot() {
|
for _, l := range s.listenersSnapshot() {
|
||||||
l.OnChildSpawned(c)
|
l.OnChildSpawned(c)
|
||||||
}
|
}
|
||||||
|
for _, l := range s.clientListenersSnapshot() {
|
||||||
|
l.OnChildSpawned(c)
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
func (s *Session) emitExit(c *Child) {
|
func (s *Session) emitExit(c *Child) {
|
||||||
for _, l := range s.listenersSnapshot() {
|
for _, l := range s.listenersSnapshot() {
|
||||||
l.OnChildExited(c)
|
l.OnChildExited(c)
|
||||||
}
|
}
|
||||||
|
for _, l := range s.clientListenersSnapshot() {
|
||||||
|
l.OnChildExited(c)
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
// emitPTYOut dispatches a fresh PTY chunk to every listener. Listeners
|
// emitPTYOut dispatches a fresh PTY chunk to every listener. Listeners
|
||||||
@@ -159,12 +196,27 @@ func (s *Session) emitPTYOut(id string, chunk []byte) {
|
|||||||
for _, l := range s.listenersSnapshot() {
|
for _, l := range s.listenersSnapshot() {
|
||||||
l.OnPTYOut(id, chunk)
|
l.OnPTYOut(id, chunk)
|
||||||
}
|
}
|
||||||
|
for _, l := range s.clientListenersSnapshot() {
|
||||||
|
l.OnPTYOut(id, chunk)
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
func (s *Session) emitStateChanged(id string, state IdleState) {
|
func (s *Session) emitStateChanged(id string, state IdleState) {
|
||||||
for _, l := range s.listenersSnapshot() {
|
for _, l := range s.listenersSnapshot() {
|
||||||
l.OnChildStateChanged(id, state)
|
l.OnChildStateChanged(id, state)
|
||||||
}
|
}
|
||||||
|
for _, l := range s.clientListenersSnapshot() {
|
||||||
|
l.OnChildStateChanged(id, state)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func (s *Session) emitClosed(id string) {
|
||||||
|
for _, l := range s.listenersSnapshot() {
|
||||||
|
l.OnChildClosed(id)
|
||||||
|
}
|
||||||
|
for _, l := range s.clientListenersSnapshot() {
|
||||||
|
l.OnChildClosed(id)
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
func (s *Session) ChildEnv() []string {
|
func (s *Session) ChildEnv() []string {
|
||||||
@@ -374,10 +426,29 @@ func (s *Session) Close(id string, sig syscall.Signal) error {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
s.mu.Unlock()
|
s.mu.Unlock()
|
||||||
|
// Notify listeners outside s.mu so they can take their own locks
|
||||||
|
// without inversion. Timer manager uses this to drop pending
|
||||||
|
// timers owned by or watching the closed child — otherwise the
|
||||||
|
// next classifier tick can deliver a stale fire to the parent.
|
||||||
|
s.emitClosed(id)
|
||||||
s.forgetPersisted(id)
|
s.forgetPersisted(id)
|
||||||
return nil
|
return nil
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// Terminate stops a live child with SIGTERM/SIGKILL escalation but
|
||||||
|
// leaves its session entry intact so callers can keep showing the
|
||||||
|
// exited pane.
|
||||||
|
func (s *Session) Terminate(id string, sig syscall.Signal) error {
|
||||||
|
c := s.FindChild(id)
|
||||||
|
if c == nil {
|
||||||
|
return fmt.Errorf("no such process %q", id)
|
||||||
|
}
|
||||||
|
if c.IsLive() {
|
||||||
|
terminateAndWait(c, sig, childStopTimeout)
|
||||||
|
}
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
|
||||||
// mintUniqueIDLocked mints an opaque process_id (SPEC §7) and retries
|
// mintUniqueIDLocked mints an opaque process_id (SPEC §7) and retries
|
||||||
// if it collides with an existing entry. Caller holds s.mu.
|
// if it collides with an existing entry. Caller holds s.mu.
|
||||||
func (s *Session) mintUniqueIDLocked() string {
|
func (s *Session) mintUniqueIDLocked() string {
|
||||||
@@ -486,6 +557,7 @@ func (s *Session) reapChild(c *Child, runID uint64) {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
s.mu.Unlock()
|
s.mu.Unlock()
|
||||||
|
s.emitClosed(c.ID)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -1,6 +1,7 @@
|
|||||||
package app
|
package app
|
||||||
|
|
||||||
import (
|
import (
|
||||||
|
"strings"
|
||||||
"syscall"
|
"syscall"
|
||||||
"testing"
|
"testing"
|
||||||
"time"
|
"time"
|
||||||
@@ -101,6 +102,50 @@ func TestSpawnInstallsIdleDetectionBeforePublish(t *testing.T) {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func TestTerminateEscalatesWithoutRemovingEntry(t *testing.T) {
|
||||||
|
sess := NewSession(t.TempDir(), "test")
|
||||||
|
c, err := sess.Spawn(SpawnSpec{
|
||||||
|
Kind: KindAgent,
|
||||||
|
Argv: []string{"sh", "-c", "trap '' TERM; echo ready; while :; do sleep 1; done"},
|
||||||
|
}, 80, 24)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("spawn: %v", err)
|
||||||
|
}
|
||||||
|
t.Cleanup(func() {
|
||||||
|
if c.IsLive() {
|
||||||
|
_ = c.signal(syscall.SIGKILL)
|
||||||
|
}
|
||||||
|
})
|
||||||
|
waitUntilLive(t, c)
|
||||||
|
waitForStreamText(t, c, "ready")
|
||||||
|
|
||||||
|
start := time.Now()
|
||||||
|
if err := sess.Terminate(c.ID, syscall.SIGTERM); err != nil {
|
||||||
|
t.Fatalf("Terminate: %v", err)
|
||||||
|
}
|
||||||
|
if elapsed := time.Since(start); elapsed < childStopTimeout {
|
||||||
|
t.Fatalf("Terminate returned before SIGKILL fallback: elapsed=%s timeout=%s", elapsed, childStopTimeout)
|
||||||
|
}
|
||||||
|
waitUntilNotLive(t, c)
|
||||||
|
|
||||||
|
if got := sess.FindChild(c.ID); got == nil {
|
||||||
|
t.Fatalf("Terminate removed child entry %s", c.ID)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func waitForStreamText(t *testing.T, c *Child, want string) {
|
||||||
|
t.Helper()
|
||||||
|
deadline := time.Now().Add(5 * time.Second)
|
||||||
|
for time.Now().Before(deadline) {
|
||||||
|
b, _ := c.StreamRead(0)
|
||||||
|
if strings.Contains(string(b), want) {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
time.Sleep(20 * time.Millisecond)
|
||||||
|
}
|
||||||
|
t.Fatalf("child %s never wrote %q", c.ID, want)
|
||||||
|
}
|
||||||
|
|
||||||
func waitUntilLive(t *testing.T, c *Child) {
|
func waitUntilLive(t *testing.T, c *Child) {
|
||||||
t.Helper()
|
t.Helper()
|
||||||
deadline := time.Now().Add(5 * time.Second)
|
deadline := time.Now().Add(5 * time.Second)
|
||||||
|
|||||||
@@ -331,7 +331,7 @@ func (st *uiState) drawSidebar() {
|
|||||||
write(prefix + openStyle + nameCell + styleReset + suffix)
|
write(prefix + openStyle + nameCell + styleReset + suffix)
|
||||||
}
|
}
|
||||||
|
|
||||||
if summary := st.activeSummaryText(width - 4); summary != "" && row+2 <= maxRow {
|
if summary := st.activeSummaryRaw(); summary != "" && row+2 <= maxRow {
|
||||||
write("")
|
write("")
|
||||||
for _, line := range wrapSidebarSummary(summary, width-4) {
|
for _, line := range wrapSidebarSummary(summary, width-4) {
|
||||||
if row > maxRow {
|
if row > maxRow {
|
||||||
@@ -417,7 +417,13 @@ func wrapSidebarSummary(s string, width int) []string {
|
|||||||
out = append(out, cur)
|
out = append(out, cur)
|
||||||
cur = ""
|
cur = ""
|
||||||
}
|
}
|
||||||
out = append(out, clipRunes(word, width-1)+"…")
|
for visibleLen(word) > width {
|
||||||
|
out = append(out, clipRunes(word, width))
|
||||||
|
word = string([]rune(word)[width:])
|
||||||
|
}
|
||||||
|
if word != "" {
|
||||||
|
cur = word
|
||||||
|
}
|
||||||
continue
|
continue
|
||||||
}
|
}
|
||||||
if cur == "" {
|
if cur == "" {
|
||||||
|
|||||||
@@ -404,7 +404,7 @@ func runSummarizerCommand(ctx context.Context, cfg autoSummarySettings, projectD
|
|||||||
case "claude":
|
case "claude":
|
||||||
cmd = exec.CommandContext(ctx, "claude", "--print", "--model", model, prompt)
|
cmd = exec.CommandContext(ctx, "claude", "--print", "--model", model, prompt)
|
||||||
default:
|
default:
|
||||||
cmd = exec.CommandContext(ctx, "codex", "exec", "--ephemeral", "--skip-git-repo-check", "--sandbox", "read-only", "--ask-for-approval", "never", "--model", model, "-")
|
cmd = exec.CommandContext(ctx, "codex", "exec", "--ephemeral", "--skip-git-repo-check", "--sandbox", "read-only", "--model", model, "-")
|
||||||
cmd.Stdin = strings.NewReader(prompt)
|
cmd.Stdin = strings.NewReader(prompt)
|
||||||
}
|
}
|
||||||
cmd.Dir = projectDir
|
cmd.Dir = projectDir
|
||||||
|
|||||||
@@ -42,8 +42,48 @@ func TestWrapSidebarSummaryKeepsWordBoundaries(t *testing.T) {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
long := wrapSidebarSummary("supercalifragilistic short", 8)
|
long := wrapSidebarSummary("supercalifragilistic short", 8)
|
||||||
if len(long) == 0 || !strings.HasSuffix(long[0], "…") {
|
if len(long) == 0 || strings.Contains(strings.Join(long, ""), "…") {
|
||||||
t.Fatalf("long word should clip with ellipsis: %#v", long)
|
t.Fatalf("long word should wrap without ellipsis: %#v", long)
|
||||||
|
}
|
||||||
|
for _, line := range long {
|
||||||
|
if visibleLen(line) > 8 {
|
||||||
|
t.Fatalf("line %q exceeds width", line)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestSummaryTextForSelectsChildAndClips(t *testing.T) {
|
||||||
|
sess := NewSession(t.TempDir(), "test")
|
||||||
|
cfg := defaultSettings()
|
||||||
|
st := &uiState{
|
||||||
|
sess: sess,
|
||||||
|
settings: cfg,
|
||||||
|
summaries: newSummaryManager(sess, t.TempDir(), preset.Set{}, func() autoSummarySettings {
|
||||||
|
return cfg.AutoSummary.clone()
|
||||||
|
}, nil, nil),
|
||||||
|
}
|
||||||
|
st.summaries.mu.Lock()
|
||||||
|
st.summaries.entries["a1"] = &summaryEntry{state: summaryState{Text: " alpha summary "}}
|
||||||
|
st.summaries.entries["a2"] = &summaryEntry{state: summaryState{Text: "beta summary"}}
|
||||||
|
st.summaries.entries["empty"] = &summaryEntry{state: summaryState{Text: " "}}
|
||||||
|
st.summaries.entries["long"] = &summaryEntry{state: summaryState{Text: "abcdefghijklmnopqrstuvwxyz"}}
|
||||||
|
st.summaries.mu.Unlock()
|
||||||
|
|
||||||
|
if got := st.summaryTextFor("a2", 20); got != "beta summary" {
|
||||||
|
t.Fatalf("summaryTextFor(a2) = %q, want beta summary", got)
|
||||||
|
}
|
||||||
|
if got := st.summaryTextFor("empty", 20); got != "" {
|
||||||
|
t.Fatalf("summaryTextFor(empty) = %q, want empty", got)
|
||||||
|
}
|
||||||
|
if got := st.summaryTextFor("long", 8); got != "abcdefg…" {
|
||||||
|
t.Fatalf("summaryTextFor(long) = %q, want abcdefg…", got)
|
||||||
|
}
|
||||||
|
|
||||||
|
st.settingsMu.Lock()
|
||||||
|
st.settings.AutoSummary.Enabled = false
|
||||||
|
st.settingsMu.Unlock()
|
||||||
|
if got := st.summaryTextFor("a1", 20); got != "" {
|
||||||
|
t.Fatalf("summaryTextFor disabled = %q, want empty", got)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -59,12 +59,14 @@ func (st *uiState) drawTabBar() {
|
|||||||
newHintW := utf8.RuneCountInString(newHint) + 2 // " + new " framing
|
newHintW := utf8.RuneCountInString(newHint) + 2 // " + new " framing
|
||||||
|
|
||||||
type tabRect struct {
|
type tabRect struct {
|
||||||
|
childID string
|
||||||
startCol int
|
startCol int
|
||||||
width int
|
width int
|
||||||
label string
|
label string
|
||||||
|
glyph string
|
||||||
|
glyphStyle string
|
||||||
active bool
|
active bool
|
||||||
}
|
}
|
||||||
|
|
||||||
// Reserve space at the right edge for "+ new". If there are too
|
// Reserve space at the right edge for "+ new". If there are too
|
||||||
// many tabs to fit even at minTabWidth, drop tabs from the right
|
// many tabs to fit even at minTabWidth, drop tabs from the right
|
||||||
// until they do. The current focus stays visible.
|
// until they do. The current focus stays visible.
|
||||||
@@ -114,9 +116,16 @@ func (st *uiState) drawTabBar() {
|
|||||||
if i < extra {
|
if i < extra {
|
||||||
w++
|
w++
|
||||||
}
|
}
|
||||||
|
active := c.ID == focus
|
||||||
|
glyph, glyphStyle := tabIdleGlyph(c.IdleState(), active)
|
||||||
label := c.DisplayName()
|
label := c.DisplayName()
|
||||||
labelW := utf8.RuneCountInString(label)
|
labelW := utf8.RuneCountInString(label)
|
||||||
maxLabelW := w - 2 // one pad on each side
|
// Reserve room for the glyph + its trailing space when present
|
||||||
|
// (1 + 1 runes), on top of the one-cell pad on each side.
|
||||||
|
maxLabelW := w - 2
|
||||||
|
if glyph != "" {
|
||||||
|
maxLabelW -= 2
|
||||||
|
}
|
||||||
if maxLabelW < 1 {
|
if maxLabelW < 1 {
|
||||||
maxLabelW = 1
|
maxLabelW = 1
|
||||||
}
|
}
|
||||||
@@ -129,10 +138,13 @@ func (st *uiState) drawTabBar() {
|
|||||||
labelW = utf8.RuneCountInString(label)
|
labelW = utf8.RuneCountInString(label)
|
||||||
}
|
}
|
||||||
tabs = append(tabs, tabRect{
|
tabs = append(tabs, tabRect{
|
||||||
|
childID: c.ID,
|
||||||
startCol: col,
|
startCol: col,
|
||||||
width: w,
|
width: w,
|
||||||
label: label,
|
label: label,
|
||||||
active: c.ID == focus,
|
glyph: glyph,
|
||||||
|
glyphStyle: glyphStyle,
|
||||||
|
active: active,
|
||||||
})
|
})
|
||||||
col += w
|
col += w
|
||||||
}
|
}
|
||||||
@@ -151,23 +163,37 @@ func (st *uiState) drawTabBar() {
|
|||||||
fmt.Fprintf(&b, "\x1b[3;1H\x1b[%dX", width)
|
fmt.Fprintf(&b, "\x1b[3;1H\x1b[%dX", width)
|
||||||
|
|
||||||
for _, t := range tabs {
|
for _, t := range tabs {
|
||||||
// Row 1: centre-ish label inside the tab cell.
|
// Row 1: centre-ish glyph+label inside the tab cell.
|
||||||
labelW := utf8.RuneCountInString(t.label)
|
labelW := utf8.RuneCountInString(t.label)
|
||||||
leftPad := (t.width - labelW) / 2
|
visibleW := labelW
|
||||||
|
if t.glyph != "" {
|
||||||
|
visibleW += 2 // glyph + separator space
|
||||||
|
}
|
||||||
|
leftPad := (t.width - visibleW) / 2
|
||||||
if leftPad < 1 {
|
if leftPad < 1 {
|
||||||
leftPad = 1
|
leftPad = 1
|
||||||
}
|
}
|
||||||
rightPad := t.width - labelW - leftPad
|
rightPad := t.width - visibleW - leftPad
|
||||||
if rightPad < 0 {
|
if rightPad < 0 {
|
||||||
rightPad = 0
|
rightPad = 0
|
||||||
}
|
}
|
||||||
fmt.Fprintf(&b, "\x1b[1;%dH", t.startCol)
|
cellStyle := styleHint
|
||||||
if t.active {
|
if t.active {
|
||||||
b.WriteString(styleActive)
|
cellStyle = styleActive
|
||||||
} else {
|
|
||||||
b.WriteString(styleHint)
|
|
||||||
}
|
}
|
||||||
|
fmt.Fprintf(&b, "\x1b[1;%dH", t.startCol)
|
||||||
|
b.WriteString(cellStyle)
|
||||||
b.WriteString(strings.Repeat(" ", leftPad))
|
b.WriteString(strings.Repeat(" ", leftPad))
|
||||||
|
if t.glyph != "" {
|
||||||
|
// Glyph uses its own colour so error/permission states pop
|
||||||
|
// regardless of tab focus, matching the sidebar's vocabulary.
|
||||||
|
b.WriteString(styleReset)
|
||||||
|
b.WriteString(t.glyphStyle)
|
||||||
|
b.WriteString(t.glyph)
|
||||||
|
b.WriteString(styleReset)
|
||||||
|
b.WriteString(cellStyle)
|
||||||
|
b.WriteString(" ")
|
||||||
|
}
|
||||||
b.WriteString(t.label)
|
b.WriteString(t.label)
|
||||||
b.WriteString(strings.Repeat(" ", rightPad))
|
b.WriteString(strings.Repeat(" ", rightPad))
|
||||||
b.WriteString(styleReset)
|
b.WriteString(styleReset)
|
||||||
@@ -195,8 +221,11 @@ func (st *uiState) drawTabBar() {
|
|||||||
hintCol, styleBorder, strings.Repeat("─", newHintW), styleReset)
|
hintCol, styleBorder, strings.Repeat("─", newHintW), styleReset)
|
||||||
}
|
}
|
||||||
|
|
||||||
if summary := st.activeSummaryText(width - 2); summary != "" {
|
for _, tab := range tabs {
|
||||||
fmt.Fprintf(&b, "\x1b[2;1H %s%s%s", styleDim, summary, styleReset)
|
summaryWidth := tab.width - 2
|
||||||
|
if summary := st.summaryTextFor(tab.childID, summaryWidth); summary != "" {
|
||||||
|
fmt.Fprintf(&b, "\x1b[2;%dH %s%s%s", tab.startCol, styleDim, summary, styleReset)
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
frame := b.String()
|
frame := b.String()
|
||||||
@@ -218,3 +247,29 @@ func (st *uiState) drawTabBar() {
|
|||||||
defer st.outMu.Unlock()
|
defer st.outMu.Unlock()
|
||||||
fmt.Fprintf(os.Stdout, "\x1b7%s\x1b8", frame)
|
fmt.Fprintf(os.Stdout, "\x1b7%s\x1b8", frame)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// tabIdleGlyph returns the one-rune state indicator (and its SGR style)
|
||||||
|
// to render before a tab's label. Mirrors the sidebar's vocabulary so
|
||||||
|
// users learn the symbols in one place: ✕ error, ? permission, ◐
|
||||||
|
// thinking, ○ idle, ● working. Returns ("", "") for StateUnknown so the
|
||||||
|
// first frame after spawn doesn't show a misleading badge.
|
||||||
|
func tabIdleGlyph(state IdleState, active bool) (string, string) {
|
||||||
|
base := styleHint
|
||||||
|
if active {
|
||||||
|
base = styleAccent
|
||||||
|
}
|
||||||
|
switch state {
|
||||||
|
case StateError:
|
||||||
|
return "✕", styleError
|
||||||
|
case StatePermission:
|
||||||
|
return "?", styleAccent
|
||||||
|
case StateThinking:
|
||||||
|
return "◐", base
|
||||||
|
case StateIdle:
|
||||||
|
return "○", base
|
||||||
|
case StateWorking:
|
||||||
|
return "●", base
|
||||||
|
default:
|
||||||
|
return "", ""
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|||||||
@@ -58,6 +58,7 @@ type timerManager struct {
|
|||||||
mu sync.Mutex
|
mu sync.Mutex
|
||||||
nextID int
|
nextID int
|
||||||
timers map[string]*pendingTimer
|
timers map[string]*pendingTimer
|
||||||
|
changes chan struct{}
|
||||||
|
|
||||||
// fireFn is the callback used to deliver the body to the owning
|
// fireFn is the callback used to deliver the body to the owning
|
||||||
// process. Decoupled so tests can substitute a recorder. Defaults
|
// process. Decoupled so tests can substitute a recorder. Defaults
|
||||||
@@ -69,11 +70,23 @@ func newTimerManager(sess *Session) *timerManager {
|
|||||||
m := &timerManager{
|
m := &timerManager{
|
||||||
sess: sess,
|
sess: sess,
|
||||||
timers: make(map[string]*pendingTimer),
|
timers: make(map[string]*pendingTimer),
|
||||||
|
changes: make(chan struct{}, 1),
|
||||||
}
|
}
|
||||||
m.fireFn = defaultFireFn
|
m.fireFn = defaultFireFn
|
||||||
return m
|
return m
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func (m *timerManager) changeEvents() <-chan struct{} {
|
||||||
|
return m.changes
|
||||||
|
}
|
||||||
|
|
||||||
|
func (m *timerManager) notifyChanged() {
|
||||||
|
select {
|
||||||
|
case m.changes <- struct{}{}:
|
||||||
|
default:
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
func defaultFireFn(owner *Child, body, label string) {
|
func defaultFireFn(owner *Child, body, label string) {
|
||||||
if owner == nil || !owner.IsLive() {
|
if owner == nil || !owner.IsLive() {
|
||||||
return
|
return
|
||||||
@@ -121,6 +134,7 @@ func (m *timerManager) TimerSet(ownerID string, body, label string, seconds floa
|
|||||||
m.timers[id] = t
|
m.timers[id] = t
|
||||||
m.mu.Unlock()
|
m.mu.Unlock()
|
||||||
t.rt = time.AfterFunc(d, func() { m.fireDelay(id) })
|
t.rt = time.AfterFunc(d, func() { m.fireDelay(id) })
|
||||||
|
m.notifyChanged()
|
||||||
return id, nil
|
return id, nil
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -136,6 +150,7 @@ func (m *timerManager) fireDelay(id string) {
|
|||||||
body, label := t.body, t.label
|
body, label := t.body, t.label
|
||||||
delete(m.timers, id)
|
delete(m.timers, id)
|
||||||
m.mu.Unlock()
|
m.mu.Unlock()
|
||||||
|
m.notifyChanged()
|
||||||
m.fireFn(owner, body, label)
|
m.fireFn(owner, body, label)
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -214,6 +229,7 @@ func (m *timerManager) registerIdleTimer(kind pendingTimerKind, ownerID, body, l
|
|||||||
}
|
}
|
||||||
m.timers[id] = t
|
m.timers[id] = t
|
||||||
m.mu.Unlock()
|
m.mu.Unlock()
|
||||||
|
m.notifyChanged()
|
||||||
resp.ID = id
|
resp.ID = id
|
||||||
resp.Status = "pending"
|
resp.Status = "pending"
|
||||||
return resp, nil
|
return resp, nil
|
||||||
@@ -231,6 +247,7 @@ func (m *timerManager) fireIdleMaxWait(id string) {
|
|||||||
body, label := t.body, t.label
|
body, label := t.body, t.label
|
||||||
delete(m.timers, id)
|
delete(m.timers, id)
|
||||||
m.mu.Unlock()
|
m.mu.Unlock()
|
||||||
|
m.notifyChanged()
|
||||||
m.fireFn(owner, body, label)
|
m.fireFn(owner, body, label)
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -291,11 +308,79 @@ func (m *timerManager) onChildStateChanged(childID string, state IdleState) {
|
|||||||
delete(m.timers, id)
|
delete(m.timers, id)
|
||||||
}
|
}
|
||||||
m.mu.Unlock()
|
m.mu.Unlock()
|
||||||
|
if len(firedIDs) > 0 {
|
||||||
|
m.notifyChanged()
|
||||||
|
}
|
||||||
for _, f := range fires {
|
for _, f := range fires {
|
||||||
m.fireFn(f.owner, f.body, f.label)
|
m.fireFn(f.owner, f.body, f.label)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// onChildClosed drops pending timer references to childID. Called
|
||||||
|
// from Session.Close (and the terminal-corpse cleanup in reapChild)
|
||||||
|
// via the session listener bus — a deliberate signal from the host
|
||||||
|
// that childID is gone and the parent is not waiting on it anymore.
|
||||||
|
//
|
||||||
|
// Semantics:
|
||||||
|
// - timers owned by childID are cancelled and deleted: their owner
|
||||||
|
// is gone, so even if defaultFireFn's IsLive guard would no-op
|
||||||
|
// the delivery, the entry has no business surviving a close.
|
||||||
|
// - timers watching childID have childID pruned from t.watched
|
||||||
|
// (and t.idleBaseline). If t.watched becomes empty the timer is
|
||||||
|
// cancelled and deleted; we deliberately do NOT synthesise a
|
||||||
|
// fire here. The parent already received any legitimate idle
|
||||||
|
// transition before close_process — see allWatchedIdleLocked's
|
||||||
|
// "treat as satisfied" comment, which only applies to a
|
||||||
|
// concurrent re-evaluation, not to this explicit-removal hook.
|
||||||
|
//
|
||||||
|
// The natural-exit path (reapChild → emitExit for agent/command
|
||||||
|
// kinds) is NOT routed through here: the classifier emits a final
|
||||||
|
// idle transition on exit, which fires and deletes any watching
|
||||||
|
// timers exactly once. Cancelling on exit would swallow that
|
||||||
|
// legitimate fire and leave the parent never notified.
|
||||||
|
func (m *timerManager) onChildClosed(childID string) {
|
||||||
|
m.mu.Lock()
|
||||||
|
changed := false
|
||||||
|
for id, t := range m.timers {
|
||||||
|
if t.ownerID == childID {
|
||||||
|
if t.rt != nil {
|
||||||
|
t.rt.Stop()
|
||||||
|
t.rt = nil
|
||||||
|
}
|
||||||
|
t.status = timerStatusCanceled
|
||||||
|
delete(m.timers, id)
|
||||||
|
changed = true
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
if !contains(t.watched, childID) {
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
pruned := t.watched[:0]
|
||||||
|
for _, w := range t.watched {
|
||||||
|
if w != childID {
|
||||||
|
pruned = append(pruned, w)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
t.watched = pruned
|
||||||
|
if t.idleBaseline != nil {
|
||||||
|
delete(t.idleBaseline, childID)
|
||||||
|
}
|
||||||
|
changed = true
|
||||||
|
if len(t.watched) == 0 {
|
||||||
|
if t.rt != nil {
|
||||||
|
t.rt.Stop()
|
||||||
|
t.rt = nil
|
||||||
|
}
|
||||||
|
t.status = timerStatusCanceled
|
||||||
|
delete(m.timers, id)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
m.mu.Unlock()
|
||||||
|
if changed {
|
||||||
|
m.notifyChanged()
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
// allWatchedIdleLocked reports whether every watched child is now
|
// allWatchedIdleLocked reports whether every watched child is now
|
||||||
// idle. Called with m.mu held — uses live Child.IdleState() under the
|
// idle. Called with m.mu held — uses live Child.IdleState() under the
|
||||||
// child's own atomic, not under m.mu.
|
// child's own atomic, not under m.mu.
|
||||||
@@ -315,19 +400,21 @@ func (m *timerManager) allWatchedIdleLocked(t *pendingTimer) bool {
|
|||||||
// TimerCancel removes a pending or paused timer owned by ownerID.
|
// TimerCancel removes a pending or paused timer owned by ownerID.
|
||||||
func (m *timerManager) TimerCancel(ownerID, id string) error {
|
func (m *timerManager) TimerCancel(ownerID, id string) error {
|
||||||
m.mu.Lock()
|
m.mu.Lock()
|
||||||
defer m.mu.Unlock()
|
|
||||||
t, ok := m.timers[id]
|
t, ok := m.timers[id]
|
||||||
if !ok {
|
if !ok {
|
||||||
|
m.mu.Unlock()
|
||||||
return mcp.Errorf(mcp.ErrorKindNotFound, "no such timer %q", id)
|
return mcp.Errorf(mcp.ErrorKindNotFound, "no such timer %q", id)
|
||||||
}
|
}
|
||||||
// Empty ownerID = top-level orchestrator caller (e.g. a non-agent
|
// Empty ownerID = top-level orchestrator caller (e.g. a non-agent
|
||||||
// MCP client); allow it to manage every timer in the session.
|
// MCP client); allow it to manage every timer in the session.
|
||||||
// Otherwise the caller's own id must match the timer's owner.
|
// Otherwise the caller's own id must match the timer's owner.
|
||||||
if ownerID != "" && t.ownerID != ownerID {
|
if ownerID != "" && t.ownerID != ownerID {
|
||||||
|
m.mu.Unlock()
|
||||||
return mcp.Errorf(mcp.ErrorKindRoleForbidden, "timer %q is not owned by caller", id)
|
return mcp.Errorf(mcp.ErrorKindRoleForbidden, "timer %q is not owned by caller", id)
|
||||||
}
|
}
|
||||||
if t.status == timerStatusFired || t.status == timerStatusCanceled {
|
if t.status == timerStatusFired || t.status == timerStatusCanceled {
|
||||||
// Cancelling a fired/cancelled timer is idempotent.
|
// Cancelling a fired/cancelled timer is idempotent.
|
||||||
|
m.mu.Unlock()
|
||||||
return nil
|
return nil
|
||||||
}
|
}
|
||||||
if t.rt != nil {
|
if t.rt != nil {
|
||||||
@@ -336,6 +423,8 @@ func (m *timerManager) TimerCancel(ownerID, id string) error {
|
|||||||
}
|
}
|
||||||
t.status = timerStatusCanceled
|
t.status = timerStatusCanceled
|
||||||
delete(m.timers, id)
|
delete(m.timers, id)
|
||||||
|
m.mu.Unlock()
|
||||||
|
m.notifyChanged()
|
||||||
return nil
|
return nil
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -343,18 +432,20 @@ func (m *timerManager) TimerCancel(ownerID, id string) error {
|
|||||||
// keeps the timer in the registry.
|
// keeps the timer in the registry.
|
||||||
func (m *timerManager) TimerPause(ownerID, id string) error {
|
func (m *timerManager) TimerPause(ownerID, id string) error {
|
||||||
m.mu.Lock()
|
m.mu.Lock()
|
||||||
defer m.mu.Unlock()
|
|
||||||
t, ok := m.timers[id]
|
t, ok := m.timers[id]
|
||||||
if !ok {
|
if !ok {
|
||||||
|
m.mu.Unlock()
|
||||||
return mcp.Errorf(mcp.ErrorKindNotFound, "no such timer %q", id)
|
return mcp.Errorf(mcp.ErrorKindNotFound, "no such timer %q", id)
|
||||||
}
|
}
|
||||||
// Empty ownerID = top-level orchestrator caller (e.g. a non-agent
|
// Empty ownerID = top-level orchestrator caller (e.g. a non-agent
|
||||||
// MCP client); allow it to manage every timer in the session.
|
// MCP client); allow it to manage every timer in the session.
|
||||||
// Otherwise the caller's own id must match the timer's owner.
|
// Otherwise the caller's own id must match the timer's owner.
|
||||||
if ownerID != "" && t.ownerID != ownerID {
|
if ownerID != "" && t.ownerID != ownerID {
|
||||||
|
m.mu.Unlock()
|
||||||
return mcp.Errorf(mcp.ErrorKindRoleForbidden, "timer %q is not owned by caller", id)
|
return mcp.Errorf(mcp.ErrorKindRoleForbidden, "timer %q is not owned by caller", id)
|
||||||
}
|
}
|
||||||
if t.status != timerStatusPending {
|
if t.status != timerStatusPending {
|
||||||
|
m.mu.Unlock()
|
||||||
return mcp.Errorf(mcp.ErrorKindInvalidArgs, "timer %q is not pending", id)
|
return mcp.Errorf(mcp.ErrorKindInvalidArgs, "timer %q is not pending", id)
|
||||||
}
|
}
|
||||||
if t.rt != nil {
|
if t.rt != nil {
|
||||||
@@ -370,6 +461,8 @@ func (m *timerManager) TimerPause(ownerID, id string) error {
|
|||||||
t.pausedWasMaxWait = t.kind != timerKindDelay
|
t.pausedWasMaxWait = t.kind != timerKindDelay
|
||||||
}
|
}
|
||||||
t.status = timerStatusPaused
|
t.status = timerStatusPaused
|
||||||
|
m.mu.Unlock()
|
||||||
|
m.notifyChanged()
|
||||||
return nil
|
return nil
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -448,6 +541,7 @@ func (m *timerManager) TimerResume(ownerID, id string) error {
|
|||||||
delete(m.timers, id)
|
delete(m.timers, id)
|
||||||
}
|
}
|
||||||
m.mu.Unlock()
|
m.mu.Unlock()
|
||||||
|
m.notifyChanged()
|
||||||
if fireNow {
|
if fireNow {
|
||||||
m.fireFn(owner, body, label)
|
m.fireFn(owner, body, label)
|
||||||
}
|
}
|
||||||
@@ -528,6 +622,56 @@ func (m *timerManager) activeForChild(id string) *mcp.TimerInfo {
|
|||||||
return &info
|
return &info
|
||||||
}
|
}
|
||||||
|
|
||||||
|
const (
|
||||||
|
timerSidebarMinRefresh = 50 * time.Millisecond
|
||||||
|
timerSidebarSubsecondRefresh = 100 * time.Millisecond
|
||||||
|
)
|
||||||
|
|
||||||
|
func nextTimerSidebarLabelChange(d time.Duration) time.Duration {
|
||||||
|
if d <= 0 {
|
||||||
|
return 0
|
||||||
|
}
|
||||||
|
if d < time.Second {
|
||||||
|
if d < timerSidebarSubsecondRefresh {
|
||||||
|
return d
|
||||||
|
}
|
||||||
|
return timerSidebarSubsecondRefresh
|
||||||
|
}
|
||||||
|
|
||||||
|
step := time.Second
|
||||||
|
if d >= time.Hour {
|
||||||
|
step = time.Hour
|
||||||
|
} else if d >= time.Minute {
|
||||||
|
step = time.Minute
|
||||||
|
}
|
||||||
|
wait := d % step
|
||||||
|
if wait <= 0 || wait < timerSidebarMinRefresh {
|
||||||
|
return timerSidebarMinRefresh
|
||||||
|
}
|
||||||
|
return wait
|
||||||
|
}
|
||||||
|
|
||||||
|
func (m *timerManager) nextSidebarRefreshAfter(now time.Time) (time.Duration, bool) {
|
||||||
|
m.mu.Lock()
|
||||||
|
defer m.mu.Unlock()
|
||||||
|
var best time.Duration
|
||||||
|
found := false
|
||||||
|
for _, t := range m.timers {
|
||||||
|
if t.status != timerStatusPending || t.firesAt.IsZero() {
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
wait := nextTimerSidebarLabelChange(t.firesAt.Sub(now))
|
||||||
|
if wait <= 0 {
|
||||||
|
wait = timerSidebarMinRefresh
|
||||||
|
}
|
||||||
|
if !found || wait < best {
|
||||||
|
best = wait
|
||||||
|
found = true
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return best, found
|
||||||
|
}
|
||||||
|
|
||||||
func isIdleState(s IdleState) bool {
|
func isIdleState(s IdleState) bool {
|
||||||
return s == StateIdle
|
return s == StateIdle
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -65,6 +65,93 @@ func newTestManager(t *testing.T) (*Session, *timerManager, *recorderFire) {
|
|||||||
return sess, mgr, rec
|
return sess, mgr, rec
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func waitTimerChange(t *testing.T, mgr *timerManager) {
|
||||||
|
t.Helper()
|
||||||
|
select {
|
||||||
|
case <-mgr.changeEvents():
|
||||||
|
case <-time.After(time.Second):
|
||||||
|
t.Fatal("timed out waiting for timer change signal")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestNextTimerSidebarLabelChange(t *testing.T) {
|
||||||
|
tests := []struct {
|
||||||
|
name string
|
||||||
|
d time.Duration
|
||||||
|
want time.Duration
|
||||||
|
}{
|
||||||
|
{name: "minutes", d: 2*time.Minute + 10*time.Second, want: 10 * time.Second},
|
||||||
|
{name: "minute_to_seconds", d: time.Minute + 500*time.Millisecond, want: 500 * time.Millisecond},
|
||||||
|
{name: "seconds", d: 59*time.Second + 500*time.Millisecond, want: 500 * time.Millisecond},
|
||||||
|
{name: "subsecond", d: 500 * time.Millisecond, want: timerSidebarSubsecondRefresh},
|
||||||
|
{name: "nearly_done", d: 30 * time.Millisecond, want: 30 * time.Millisecond},
|
||||||
|
}
|
||||||
|
for _, tt := range tests {
|
||||||
|
t.Run(tt.name, func(t *testing.T) {
|
||||||
|
if got := nextTimerSidebarLabelChange(tt.d); got != tt.want {
|
||||||
|
t.Fatalf("nextTimerSidebarLabelChange(%s) = %s, want %s", tt.d, got, tt.want)
|
||||||
|
}
|
||||||
|
})
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestTimerSidebarRefreshAfterUsesSoonestActiveBoundary(t *testing.T) {
|
||||||
|
_, mgr, _ := newTestManager(t)
|
||||||
|
now := time.Unix(123, 0)
|
||||||
|
mgr.mu.Lock()
|
||||||
|
mgr.timers["slow"] = &pendingTimer{
|
||||||
|
id: "slow",
|
||||||
|
status: timerStatusPending,
|
||||||
|
firesAt: now.Add(2*time.Minute + 10*time.Second),
|
||||||
|
}
|
||||||
|
mgr.timers["fast"] = &pendingTimer{
|
||||||
|
id: "fast",
|
||||||
|
status: timerStatusPending,
|
||||||
|
firesAt: now.Add(59*time.Second + 500*time.Millisecond),
|
||||||
|
}
|
||||||
|
mgr.timers["paused"] = &pendingTimer{
|
||||||
|
id: "paused",
|
||||||
|
status: timerStatusPaused,
|
||||||
|
firesAt: now.Add(100 * time.Millisecond),
|
||||||
|
}
|
||||||
|
mgr.mu.Unlock()
|
||||||
|
|
||||||
|
got, ok := mgr.nextSidebarRefreshAfter(now)
|
||||||
|
if !ok {
|
||||||
|
t.Fatal("nextSidebarRefreshAfter did not find active timers")
|
||||||
|
}
|
||||||
|
if got != 500*time.Millisecond {
|
||||||
|
t.Fatalf("nextSidebarRefreshAfter = %s, want 500ms", got)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestTimerManagerSignalsChangesForSidebar(t *testing.T) {
|
||||||
|
sess, mgr, _ := newTestManager(t)
|
||||||
|
owner := fakeChild("p_owner")
|
||||||
|
addChild(sess, owner)
|
||||||
|
|
||||||
|
id, err := mgr.TimerSet("p_owner", "x", "", 60)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("TimerSet: %v", err)
|
||||||
|
}
|
||||||
|
waitTimerChange(t, mgr)
|
||||||
|
|
||||||
|
if err := mgr.TimerPause("p_owner", id); err != nil {
|
||||||
|
t.Fatalf("TimerPause: %v", err)
|
||||||
|
}
|
||||||
|
waitTimerChange(t, mgr)
|
||||||
|
|
||||||
|
if err := mgr.TimerResume("p_owner", id); err != nil {
|
||||||
|
t.Fatalf("TimerResume: %v", err)
|
||||||
|
}
|
||||||
|
waitTimerChange(t, mgr)
|
||||||
|
|
||||||
|
if err := mgr.TimerCancel("p_owner", id); err != nil {
|
||||||
|
t.Fatalf("TimerCancel: %v", err)
|
||||||
|
}
|
||||||
|
waitTimerChange(t, mgr)
|
||||||
|
}
|
||||||
|
|
||||||
func TestTimerSetDelivers(t *testing.T) {
|
func TestTimerSetDelivers(t *testing.T) {
|
||||||
sess, mgr, rec := newTestManager(t)
|
sess, mgr, rec := newTestManager(t)
|
||||||
c := fakeChild("p_owner")
|
c := fakeChild("p_owner")
|
||||||
@@ -411,3 +498,178 @@ func TestTimerRecordsRemovedOnIdleFire(t *testing.T) {
|
|||||||
t.Fatalf("fired idle timer %s was not removed from registry", resp.ID)
|
t.Fatalf("fired idle timer %s was not removed from registry", resp.ID)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// TestTimerCloseChildPrunesWatched covers the happy partial-prune
|
||||||
|
// case: an idle_any timer watches two children, one is closed, the
|
||||||
|
// timer stays pending and the remaining child can still satisfy it.
|
||||||
|
func TestTimerCloseChildPrunesWatched(t *testing.T) {
|
||||||
|
sess, mgr, rec := newTestManager(t)
|
||||||
|
owner := fakeChild("p_owner")
|
||||||
|
a := fakeChild("p_a")
|
||||||
|
b := fakeChild("p_b")
|
||||||
|
addChild(sess, owner)
|
||||||
|
addChild(sess, a)
|
||||||
|
addChild(sess, b)
|
||||||
|
working := StateWorking
|
||||||
|
a.idleState.Store(&working)
|
||||||
|
b.idleState.Store(&working)
|
||||||
|
|
||||||
|
resp, err := mgr.TimerFireWhenIdleAny("p_owner", "one done", "", []string{"p_a", "p_b"}, 0)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("TimerFireWhenIdleAny: %v", err)
|
||||||
|
}
|
||||||
|
|
||||||
|
mgr.onChildClosed("p_a")
|
||||||
|
|
||||||
|
mgr.mu.Lock()
|
||||||
|
t1, ok := mgr.timers[resp.ID]
|
||||||
|
if !ok {
|
||||||
|
mgr.mu.Unlock()
|
||||||
|
t.Fatalf("timer was removed but still has live watched")
|
||||||
|
}
|
||||||
|
watched := append([]string(nil), t1.watched...)
|
||||||
|
mgr.mu.Unlock()
|
||||||
|
if len(watched) != 1 || watched[0] != "p_b" {
|
||||||
|
t.Fatalf("watched after close: %v, want [p_b]", watched)
|
||||||
|
}
|
||||||
|
if got := rec.snapshot(); len(got) != 0 {
|
||||||
|
t.Fatalf("close synthesised a fire: %+v", got)
|
||||||
|
}
|
||||||
|
|
||||||
|
// p_b can still satisfy the timer.
|
||||||
|
idle := StateIdle
|
||||||
|
b.idleState.Store(&idle)
|
||||||
|
mgr.onChildStateChanged("p_b", StateIdle)
|
||||||
|
if got := rec.snapshot(); len(got) != 1 || got[0].Body != "one done" {
|
||||||
|
t.Fatalf("post-prune fire: %+v", got)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// TestTimerCloseLastWatchedCancels is the regression for the
|
||||||
|
// reported stale-fire symptom: the only watched child is closed,
|
||||||
|
// so the timer must be cancelled — no synthetic fire, and the
|
||||||
|
// registry entry must be gone so a trailing classifier tick for the
|
||||||
|
// removed child cannot re-deliver later.
|
||||||
|
func TestTimerCloseLastWatchedCancels(t *testing.T) {
|
||||||
|
sess, mgr, rec := newTestManager(t)
|
||||||
|
owner := fakeChild("p_owner")
|
||||||
|
a := fakeChild("p_a")
|
||||||
|
addChild(sess, owner)
|
||||||
|
addChild(sess, a)
|
||||||
|
working := StateWorking
|
||||||
|
a.idleState.Store(&working)
|
||||||
|
|
||||||
|
resp, err := mgr.TimerFireWhenIdleAny("p_owner", "stale body", "", []string{"p_a"}, 0)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("TimerFireWhenIdleAny: %v", err)
|
||||||
|
}
|
||||||
|
|
||||||
|
mgr.onChildClosed("p_a")
|
||||||
|
|
||||||
|
mgr.mu.Lock()
|
||||||
|
_, stillThere := mgr.timers[resp.ID]
|
||||||
|
mgr.mu.Unlock()
|
||||||
|
if stillThere {
|
||||||
|
t.Fatalf("timer with no remaining watched should be removed")
|
||||||
|
}
|
||||||
|
if got := rec.snapshot(); len(got) != 0 {
|
||||||
|
t.Fatalf("close synthesised a fire: %+v", got)
|
||||||
|
}
|
||||||
|
|
||||||
|
// Simulate the trailing classifier tick for the now-closed child —
|
||||||
|
// must not fire.
|
||||||
|
mgr.onChildStateChanged("p_a", StateIdle)
|
||||||
|
if got := rec.snapshot(); len(got) != 0 {
|
||||||
|
t.Fatalf("trailing state change re-fired: %+v", got)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// TestTimerCloseChildIdleAllPartialPrune mirrors the idle_any
|
||||||
|
// partial-prune for idle_all: pruning a watched child shrinks the
|
||||||
|
// list; the remaining child going idle then satisfies the timer.
|
||||||
|
func TestTimerCloseChildIdleAllPartialPrune(t *testing.T) {
|
||||||
|
sess, mgr, rec := newTestManager(t)
|
||||||
|
owner := fakeChild("p_owner")
|
||||||
|
a := fakeChild("p_a")
|
||||||
|
b := fakeChild("p_b")
|
||||||
|
addChild(sess, owner)
|
||||||
|
addChild(sess, a)
|
||||||
|
addChild(sess, b)
|
||||||
|
working := StateWorking
|
||||||
|
a.idleState.Store(&working)
|
||||||
|
b.idleState.Store(&working)
|
||||||
|
|
||||||
|
resp, err := mgr.TimerFireWhenIdleAll("p_owner", "all done", "", []string{"p_a", "p_b"}, 0)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("TimerFireWhenIdleAll: %v", err)
|
||||||
|
}
|
||||||
|
if resp.Status != "pending" {
|
||||||
|
t.Fatalf("status: got %q want pending", resp.Status)
|
||||||
|
}
|
||||||
|
|
||||||
|
mgr.onChildClosed("p_a")
|
||||||
|
|
||||||
|
idle := StateIdle
|
||||||
|
b.idleState.Store(&idle)
|
||||||
|
mgr.onChildStateChanged("p_b", StateIdle)
|
||||||
|
if got := rec.snapshot(); len(got) != 1 || got[0].Body != "all done" {
|
||||||
|
t.Fatalf("idle_all after partial prune: %+v", got)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// TestTimerCloseOwnerCancelsDelay ensures a delay timer is dropped
|
||||||
|
// when its owner is closed: no delivery, registry empty, the
|
||||||
|
// underlying time.Timer is stopped.
|
||||||
|
func TestTimerCloseOwnerCancelsDelay(t *testing.T) {
|
||||||
|
sess, mgr, rec := newTestManager(t)
|
||||||
|
c := fakeChild("p_owner")
|
||||||
|
addChild(sess, c)
|
||||||
|
id, err := mgr.TimerSet("p_owner", "x", "", 0.1)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("TimerSet: %v", err)
|
||||||
|
}
|
||||||
|
|
||||||
|
mgr.onChildClosed("p_owner")
|
||||||
|
|
||||||
|
mgr.mu.Lock()
|
||||||
|
_, stillThere := mgr.timers[id]
|
||||||
|
mgr.mu.Unlock()
|
||||||
|
if stillThere {
|
||||||
|
t.Fatalf("delay timer was not removed when owner closed")
|
||||||
|
}
|
||||||
|
time.Sleep(200 * time.Millisecond) // past the original firesAt
|
||||||
|
if got := rec.snapshot(); len(got) != 0 {
|
||||||
|
t.Fatalf("delay timer fired after owner close: %+v", got)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// TestTimerCloseWatchedSubAgent is the exact shape of the reported
|
||||||
|
// stale-fire bug: orchestrator registers a watcher on a sub-agent,
|
||||||
|
// the sub-agent is closed, and the orchestrator must receive
|
||||||
|
// nothing (no stale body delivered after close_process).
|
||||||
|
func TestTimerCloseWatchedSubAgent(t *testing.T) {
|
||||||
|
sess, mgr, rec := newTestManager(t)
|
||||||
|
parent := fakeChild("p_owner")
|
||||||
|
sub := fakeChild("p_sub")
|
||||||
|
addChild(sess, parent)
|
||||||
|
addChild(sess, sub)
|
||||||
|
working := StateWorking
|
||||||
|
sub.idleState.Store(&working)
|
||||||
|
|
||||||
|
if _, err := mgr.TimerFireWhenIdleAny(
|
||||||
|
"p_owner",
|
||||||
|
"codex-review-591 finished. Read your own pane …",
|
||||||
|
"", []string{"p_sub"}, 0,
|
||||||
|
); err != nil {
|
||||||
|
t.Fatalf("TimerFireWhenIdleAny: %v", err)
|
||||||
|
}
|
||||||
|
|
||||||
|
mgr.onChildClosed("p_sub")
|
||||||
|
|
||||||
|
// Trailing classifier emission for the closed sub-agent must
|
||||||
|
// not deliver anything to the parent.
|
||||||
|
mgr.onChildStateChanged("p_sub", StateIdle)
|
||||||
|
if got := rec.snapshot(); len(got) != 0 {
|
||||||
|
t.Fatalf("stale fire delivered to parent after sub-agent close: %+v", got)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|||||||
361
internal/app/toast.go
Normal file
361
internal/app/toast.go
Normal file
@@ -0,0 +1,361 @@
|
|||||||
|
package app
|
||||||
|
|
||||||
|
import (
|
||||||
|
"os"
|
||||||
|
"strings"
|
||||||
|
"sync"
|
||||||
|
)
|
||||||
|
|
||||||
|
// toastKind classifies a toast for styling and for migrating the
|
||||||
|
// pre-existing flashError / flashTransient / notifyAttention call
|
||||||
|
// sites onto the new stack.
|
||||||
|
type toastKind int
|
||||||
|
|
||||||
|
const (
|
||||||
|
toastInfo toastKind = iota
|
||||||
|
toastError
|
||||||
|
toastAttention
|
||||||
|
)
|
||||||
|
|
||||||
|
// toast is one entry in the host-level notification stack. Toasts
|
||||||
|
// persist until the user dismisses them with Ctrl-N or the
|
||||||
|
// "Clear notifications" palette command — there's no auto-expiry.
|
||||||
|
type toast struct {
|
||||||
|
id uint64
|
||||||
|
kind toastKind
|
||||||
|
text string
|
||||||
|
}
|
||||||
|
|
||||||
|
// toastStackCap caps how many toasts can be visible at once.
|
||||||
|
// Older entries drop off the bottom when a new push would exceed it.
|
||||||
|
const toastStackCap = 5
|
||||||
|
|
||||||
|
// toastBoxMaxWidth bounds the rendered box width so a wide pane
|
||||||
|
// doesn't produce huge toasts. Boxes shrink below this when the pane
|
||||||
|
// is narrow.
|
||||||
|
const toastBoxMaxWidth = 50
|
||||||
|
|
||||||
|
// toastBoxMinWidth is the floor below which we refuse to render —
|
||||||
|
// any narrower and there's not enough room for borders + content.
|
||||||
|
const toastBoxMinWidth = 20
|
||||||
|
|
||||||
|
// toastContentRows is how many lines of message body each toast box
|
||||||
|
// reserves. The dismiss hint lives on the host status strip, so the
|
||||||
|
// box itself is purely the message.
|
||||||
|
const toastContentRows = 3
|
||||||
|
|
||||||
|
// toastStack owns the ordered list of live toasts. Oldest at
|
||||||
|
// index 0, newest (visually topmost) at the end. The stack's own
|
||||||
|
// mutex is intentionally separate from uiState.mu so push / dismiss
|
||||||
|
// can be called from any goroutine without participating in the
|
||||||
|
// host's bigger lock-ordering rules.
|
||||||
|
type toastStack struct {
|
||||||
|
mu sync.Mutex
|
||||||
|
items []toast
|
||||||
|
next uint64
|
||||||
|
}
|
||||||
|
|
||||||
|
func (s *toastStack) push(kind toastKind, text string) {
|
||||||
|
s.mu.Lock()
|
||||||
|
defer s.mu.Unlock()
|
||||||
|
s.next++
|
||||||
|
s.items = append(s.items, toast{id: s.next, kind: kind, text: text})
|
||||||
|
if len(s.items) > toastStackCap {
|
||||||
|
s.items = s.items[len(s.items)-toastStackCap:]
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// dismissTop pops the most recent toast (the one rendered at the
|
||||||
|
// top of the stack). Returns true if something was removed so
|
||||||
|
// callers can decide whether to repaint.
|
||||||
|
func (s *toastStack) dismissTop() bool {
|
||||||
|
s.mu.Lock()
|
||||||
|
defer s.mu.Unlock()
|
||||||
|
if len(s.items) == 0 {
|
||||||
|
return false
|
||||||
|
}
|
||||||
|
s.items = s.items[:len(s.items)-1]
|
||||||
|
return true
|
||||||
|
}
|
||||||
|
|
||||||
|
func (s *toastStack) clear() bool {
|
||||||
|
s.mu.Lock()
|
||||||
|
defer s.mu.Unlock()
|
||||||
|
if len(s.items) == 0 {
|
||||||
|
return false
|
||||||
|
}
|
||||||
|
s.items = s.items[:0]
|
||||||
|
return true
|
||||||
|
}
|
||||||
|
|
||||||
|
func (s *toastStack) snapshot() []toast {
|
||||||
|
s.mu.Lock()
|
||||||
|
defer s.mu.Unlock()
|
||||||
|
if len(s.items) == 0 {
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
out := make([]toast, len(s.items))
|
||||||
|
copy(out, s.items)
|
||||||
|
return out
|
||||||
|
}
|
||||||
|
|
||||||
|
func (s *toastStack) length() int {
|
||||||
|
s.mu.Lock()
|
||||||
|
defer s.mu.Unlock()
|
||||||
|
return len(s.items)
|
||||||
|
}
|
||||||
|
|
||||||
|
// notifyToast is the single entry point that the former flash
|
||||||
|
// helpers now delegate to. It pushes onto the stack and triggers a
|
||||||
|
// repaint of the focused surface so the new toast appears
|
||||||
|
// immediately; the repaint path also re-renders the stack on top.
|
||||||
|
func (st *uiState) notifyToast(kind toastKind, text string) {
|
||||||
|
st.toasts.push(kind, text)
|
||||||
|
st.refreshToastSurface()
|
||||||
|
}
|
||||||
|
|
||||||
|
// refreshToastSurface re-renders whatever surface the toasts are
|
||||||
|
// drawn over (focused child, focused pad, or the empty-state
|
||||||
|
// canvas). Each of those paths calls renderToasts at the end, so
|
||||||
|
// the toast layer is always reapplied on top of a freshly-drawn
|
||||||
|
// pane. Centralised so push / dismiss / clear share one code path.
|
||||||
|
//
|
||||||
|
// The status strip also gains/loses the "Ctrl-N · dismiss" hint as
|
||||||
|
// the stack toggles between empty and non-empty, so we redraw it
|
||||||
|
// here too rather than waiting for the chrome ticker.
|
||||||
|
func (st *uiState) refreshToastSurface() {
|
||||||
|
st.mu.Lock()
|
||||||
|
focusedPad := st.focusedPad
|
||||||
|
focusedID := st.focusedID
|
||||||
|
palOpen := st.palette != nil
|
||||||
|
st.mu.Unlock()
|
||||||
|
if palOpen {
|
||||||
|
// Palette owns the whole screen while it's open; toasts will
|
||||||
|
// repaint via closePalette's restore path.
|
||||||
|
return
|
||||||
|
}
|
||||||
|
switch {
|
||||||
|
case focusedPad != "":
|
||||||
|
st.repaintFocusedPad()
|
||||||
|
case focusedID != "":
|
||||||
|
st.repaintFocused()
|
||||||
|
default:
|
||||||
|
st.renderEmptyState()
|
||||||
|
}
|
||||||
|
st.drawStatusLine()
|
||||||
|
}
|
||||||
|
|
||||||
|
// renderToasts draws the toast stack over the top-right of the
|
||||||
|
// focused pane. Called from repaintFocused / repaintFocusedPad /
|
||||||
|
// renderEmptyState after they finish so toasts always sit on top of
|
||||||
|
// freshly-redrawn pane content. Safe to call when the stack is
|
||||||
|
// empty (no-op).
|
||||||
|
func (st *uiState) renderToasts() {
|
||||||
|
bytes := st.toastOverlayBytes()
|
||||||
|
if len(bytes) == 0 {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
st.outMu.Lock()
|
||||||
|
defer st.outMu.Unlock()
|
||||||
|
_, _ = os.Stdout.Write(bytes)
|
||||||
|
}
|
||||||
|
|
||||||
|
// toastOverlayBytes builds the toast layer as a single byte buffer
|
||||||
|
// without writing to stdout. Returns nil when the stack is empty or
|
||||||
|
// the layout can't accommodate a box. Callers either write it
|
||||||
|
// directly (renderToasts) or stitch it onto the end of another
|
||||||
|
// stdout write so claude/codex/opencode redraws that paint over the
|
||||||
|
// top-right region can't leave the toast half-erased.
|
||||||
|
func (st *uiState) toastOverlayBytes() []byte {
|
||||||
|
items := st.toasts.snapshot()
|
||||||
|
if len(items) == 0 {
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
st.mu.Lock()
|
||||||
|
palOpen := st.palette != nil
|
||||||
|
st.mu.Unlock()
|
||||||
|
if palOpen {
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
layout := st.layoutSnapshot()
|
||||||
|
paneCols := int(layout.childCols())
|
||||||
|
paneRows := int(layout.childRows())
|
||||||
|
if paneCols < toastBoxMinWidth+2 || paneRows < toastContentRows+2 {
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
boxWidth := toastBoxMaxWidth
|
||||||
|
if max := paneCols - 4; max < boxWidth {
|
||||||
|
boxWidth = max
|
||||||
|
}
|
||||||
|
if boxWidth < toastBoxMinWidth {
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
contentWidth := boxWidth - 4 // 2 border cells + 2 inner padding
|
||||||
|
// Reserve two columns for the icon prefix on row 1 so wrapped rows
|
||||||
|
// indent under the body text rather than under the glyph.
|
||||||
|
const iconCols = 2
|
||||||
|
bodyRoom := contentWidth - iconCols
|
||||||
|
if bodyRoom < 1 {
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
|
||||||
|
var b strings.Builder
|
||||||
|
// Wrap the whole overlay in DECSET 2026 (synchronized output)
|
||||||
|
// brackets so terminals that support BSU/ESU buffer the box paint
|
||||||
|
// into a single frame — without this, claude's continuous redraws
|
||||||
|
// and our overlay race on each cell, producing visible flicker.
|
||||||
|
// Terminals that don't recognise 2026 ignore the brackets, so the
|
||||||
|
// fallback behaviour is the same as before.
|
||||||
|
b.WriteString("\x1b[?2026h\x1b7\x1b[?25l")
|
||||||
|
|
||||||
|
row := int(layout.mainTop) + 1
|
||||||
|
col := int(layout.mainLeft) + paneCols - boxWidth - 1
|
||||||
|
if col < int(layout.mainLeft) {
|
||||||
|
col = int(layout.mainLeft)
|
||||||
|
}
|
||||||
|
|
||||||
|
// Render newest first (visually on top), iterating items in
|
||||||
|
// reverse so the most recent push lands at the smallest row.
|
||||||
|
for idx := len(items) - 1; idx >= 0; idx-- {
|
||||||
|
t := items[idx]
|
||||||
|
height := toastContentRows + 2
|
||||||
|
// Stop if we'd run off the bottom of the pane.
|
||||||
|
if row+height > int(layout.mainTop)+paneRows {
|
||||||
|
break
|
||||||
|
}
|
||||||
|
border := toastBorderStyle(t.kind)
|
||||||
|
wrapped := wrapToastBody(t.text, bodyRoom)
|
||||||
|
|
||||||
|
// Top border.
|
||||||
|
moveTo(&b, row, col)
|
||||||
|
b.WriteString(border)
|
||||||
|
b.WriteString("╭")
|
||||||
|
b.WriteString(strings.Repeat("─", boxWidth-2))
|
||||||
|
b.WriteString("╮")
|
||||||
|
b.WriteString(styleReset)
|
||||||
|
row++
|
||||||
|
|
||||||
|
// Content rows. Row 0 carries the kind glyph; rows 1..N indent
|
||||||
|
// by iconCols spaces so wrapped text lines up under the body.
|
||||||
|
for i := 0; i < toastContentRows; i++ {
|
||||||
|
moveTo(&b, row, col)
|
||||||
|
b.WriteString(border)
|
||||||
|
b.WriteString("│")
|
||||||
|
b.WriteString(styleReset)
|
||||||
|
b.WriteString(" ")
|
||||||
|
if i == 0 {
|
||||||
|
b.WriteString(toastIcon(t.kind))
|
||||||
|
} else {
|
||||||
|
b.WriteString(strings.Repeat(" ", iconCols))
|
||||||
|
}
|
||||||
|
line := wrapped[i]
|
||||||
|
b.WriteString(line)
|
||||||
|
b.WriteString(strings.Repeat(" ", max(0, bodyRoom-visibleLen(line))))
|
||||||
|
b.WriteString(" ")
|
||||||
|
b.WriteString(border)
|
||||||
|
b.WriteString("│")
|
||||||
|
b.WriteString(styleReset)
|
||||||
|
row++
|
||||||
|
}
|
||||||
|
|
||||||
|
// Bottom border.
|
||||||
|
moveTo(&b, row, col)
|
||||||
|
b.WriteString(border)
|
||||||
|
b.WriteString("╰")
|
||||||
|
b.WriteString(strings.Repeat("─", boxWidth-2))
|
||||||
|
b.WriteString("╯")
|
||||||
|
b.WriteString(styleReset)
|
||||||
|
row++
|
||||||
|
|
||||||
|
// 1-row gap between stacked toasts.
|
||||||
|
row++
|
||||||
|
}
|
||||||
|
|
||||||
|
b.WriteString("\x1b[?25h\x1b8\x1b[?2026l")
|
||||||
|
return []byte(b.String())
|
||||||
|
}
|
||||||
|
|
||||||
|
func toastBorderStyle(kind toastKind) string {
|
||||||
|
switch kind {
|
||||||
|
case toastError:
|
||||||
|
return styleError
|
||||||
|
case toastAttention:
|
||||||
|
return styleAccent
|
||||||
|
default:
|
||||||
|
return styleBorder
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// wrapToastBody word-wraps text into exactly toastContentRows lines,
|
||||||
|
// each at most width visible runes wide. Short messages are padded
|
||||||
|
// with empty trailing lines so callers can iterate a fixed-size
|
||||||
|
// slice; messages that don't fit get ellipsized on the last line.
|
||||||
|
func wrapToastBody(text string, width int) []string {
|
||||||
|
out := make([]string, toastContentRows)
|
||||||
|
if width < 1 {
|
||||||
|
return out
|
||||||
|
}
|
||||||
|
all := wrapToastWords(text, width)
|
||||||
|
if len(all) > toastContentRows {
|
||||||
|
all = all[:toastContentRows]
|
||||||
|
last := all[len(all)-1]
|
||||||
|
if visibleLen(last) >= width {
|
||||||
|
last = clipRunes(last, width-1) + "…"
|
||||||
|
} else {
|
||||||
|
last = last + "…"
|
||||||
|
}
|
||||||
|
all[len(all)-1] = last
|
||||||
|
}
|
||||||
|
for i, l := range all {
|
||||||
|
out[i] = l
|
||||||
|
}
|
||||||
|
return out
|
||||||
|
}
|
||||||
|
|
||||||
|
// wrapToastWords is a small word-wrapper sized for toast bodies:
|
||||||
|
// greedy, breaks overlong words on rune boundaries, drops collapsing
|
||||||
|
// whitespace via strings.Fields.
|
||||||
|
func wrapToastWords(text string, width int) []string {
|
||||||
|
var lines []string
|
||||||
|
var cur string
|
||||||
|
flush := func() {
|
||||||
|
if cur != "" {
|
||||||
|
lines = append(lines, cur)
|
||||||
|
cur = ""
|
||||||
|
}
|
||||||
|
}
|
||||||
|
for _, word := range strings.Fields(text) {
|
||||||
|
for visibleLen(word) > width {
|
||||||
|
flush()
|
||||||
|
head := clipRunes(word, width)
|
||||||
|
lines = append(lines, head)
|
||||||
|
word = word[len(head):]
|
||||||
|
}
|
||||||
|
if word == "" {
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
if cur == "" {
|
||||||
|
cur = word
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
if visibleLen(cur)+1+visibleLen(word) <= width {
|
||||||
|
cur += " " + word
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
flush()
|
||||||
|
cur = word
|
||||||
|
}
|
||||||
|
flush()
|
||||||
|
return lines
|
||||||
|
}
|
||||||
|
|
||||||
|
func toastIcon(kind toastKind) string {
|
||||||
|
switch kind {
|
||||||
|
case toastError:
|
||||||
|
return styleError + "✗ " + styleReset
|
||||||
|
case toastAttention:
|
||||||
|
return styleAccent + "! " + styleReset
|
||||||
|
default:
|
||||||
|
return styleHint + "• " + styleReset
|
||||||
|
}
|
||||||
|
}
|
||||||
164
internal/app/toast_test.go
Normal file
164
internal/app/toast_test.go
Normal file
@@ -0,0 +1,164 @@
|
|||||||
|
package app
|
||||||
|
|
||||||
|
import (
|
||||||
|
"strings"
|
||||||
|
"testing"
|
||||||
|
)
|
||||||
|
|
||||||
|
func TestToastStackPushAndOrder(t *testing.T) {
|
||||||
|
var s toastStack
|
||||||
|
s.push(toastInfo, "one")
|
||||||
|
s.push(toastError, "two")
|
||||||
|
s.push(toastAttention, "three")
|
||||||
|
|
||||||
|
snap := s.snapshot()
|
||||||
|
if len(snap) != 3 {
|
||||||
|
t.Fatalf("snapshot len = %d, want 3", len(snap))
|
||||||
|
}
|
||||||
|
if snap[0].text != "one" || snap[1].text != "two" || snap[2].text != "three" {
|
||||||
|
t.Fatalf("snapshot order wrong: %#v", snap)
|
||||||
|
}
|
||||||
|
if snap[0].kind != toastInfo || snap[1].kind != toastError || snap[2].kind != toastAttention {
|
||||||
|
t.Fatalf("snapshot kinds wrong: %#v", snap)
|
||||||
|
}
|
||||||
|
// IDs strictly increase.
|
||||||
|
if !(snap[0].id < snap[1].id && snap[1].id < snap[2].id) {
|
||||||
|
t.Fatalf("ids not increasing: %#v", snap)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestToastStackCapDropsOldest(t *testing.T) {
|
||||||
|
var s toastStack
|
||||||
|
for i := 0; i < toastStackCap+3; i++ {
|
||||||
|
s.push(toastInfo, "msg")
|
||||||
|
}
|
||||||
|
snap := s.snapshot()
|
||||||
|
if len(snap) != toastStackCap {
|
||||||
|
t.Fatalf("len = %d, want %d", len(snap), toastStackCap)
|
||||||
|
}
|
||||||
|
// The earliest IDs should have been dropped, leaving the highest
|
||||||
|
// toastStackCap IDs.
|
||||||
|
for i := 1; i < len(snap); i++ {
|
||||||
|
if snap[i].id <= snap[i-1].id {
|
||||||
|
t.Fatalf("ordering broken after cap: %#v", snap)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
// First retained id should be 4 (1,2,3 dropped; cap=5 leaves 4..8).
|
||||||
|
want := uint64(toastStackCap + 3 - toastStackCap + 1)
|
||||||
|
if snap[0].id != want {
|
||||||
|
t.Fatalf("first retained id = %d, want %d", snap[0].id, want)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestToastStackDismissTop(t *testing.T) {
|
||||||
|
var s toastStack
|
||||||
|
if s.dismissTop() {
|
||||||
|
t.Fatalf("dismissTop on empty stack returned true")
|
||||||
|
}
|
||||||
|
s.push(toastInfo, "a")
|
||||||
|
s.push(toastError, "b")
|
||||||
|
if !s.dismissTop() {
|
||||||
|
t.Fatalf("dismissTop returned false with items present")
|
||||||
|
}
|
||||||
|
snap := s.snapshot()
|
||||||
|
if len(snap) != 1 || snap[0].text != "a" {
|
||||||
|
t.Fatalf("after dismissTop: %#v", snap)
|
||||||
|
}
|
||||||
|
if !s.dismissTop() {
|
||||||
|
t.Fatalf("dismissTop on last item returned false")
|
||||||
|
}
|
||||||
|
if s.length() != 0 {
|
||||||
|
t.Fatalf("length after final dismiss = %d, want 0", s.length())
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestToastStackClear(t *testing.T) {
|
||||||
|
var s toastStack
|
||||||
|
if s.clear() {
|
||||||
|
t.Fatalf("clear on empty returned true")
|
||||||
|
}
|
||||||
|
s.push(toastInfo, "a")
|
||||||
|
s.push(toastError, "b")
|
||||||
|
s.push(toastAttention, "c")
|
||||||
|
if !s.clear() {
|
||||||
|
t.Fatalf("clear returned false with items present")
|
||||||
|
}
|
||||||
|
if s.length() != 0 {
|
||||||
|
t.Fatalf("length after clear = %d, want 0", s.length())
|
||||||
|
}
|
||||||
|
if snap := s.snapshot(); snap != nil {
|
||||||
|
t.Fatalf("snapshot after clear = %#v, want nil", snap)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestToastStackSnapshotIsCopy(t *testing.T) {
|
||||||
|
var s toastStack
|
||||||
|
s.push(toastInfo, "a")
|
||||||
|
snap := s.snapshot()
|
||||||
|
snap[0].text = "mutated"
|
||||||
|
again := s.snapshot()
|
||||||
|
if again[0].text != "a" {
|
||||||
|
t.Fatalf("snapshot is not an independent copy: %#v", again)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestWrapToastBodyFixedHeight(t *testing.T) {
|
||||||
|
got := wrapToastBody("short", 20)
|
||||||
|
if len(got) != toastContentRows {
|
||||||
|
t.Fatalf("len = %d, want %d", len(got), toastContentRows)
|
||||||
|
}
|
||||||
|
if got[0] != "short" {
|
||||||
|
t.Fatalf("line 0 = %q, want \"short\"", got[0])
|
||||||
|
}
|
||||||
|
if got[1] != "" || got[2] != "" {
|
||||||
|
t.Fatalf("trailing pads not empty: %#v", got)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestWrapToastBodyWrapsOnWordBoundary(t *testing.T) {
|
||||||
|
got := wrapToastBody("the quick brown fox jumps over", 10)
|
||||||
|
// Expect greedy fill: "the quick" (9), "brown fox" (9), "jumps over" (10).
|
||||||
|
want := []string{"the quick", "brown fox", "jumps over"}
|
||||||
|
for i, w := range want {
|
||||||
|
if got[i] != w {
|
||||||
|
t.Fatalf("line %d = %q, want %q (full=%#v)", i, got[i], w, got)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestWrapToastBodyEllipsizesOverflow(t *testing.T) {
|
||||||
|
got := wrapToastBody("alpha beta gamma delta epsilon zeta eta theta", 6)
|
||||||
|
if len(got) != toastContentRows {
|
||||||
|
t.Fatalf("len = %d, want %d", len(got), toastContentRows)
|
||||||
|
}
|
||||||
|
last := got[toastContentRows-1]
|
||||||
|
if !strings.HasSuffix(last, "…") {
|
||||||
|
t.Fatalf("overflow should ellipsize last line, got %q (full=%#v)", last, got)
|
||||||
|
}
|
||||||
|
if visibleLen(last) > 6 {
|
||||||
|
t.Fatalf("last line %q exceeds width 6", last)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestWrapToastBodyBreaksOverlongWord(t *testing.T) {
|
||||||
|
got := wrapToastBody("supercalifragilistic", 6)
|
||||||
|
if got[0] != "superc" {
|
||||||
|
t.Fatalf("line 0 = %q, want \"superc\"", got[0])
|
||||||
|
}
|
||||||
|
if got[1] != "alifra" {
|
||||||
|
t.Fatalf("line 1 = %q, want \"alifra\"", got[1])
|
||||||
|
}
|
||||||
|
// Third line should hold the rest (possibly ellipsized).
|
||||||
|
if got[2] == "" {
|
||||||
|
t.Fatalf("line 2 unexpectedly empty: %#v", got)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestWrapToastBodyEmptyInput(t *testing.T) {
|
||||||
|
got := wrapToastBody("", 20)
|
||||||
|
for i, l := range got {
|
||||||
|
if l != "" {
|
||||||
|
t.Fatalf("line %d = %q, want \"\"", i, l)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -143,7 +143,7 @@ func openSession(t *testing.T, env *testEnv, childEnv []string) *Session {
|
|||||||
if err != nil {
|
if err != nil {
|
||||||
t.Fatalf("vt emulator: %v", err)
|
t.Fatalf("vt emulator: %v", err)
|
||||||
}
|
}
|
||||||
p, err := pkgpty.Start([]string{env.PattermBin, "--project", env.ProjectDir}, childEnv, env.Cols, env.Rows)
|
p, err := pkgpty.Start([]string{env.PattermBin, "--project", env.ProjectDir}, childEnv, "", env.Cols, env.Rows)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
_ = em.Close()
|
_ = em.Close()
|
||||||
t.Fatalf("pty start: %v", err)
|
t.Fatalf("pty start: %v", err)
|
||||||
|
|||||||
@@ -0,0 +1,37 @@
|
|||||||
|
{
|
||||||
|
"name": "error_flash_preserves_focused_pane",
|
||||||
|
"presets": {
|
||||||
|
"processes": [
|
||||||
|
{
|
||||||
|
"name": "steady",
|
||||||
|
"argv": ["sh", "-lc", "printf 'STEADY READY\\n'; sleep 5"]
|
||||||
|
}
|
||||||
|
]
|
||||||
|
},
|
||||||
|
"trust": ["steady"],
|
||||||
|
"steps": [
|
||||||
|
{
|
||||||
|
"type": "mcp_call",
|
||||||
|
"method": "spawn_process",
|
||||||
|
"params": {"kind": "command", "preset": "steady", "name": "steady"},
|
||||||
|
"save_as": "proc"
|
||||||
|
},
|
||||||
|
{ "type": "wait_text", "contains": "STEADY READY", "timeout_ms": 5000 },
|
||||||
|
{ "type": "send_chord", "chord": "ctrl-k" },
|
||||||
|
{ "type": "send_text", "text": "Open Settings" },
|
||||||
|
{ "type": "send_chord", "chord": "enter" },
|
||||||
|
{ "type": "send_chord", "chord": "enter" },
|
||||||
|
{ "type": "send_chord", "chord": "ctrl-n" },
|
||||||
|
{ "type": "send_chord", "chord": "ctrl-n" },
|
||||||
|
{ "type": "send_chord", "chord": "ctrl-n" },
|
||||||
|
{ "type": "send_chord", "chord": "ctrl-n" },
|
||||||
|
{ "type": "send_chord", "chord": "ctrl-n" },
|
||||||
|
{ "type": "send_chord", "chord": "ctrl-n" },
|
||||||
|
{ "type": "send_chord", "chord": "ctrl-n" },
|
||||||
|
{ "type": "send_chord", "chord": "enter" },
|
||||||
|
{ "type": "wait_text", "contains": "no active top-level agent to summarize", "timeout_ms": 5000 },
|
||||||
|
{ "type": "wait_text", "contains": "STEADY READY", "timeout_ms": 5000 },
|
||||||
|
{ "type": "assert_contains", "contains": "STEADY READY" },
|
||||||
|
{ "type": "assert_not_contains", "contains": "Press Ctrl-K to spawn an agent or process" }
|
||||||
|
]
|
||||||
|
}
|
||||||
@@ -0,0 +1,37 @@
|
|||||||
|
{
|
||||||
|
"name": "idle_screen_permission_prompt",
|
||||||
|
"presets": {
|
||||||
|
"processes": [
|
||||||
|
{
|
||||||
|
"name": "screen-permission",
|
||||||
|
"argv": [
|
||||||
|
"sh",
|
||||||
|
"-lc",
|
||||||
|
"printf '\\033[2J\\033[HCalling patterm...\\n\\nTool use\\n\\nDo you want to proceed?\\n 1. Yes\\n'; i=0; while [ $i -lt 300 ]; do printf '\\033[HCalling patterm... %03d' $i; i=$((i+1)); done; sleep 60"
|
||||||
|
],
|
||||||
|
"idle_detection": {
|
||||||
|
"strategy": "output_activity",
|
||||||
|
"idle_threshold_ms": 500,
|
||||||
|
"permission_patterns": ["Do you want to proceed\\?"]
|
||||||
|
}
|
||||||
|
}
|
||||||
|
]
|
||||||
|
},
|
||||||
|
"trust": ["screen-permission"],
|
||||||
|
"steps": [
|
||||||
|
{
|
||||||
|
"type": "mcp_call",
|
||||||
|
"method": "spawn_process",
|
||||||
|
"params": {"kind": "command", "preset": "screen-permission", "name": "screen-permission"},
|
||||||
|
"save_as": "proc"
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"type": "wait_until_mcp",
|
||||||
|
"method": "get_process_status",
|
||||||
|
"params": {"process_id": "{{proc.process_id}}"},
|
||||||
|
"path": "idle_state",
|
||||||
|
"equals": "permission",
|
||||||
|
"timeout_ms": 4000
|
||||||
|
}
|
||||||
|
]
|
||||||
|
}
|
||||||
32
internal/harness/scenarios/restart_process_keeps_chrome.json
Normal file
32
internal/harness/scenarios/restart_process_keeps_chrome.json
Normal file
@@ -0,0 +1,32 @@
|
|||||||
|
{
|
||||||
|
"name": "restart_process_keeps_chrome",
|
||||||
|
"cols": 120,
|
||||||
|
"rows": 40,
|
||||||
|
"scripts": [
|
||||||
|
{
|
||||||
|
"name": "slow-restart",
|
||||||
|
"body": "#!/bin/sh\ncount_file=\"$XDG_RUNTIME_DIR/slow-restart-count\"\nif [ -f \"$count_file\" ]; then\n n=$(cat \"$count_file\")\nelse\n n=0\nfi\nn=$((n + 1))\nprintf '%s\\n' \"$n\" > \"$count_file\"\nprintf 'SLOW READY %s\\n' \"$n\"\ntrap 'sleep 3; exit 0' TERM\nwhile true; do sleep 1; done\n"
|
||||||
|
}
|
||||||
|
],
|
||||||
|
"steps": [
|
||||||
|
{
|
||||||
|
"type": "mcp_call",
|
||||||
|
"method": "spawn_process",
|
||||||
|
"params": { "kind": "command", "argv": ["slow-restart"], "name": "slow-restart" },
|
||||||
|
"save_as": "spawned"
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"type": "mcp_call",
|
||||||
|
"method": "select_process",
|
||||||
|
"params": { "process_id": "{{spawned.process_id}}" }
|
||||||
|
},
|
||||||
|
{ "type": "wait_text", "contains": "SLOW READY 1", "timeout_ms": 5000 },
|
||||||
|
{ "type": "wait_stable", "timeout_ms": 2000 },
|
||||||
|
{ "type": "assert_contains", "contains": "Processes" },
|
||||||
|
{ "type": "send_text", "text": "\u000brestart\r" },
|
||||||
|
{ "type": "wait_stable", "timeout_ms": 2000 },
|
||||||
|
{ "type": "assert_contains", "contains": "Processes" },
|
||||||
|
{ "type": "assert_contains", "contains": "slow-restart" },
|
||||||
|
{ "type": "wait_text", "contains": "SLOW READY 2", "timeout_ms": 7000 }
|
||||||
|
]
|
||||||
|
}
|
||||||
32
internal/harness/scenarios/toast_dismiss.json
Normal file
32
internal/harness/scenarios/toast_dismiss.json
Normal file
@@ -0,0 +1,32 @@
|
|||||||
|
{
|
||||||
|
"name": "toast_dismiss",
|
||||||
|
"presets": {
|
||||||
|
"processes": [
|
||||||
|
{
|
||||||
|
"name": "steady",
|
||||||
|
"argv": ["sh", "-lc", "printf 'STEADY READY\\n'; sleep 30"]
|
||||||
|
}
|
||||||
|
]
|
||||||
|
},
|
||||||
|
"trust": ["steady"],
|
||||||
|
"steps": [
|
||||||
|
{
|
||||||
|
"type": "mcp_call",
|
||||||
|
"method": "spawn_process",
|
||||||
|
"params": {"kind": "command", "preset": "steady", "name": "steady"},
|
||||||
|
"save_as": "proc"
|
||||||
|
},
|
||||||
|
{ "type": "wait_text", "contains": "STEADY READY", "timeout_ms": 5000 },
|
||||||
|
{
|
||||||
|
"type": "mcp_call",
|
||||||
|
"method": "request_human_attention",
|
||||||
|
"params": {"process_id": "{{proc.process_id}}", "reason": "needs eyes on the deploy"}
|
||||||
|
},
|
||||||
|
{ "type": "wait_text", "contains": "needs eyes on the deploy", "timeout_ms": 5000 },
|
||||||
|
{ "type": "assert_contains", "contains": "STEADY READY" },
|
||||||
|
{ "type": "send_chord", "chord": "ctrl-n" },
|
||||||
|
{ "type": "wait_stable", "timeout_ms": 2000 },
|
||||||
|
{ "type": "assert_contains", "contains": "STEADY READY" },
|
||||||
|
{ "type": "assert_not_contains", "contains": "needs eyes on the deploy" }
|
||||||
|
]
|
||||||
|
}
|
||||||
@@ -55,7 +55,7 @@ func NewCLI(opts Options) (*Session, error) {
|
|||||||
if err != nil {
|
if err != nil {
|
||||||
return nil, err
|
return nil, err
|
||||||
}
|
}
|
||||||
p, err := pkgpty.Start([]string{env.PattermBin, "--project", env.ProjectDir}, childEnv, env.Cols, env.Rows)
|
p, err := pkgpty.Start([]string{env.PattermBin, "--project", env.ProjectDir}, childEnv, "", env.Cols, env.Rows)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
_ = em.Close()
|
_ = em.Close()
|
||||||
return nil, err
|
return nil, err
|
||||||
|
|||||||
@@ -96,10 +96,34 @@ func (s *Server) acceptLoop() {
|
|||||||
// identity token (SPEC §10); we resolve it to a child id and stash that
|
// identity token (SPEC §10); we resolve it to a child id and stash that
|
||||||
// as the caller for every subsequent tool call.
|
// as the caller for every subsequent tool call.
|
||||||
func (s *Server) handleConn(conn net.Conn) {
|
func (s *Server) handleConn(conn net.Conn) {
|
||||||
defer conn.Close()
|
var writeMu sync.Mutex
|
||||||
|
var wg sync.WaitGroup
|
||||||
|
defer func() {
|
||||||
|
wg.Wait()
|
||||||
|
_ = conn.Close()
|
||||||
|
}()
|
||||||
r := bufio.NewReader(conn)
|
r := bufio.NewReader(conn)
|
||||||
|
|
||||||
var callerID string
|
var callerID string
|
||||||
|
writeResp := func(resp []byte) bool {
|
||||||
|
if resp == nil {
|
||||||
|
return true
|
||||||
|
}
|
||||||
|
resp = append(resp, '\n')
|
||||||
|
writeMu.Lock()
|
||||||
|
defer writeMu.Unlock()
|
||||||
|
for len(resp) > 0 {
|
||||||
|
n, err := conn.Write(resp)
|
||||||
|
if err != nil {
|
||||||
|
return false
|
||||||
|
}
|
||||||
|
if n == 0 {
|
||||||
|
return false
|
||||||
|
}
|
||||||
|
resp = resp[n:]
|
||||||
|
}
|
||||||
|
return true
|
||||||
|
}
|
||||||
|
|
||||||
greeting, err := r.ReadBytes('\n')
|
greeting, err := r.ReadBytes('\n')
|
||||||
if err != nil {
|
if err != nil {
|
||||||
@@ -115,24 +139,21 @@ func (s *Server) handleConn(conn net.Conn) {
|
|||||||
} else {
|
} else {
|
||||||
// Treat as a real request from an unknown caller.
|
// Treat as a real request from an unknown caller.
|
||||||
resp := s.dispatch("", greeting)
|
resp := s.dispatch("", greeting)
|
||||||
if resp != nil {
|
if !writeResp(resp) {
|
||||||
resp = append(resp, '\n')
|
|
||||||
if _, werr := conn.Write(resp); werr != nil {
|
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
|
||||||
|
|
||||||
for {
|
for {
|
||||||
line, err := r.ReadBytes('\n')
|
line, err := r.ReadBytes('\n')
|
||||||
if len(line) > 0 {
|
if len(line) > 0 {
|
||||||
resp := s.dispatch(callerID, line)
|
req := append([]byte(nil), line...)
|
||||||
if resp != nil {
|
wg.Add(1)
|
||||||
resp = append(resp, '\n')
|
go func() {
|
||||||
if _, werr := conn.Write(resp); werr != nil {
|
defer wg.Done()
|
||||||
return
|
resp := s.dispatch(callerID, req)
|
||||||
}
|
_ = writeResp(resp)
|
||||||
}
|
}()
|
||||||
}
|
}
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return
|
return
|
||||||
|
|||||||
190
internal/mcp/mcp_test.go
Normal file
190
internal/mcp/mcp_test.go
Normal file
@@ -0,0 +1,190 @@
|
|||||||
|
package mcp
|
||||||
|
|
||||||
|
import (
|
||||||
|
"bufio"
|
||||||
|
"encoding/json"
|
||||||
|
"fmt"
|
||||||
|
"net"
|
||||||
|
"sync"
|
||||||
|
"syscall"
|
||||||
|
"testing"
|
||||||
|
"time"
|
||||||
|
|
||||||
|
"github.com/hjbdev/patterm/internal/scratchpad"
|
||||||
|
)
|
||||||
|
|
||||||
|
func TestHandleConnDispatchesRequestsConcurrently(t *testing.T) {
|
||||||
|
serverConn, clientConn := net.Pipe()
|
||||||
|
t.Cleanup(func() { _ = clientConn.Close() })
|
||||||
|
|
||||||
|
host := &blockingToolHost{
|
||||||
|
waitEntered: make(chan struct{}),
|
||||||
|
waitRelease: make(chan struct{}),
|
||||||
|
}
|
||||||
|
s := &Server{}
|
||||||
|
s.SetHost(host)
|
||||||
|
done := make(chan struct{})
|
||||||
|
go func() {
|
||||||
|
s.handleConn(serverConn)
|
||||||
|
close(done)
|
||||||
|
}()
|
||||||
|
|
||||||
|
reader := bufio.NewReader(clientConn)
|
||||||
|
writeLine(t, clientConn, `{"patterm_identity":"ident"}`)
|
||||||
|
writeLine(t, clientConn, `{"jsonrpc":"2.0","id":1,"method":"wait_for_pattern","params":{"process_id":"p_slow","pattern":"never","timeout_seconds":300}}`)
|
||||||
|
select {
|
||||||
|
case <-host.waitEntered:
|
||||||
|
case <-time.After(time.Second):
|
||||||
|
t.Fatal("wait_for_pattern did not enter fake host")
|
||||||
|
}
|
||||||
|
|
||||||
|
writeLine(t, clientConn, `{"jsonrpc":"2.0","id":2,"method":"get_process_status","params":{"process_id":"p_fast"}}`)
|
||||||
|
fast := readJSONRPCResponse(t, clientConn, reader, time.Second)
|
||||||
|
if got := string(fast.ID); got != "2" {
|
||||||
|
t.Fatalf("first response id = %s, want 2; response=%s", got, fast.Raw)
|
||||||
|
}
|
||||||
|
if fast.Error != nil {
|
||||||
|
t.Fatalf("fast response returned error: %+v", fast.Error)
|
||||||
|
}
|
||||||
|
|
||||||
|
_ = clientConn.SetReadDeadline(time.Now().Add(50 * time.Millisecond))
|
||||||
|
if line, err := reader.ReadBytes('\n'); err == nil {
|
||||||
|
t.Fatalf("slow response arrived before release: %s", line)
|
||||||
|
}
|
||||||
|
|
||||||
|
close(host.waitRelease)
|
||||||
|
slow := readJSONRPCResponse(t, clientConn, reader, time.Second)
|
||||||
|
if got := string(slow.ID); got != "1" {
|
||||||
|
t.Fatalf("second response id = %s, want 1; response=%s", got, slow.Raw)
|
||||||
|
}
|
||||||
|
if slow.Error != nil {
|
||||||
|
t.Fatalf("slow response returned error: %+v", slow.Error)
|
||||||
|
}
|
||||||
|
|
||||||
|
_ = clientConn.Close()
|
||||||
|
select {
|
||||||
|
case <-done:
|
||||||
|
case <-time.After(time.Second):
|
||||||
|
t.Fatal("handleConn did not exit after client close")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
type jsonRPCResponse struct {
|
||||||
|
Raw string
|
||||||
|
ID json.RawMessage `json:"id"`
|
||||||
|
Result map[string]any `json:"result"`
|
||||||
|
Error *jsonRPCErrorShape `json:"error"`
|
||||||
|
}
|
||||||
|
|
||||||
|
type jsonRPCErrorShape struct {
|
||||||
|
Code int `json:"code"`
|
||||||
|
Message string `json:"message"`
|
||||||
|
}
|
||||||
|
|
||||||
|
func writeLine(t *testing.T, conn net.Conn, line string) {
|
||||||
|
t.Helper()
|
||||||
|
_ = conn.SetWriteDeadline(time.Now().Add(time.Second))
|
||||||
|
if _, err := fmt.Fprintln(conn, line); err != nil {
|
||||||
|
t.Fatalf("write %s: %v", line, err)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func readJSONRPCResponse(t *testing.T, conn net.Conn, reader *bufio.Reader, timeout time.Duration) jsonRPCResponse {
|
||||||
|
t.Helper()
|
||||||
|
_ = conn.SetReadDeadline(time.Now().Add(timeout))
|
||||||
|
line, err := reader.ReadBytes('\n')
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("read response: %v", err)
|
||||||
|
}
|
||||||
|
var resp jsonRPCResponse
|
||||||
|
resp.Raw = string(line)
|
||||||
|
if err := json.Unmarshal(line, &resp); err != nil {
|
||||||
|
t.Fatalf("parse response %s: %v", line, err)
|
||||||
|
}
|
||||||
|
return resp
|
||||||
|
}
|
||||||
|
|
||||||
|
type blockingToolHost struct {
|
||||||
|
waitEntered chan struct{}
|
||||||
|
waitRelease chan struct{}
|
||||||
|
waitOnce sync.Once
|
||||||
|
}
|
||||||
|
|
||||||
|
func (h *blockingToolHost) ResolveCallerIdentity(identity string) string { return "caller-" + identity }
|
||||||
|
func (h *blockingToolHost) CallerRole(string) CallerRole { return RoleOrchestrator }
|
||||||
|
func (h *blockingToolHost) SpawnAgent(string, SpawnAgentArgs) (ProcessInfo, error) {
|
||||||
|
return ProcessInfo{}, nil
|
||||||
|
}
|
||||||
|
func (h *blockingToolHost) SpawnProcess(string, SpawnProcessArgs) (ProcessInfo, error) {
|
||||||
|
return ProcessInfo{}, nil
|
||||||
|
}
|
||||||
|
func (h *blockingToolHost) StartProcess(string, string) (ProcessInfo, error) {
|
||||||
|
return ProcessInfo{}, nil
|
||||||
|
}
|
||||||
|
func (h *blockingToolHost) RestartProcess(string, string, syscall.Signal) (ProcessInfo, error) {
|
||||||
|
return ProcessInfo{}, nil
|
||||||
|
}
|
||||||
|
func (h *blockingToolHost) StopProcess(string, string, syscall.Signal) (ProcessInfo, error) {
|
||||||
|
return ProcessInfo{}, nil
|
||||||
|
}
|
||||||
|
func (h *blockingToolHost) CloseProcess(string, string) error { return nil }
|
||||||
|
func (h *blockingToolHost) RenameProcess(string, string, string) error { return nil }
|
||||||
|
func (h *blockingToolHost) SelectProcess(string, string) error { return nil }
|
||||||
|
func (h *blockingToolHost) ListProcesses(string, string) []ProcessInfo { return nil }
|
||||||
|
func (h *blockingToolHost) GetProcessStatus(string, string) (ProcessStatus, error) {
|
||||||
|
return ProcessStatus{ProcessInfo: ProcessInfo{ID: "p_fast", Status: "running"}}, nil
|
||||||
|
}
|
||||||
|
func (h *blockingToolHost) GetProjectStatus(string) (ProjectStatus, error) {
|
||||||
|
return ProjectStatus{}, nil
|
||||||
|
}
|
||||||
|
func (h *blockingToolHost) GetProcessOutput(string, string, string, int64) (ProcessOutput, error) {
|
||||||
|
return ProcessOutput{}, nil
|
||||||
|
}
|
||||||
|
func (h *blockingToolHost) GetProcessRawOutput(string, string, int64) (RawOutput, error) {
|
||||||
|
return RawOutput{}, nil
|
||||||
|
}
|
||||||
|
func (h *blockingToolHost) SearchOutput(string, string, string, string, int) (SearchResult, error) {
|
||||||
|
return SearchResult{}, nil
|
||||||
|
}
|
||||||
|
func (h *blockingToolHost) WaitForPattern(string, string, string, float64, string) (bool, string, error) {
|
||||||
|
h.waitOnce.Do(func() { close(h.waitEntered) })
|
||||||
|
<-h.waitRelease
|
||||||
|
return true, "matched", nil
|
||||||
|
}
|
||||||
|
func (h *blockingToolHost) GetProcessPorts(string, string) ([]PortSighting, error) {
|
||||||
|
return nil, nil
|
||||||
|
}
|
||||||
|
func (h *blockingToolHost) SendInput(string, SendInputArgs) (SendInputResult, error) {
|
||||||
|
return SendInputResult{}, nil
|
||||||
|
}
|
||||||
|
func (h *blockingToolHost) SendMessage(string, string, string) error { return nil }
|
||||||
|
func (h *blockingToolHost) RequestHumanAttention(string, string, string) error { return nil }
|
||||||
|
func (h *blockingToolHost) TimerWait(string, float64, string) (string, error) {
|
||||||
|
return "", nil
|
||||||
|
}
|
||||||
|
func (h *blockingToolHost) TimerSet(string, TimerSetArgs) (TimerHandle, error) {
|
||||||
|
return TimerHandle{}, nil
|
||||||
|
}
|
||||||
|
func (h *blockingToolHost) TimerFireWhenIdleAny(string, TimerFireWhenIdleArgs) (TimerFireWhenIdleResponse, error) {
|
||||||
|
return TimerFireWhenIdleResponse{}, nil
|
||||||
|
}
|
||||||
|
func (h *blockingToolHost) TimerFireWhenIdleAll(string, TimerFireWhenIdleArgs) (TimerFireWhenIdleResponse, error) {
|
||||||
|
return TimerFireWhenIdleResponse{}, nil
|
||||||
|
}
|
||||||
|
func (h *blockingToolHost) TimerCancel(string, string) error { return nil }
|
||||||
|
func (h *blockingToolHost) TimerPause(string, string) error { return nil }
|
||||||
|
func (h *blockingToolHost) TimerResume(string, string) error { return nil }
|
||||||
|
func (h *blockingToolHost) TimerList(string) ([]TimerInfo, error) {
|
||||||
|
return nil, nil
|
||||||
|
}
|
||||||
|
func (h *blockingToolHost) ScratchpadList() ([]scratchpad.Entry, error) { return nil, nil }
|
||||||
|
func (h *blockingToolHost) ScratchpadRead(string) (string, string, error) {
|
||||||
|
return "", "", nil
|
||||||
|
}
|
||||||
|
func (h *blockingToolHost) ScratchpadWrite(string, string, string) (string, error) {
|
||||||
|
return "", nil
|
||||||
|
}
|
||||||
|
func (h *blockingToolHost) ScratchpadAppend(string, string) error { return nil }
|
||||||
|
func (h *blockingToolHost) ScratchpadDelete(string) error { return nil }
|
||||||
|
func (h *blockingToolHost) WhoAmI(string) WhoAmI { return WhoAmI{} }
|
||||||
|
func (h *blockingToolHost) Help(string, string) HelpResponse { return HelpResponse{} }
|
||||||
@@ -358,6 +358,13 @@ func toolCatalog() []toolDescriptor {
|
|||||||
"content": stringProp("Text to append."),
|
"content": stringProp("Text to append."),
|
||||||
}, []string{"name", "content"}),
|
}, []string{"name", "content"}),
|
||||||
},
|
},
|
||||||
|
{
|
||||||
|
Name: "scratchpad_delete",
|
||||||
|
Description: "Delete a scratchpad entry.",
|
||||||
|
InputSchema: objectSchema(map[string]any{
|
||||||
|
"name": stringProp("Scratchpad name."),
|
||||||
|
}, []string{"name"}),
|
||||||
|
},
|
||||||
{
|
{
|
||||||
Name: "whoami",
|
Name: "whoami",
|
||||||
Description: "Return the caller's identity, role, parent, project metadata, and available tools.",
|
Description: "Return the caller's identity, role, parent, project metadata, and available tools.",
|
||||||
|
|||||||
@@ -101,6 +101,7 @@ type ToolHost interface {
|
|||||||
ScratchpadRead(name string) (content string, revision string, err error)
|
ScratchpadRead(name string) (content string, revision string, err error)
|
||||||
ScratchpadWrite(name, content, expectedRevision string) (revision string, err error)
|
ScratchpadWrite(name, content, expectedRevision string) (revision string, err error)
|
||||||
ScratchpadAppend(name, content string) error
|
ScratchpadAppend(name, content string) error
|
||||||
|
ScratchpadDelete(name string) error
|
||||||
|
|
||||||
// Meta.
|
// Meta.
|
||||||
WhoAmI(callerID string) WhoAmI
|
WhoAmI(callerID string) WhoAmI
|
||||||
@@ -776,6 +777,18 @@ func callTool(h ToolHost, callerID, method string, params json.RawMessage) (any,
|
|||||||
}
|
}
|
||||||
return map[string]any{"ok": true}, 0, "", nil
|
return map[string]any{"ok": true}, 0, "", nil
|
||||||
|
|
||||||
|
case "scratchpad_delete":
|
||||||
|
var p struct {
|
||||||
|
Name string `json:"name"`
|
||||||
|
}
|
||||||
|
if err := unmarshalParams(params, &p); err != nil {
|
||||||
|
return nil, codeInvalidParams, err.Error(), nil
|
||||||
|
}
|
||||||
|
if err := h.ScratchpadDelete(p.Name); err != nil {
|
||||||
|
return nil, codeInternal, err.Error(), nil
|
||||||
|
}
|
||||||
|
return map[string]any{"ok": true}, 0, "", nil
|
||||||
|
|
||||||
case "whoami":
|
case "whoami":
|
||||||
return h.WhoAmI(callerID), 0, "", nil
|
return h.WhoAmI(callerID), 0, "", nil
|
||||||
|
|
||||||
|
|||||||
@@ -4,6 +4,7 @@
|
|||||||
package preset
|
package preset
|
||||||
|
|
||||||
import (
|
import (
|
||||||
|
"bytes"
|
||||||
"encoding/json"
|
"encoding/json"
|
||||||
"errors"
|
"errors"
|
||||||
"fmt"
|
"fmt"
|
||||||
@@ -35,6 +36,7 @@ type Preset struct {
|
|||||||
Argv []string `json:"argv"`
|
Argv []string `json:"argv"`
|
||||||
Env map[string]string `json:"env,omitempty"`
|
Env map[string]string `json:"env,omitempty"`
|
||||||
WorkingDir string `json:"working_dir,omitempty"`
|
WorkingDir string `json:"working_dir,omitempty"`
|
||||||
|
Disabled bool `json:"disabled,omitempty"`
|
||||||
|
|
||||||
// Process-only.
|
// Process-only.
|
||||||
Shell bool `json:"shell,omitempty"`
|
Shell bool `json:"shell,omitempty"`
|
||||||
@@ -119,28 +121,22 @@ type Set struct {
|
|||||||
Processes []*Preset
|
Processes []*Preset
|
||||||
}
|
}
|
||||||
|
|
||||||
// Load scans the standard locations under $XDG_CONFIG_HOME/patterm/
|
// Load returns the built-in presets plus user overlays from
|
||||||
// presets/{agents,processes}/*.json. Unknown files are skipped with a
|
// $XDG_CONFIG_HOME/patterm/presets/{agents,processes}/*.json. Startup
|
||||||
// warning to stderr; the spec is forgiving here.
|
// does not write default files; user files only override or extend the
|
||||||
|
// in-memory defaults. A user overlay with {"disabled": true} hides a
|
||||||
|
// built-in preset of the same name.
|
||||||
func Load() (Set, error) {
|
func Load() (Set, error) {
|
||||||
base, err := ConfigDir()
|
base, err := ConfigDir()
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return Set{}, err
|
return Set{}, err
|
||||||
}
|
}
|
||||||
if err := os.MkdirAll(base, 0o700); err != nil {
|
|
||||||
return Set{}, fmt.Errorf("preset: mkdir %s: %w", base, err)
|
|
||||||
}
|
|
||||||
|
|
||||||
// Make sure the default-preset files exist on first run. Idempotent.
|
agents, err := loadWithDefaults(filepath.Join(base, "presets", "agents"), KindAgent, defaultAgentPresets())
|
||||||
if err := ensureDefaults(base); err != nil {
|
|
||||||
return Set{}, err
|
|
||||||
}
|
|
||||||
|
|
||||||
agents, err := loadDir(filepath.Join(base, "presets", "agents"), KindAgent)
|
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return Set{}, err
|
return Set{}, err
|
||||||
}
|
}
|
||||||
procs, err := loadDir(filepath.Join(base, "presets", "processes"), KindCommand)
|
procs, err := loadWithDefaults(filepath.Join(base, "presets", "processes"), KindCommand, nil)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return Set{}, err
|
return Set{}, err
|
||||||
}
|
}
|
||||||
@@ -160,51 +156,154 @@ func ConfigDir() (string, error) {
|
|||||||
return filepath.Join(home, ".config", "patterm"), nil
|
return filepath.Join(home, ".config", "patterm"), nil
|
||||||
}
|
}
|
||||||
|
|
||||||
func loadDir(dir string, kind Kind) ([]*Preset, error) {
|
func loadWithDefaults(dir string, kind Kind, defaults []*Preset) ([]*Preset, error) {
|
||||||
if err := os.MkdirAll(dir, 0o700); err != nil {
|
byName := make(map[string]*Preset, len(defaults))
|
||||||
return nil, fmt.Errorf("preset: mkdir %s: %w", dir, err)
|
for _, p := range defaults {
|
||||||
|
cp := clonePreset(p)
|
||||||
|
cp.Kind = kind
|
||||||
|
byName[cp.Name] = cp
|
||||||
}
|
}
|
||||||
|
|
||||||
entries, err := os.ReadDir(dir)
|
entries, err := os.ReadDir(dir)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
|
if os.IsNotExist(err) {
|
||||||
|
return sortedPresets(byName), nil
|
||||||
|
}
|
||||||
return nil, fmt.Errorf("preset: read %s: %w", dir, err)
|
return nil, fmt.Errorf("preset: read %s: %w", dir, err)
|
||||||
}
|
}
|
||||||
var out []*Preset
|
|
||||||
for _, e := range entries {
|
for _, e := range entries {
|
||||||
if e.IsDir() || !strings.HasSuffix(e.Name(), ".json") {
|
if e.IsDir() || !strings.HasSuffix(e.Name(), ".json") {
|
||||||
continue
|
continue
|
||||||
}
|
}
|
||||||
path := filepath.Join(dir, e.Name())
|
path := filepath.Join(dir, e.Name())
|
||||||
p, err := loadFile(path, kind)
|
p, err := loadFileOverlay(path, kind, byName)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
fmt.Fprintf(os.Stderr, "patterm: preset %s: %v\n", path, err)
|
fmt.Fprintf(os.Stderr, "patterm: preset %s: %v\n", path, err)
|
||||||
continue
|
continue
|
||||||
}
|
}
|
||||||
|
if p.Disabled {
|
||||||
|
delete(byName, p.Name)
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
byName[p.Name] = p
|
||||||
|
}
|
||||||
|
return sortedPresets(byName), nil
|
||||||
|
}
|
||||||
|
|
||||||
|
func sortedPresets(byName map[string]*Preset) []*Preset {
|
||||||
|
out := make([]*Preset, 0, len(byName))
|
||||||
|
for _, p := range byName {
|
||||||
out = append(out, p)
|
out = append(out, p)
|
||||||
}
|
}
|
||||||
sort.Slice(out, func(i, j int) bool { return out[i].Name < out[j].Name })
|
sort.Slice(out, func(i, j int) bool { return out[i].Name < out[j].Name })
|
||||||
return out, nil
|
return out
|
||||||
}
|
}
|
||||||
|
|
||||||
func loadFile(path string, kind Kind) (*Preset, error) {
|
func loadFileOverlay(path string, kind Kind, defaults map[string]*Preset) (*Preset, error) {
|
||||||
b, err := os.ReadFile(path)
|
b, err := os.ReadFile(path)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return nil, err
|
return nil, err
|
||||||
}
|
}
|
||||||
|
var header struct {
|
||||||
|
Name string `json:"name"`
|
||||||
|
Disabled bool `json:"disabled,omitempty"`
|
||||||
|
}
|
||||||
|
if err := json.Unmarshal(b, &header); err != nil {
|
||||||
|
return nil, err
|
||||||
|
}
|
||||||
|
if header.Name == "" {
|
||||||
|
return nil, errors.New("missing 'name'")
|
||||||
|
}
|
||||||
|
if def := defaults[header.Name]; def != nil {
|
||||||
|
p, err := mergePreset(def, b)
|
||||||
|
if err != nil {
|
||||||
|
return nil, err
|
||||||
|
}
|
||||||
|
p.Path = path
|
||||||
|
p.Kind = kind
|
||||||
|
return p, validatePreset(p)
|
||||||
|
}
|
||||||
|
var p Preset
|
||||||
|
if err := json.Unmarshal(b, &p); err != nil {
|
||||||
|
return nil, err
|
||||||
|
}
|
||||||
|
p.Path = path
|
||||||
|
p.Kind = kind
|
||||||
|
return &p, validatePreset(&p)
|
||||||
|
}
|
||||||
|
|
||||||
|
func validatePreset(p *Preset) error {
|
||||||
|
if p.Name == "" {
|
||||||
|
return errors.New("missing 'name'")
|
||||||
|
}
|
||||||
|
if p.Disabled {
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
if len(p.Argv) == 0 && !p.Shell {
|
||||||
|
return errors.New("missing 'argv'")
|
||||||
|
}
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
|
||||||
|
func mergePreset(def *Preset, overlay []byte) (*Preset, error) {
|
||||||
|
base, err := presetMap(def)
|
||||||
|
if err != nil {
|
||||||
|
return nil, err
|
||||||
|
}
|
||||||
|
var over map[string]any
|
||||||
|
dec := json.NewDecoder(bytes.NewReader(overlay))
|
||||||
|
dec.UseNumber()
|
||||||
|
if err := dec.Decode(&over); err != nil {
|
||||||
|
return nil, err
|
||||||
|
}
|
||||||
|
deepMerge(base, over)
|
||||||
|
b, err := json.Marshal(base)
|
||||||
|
if err != nil {
|
||||||
|
return nil, err
|
||||||
|
}
|
||||||
var p Preset
|
var p Preset
|
||||||
if err := json.Unmarshal(b, &p); err != nil {
|
if err := json.Unmarshal(b, &p); err != nil {
|
||||||
return nil, err
|
return nil, err
|
||||||
}
|
}
|
||||||
if p.Name == "" {
|
|
||||||
return nil, errors.New("missing 'name'")
|
|
||||||
}
|
|
||||||
if len(p.Argv) == 0 && !p.Shell {
|
|
||||||
return nil, errors.New("missing 'argv'")
|
|
||||||
}
|
|
||||||
p.Path = path
|
|
||||||
p.Kind = kind
|
|
||||||
return &p, nil
|
return &p, nil
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func presetMap(p *Preset) (map[string]any, error) {
|
||||||
|
b, err := json.Marshal(p)
|
||||||
|
if err != nil {
|
||||||
|
return nil, err
|
||||||
|
}
|
||||||
|
var m map[string]any
|
||||||
|
dec := json.NewDecoder(bytes.NewReader(b))
|
||||||
|
dec.UseNumber()
|
||||||
|
if err := dec.Decode(&m); err != nil {
|
||||||
|
return nil, err
|
||||||
|
}
|
||||||
|
return m, nil
|
||||||
|
}
|
||||||
|
|
||||||
|
func deepMerge(dst, src map[string]any) {
|
||||||
|
for k, v := range src {
|
||||||
|
if sm, ok := v.(map[string]any); ok {
|
||||||
|
if dm, ok := dst[k].(map[string]any); ok {
|
||||||
|
deepMerge(dm, sm)
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
}
|
||||||
|
dst[k] = v
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func clonePreset(p *Preset) *Preset {
|
||||||
|
if p == nil {
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
b, _ := json.Marshal(p)
|
||||||
|
var out Preset
|
||||||
|
_ = json.Unmarshal(b, &out)
|
||||||
|
return &out
|
||||||
|
}
|
||||||
|
|
||||||
// ResolvedArgv returns the argv to actually exec, handling the
|
// ResolvedArgv returns the argv to actually exec, handling the
|
||||||
// process-preset "shell: true" case (SPEC §10).
|
// process-preset "shell: true" case (SPEC §10).
|
||||||
func (p *Preset) ResolvedArgv() []string {
|
func (p *Preset) ResolvedArgv() []string {
|
||||||
@@ -214,16 +313,8 @@ func (p *Preset) ResolvedArgv() []string {
|
|||||||
return p.Argv
|
return p.Argv
|
||||||
}
|
}
|
||||||
|
|
||||||
// ensureDefaults writes default agent presets (claude/codex/opencode)
|
func defaultAgentPresets() []*Preset {
|
||||||
// and a sample process preset on first run. Never overwrites existing
|
bodies := []string{
|
||||||
// user files.
|
|
||||||
func ensureDefaults(base string) error {
|
|
||||||
defaults := []struct {
|
|
||||||
rel string
|
|
||||||
body string
|
|
||||||
}{
|
|
||||||
{
|
|
||||||
"presets/agents/claude.json",
|
|
||||||
`{
|
`{
|
||||||
"name": "claude",
|
"name": "claude",
|
||||||
"argv": ["claude"],
|
"argv": ["claude"],
|
||||||
@@ -249,9 +340,6 @@ func ensureDefaults(base string) error {
|
|||||||
]
|
]
|
||||||
}
|
}
|
||||||
`,
|
`,
|
||||||
},
|
|
||||||
{
|
|
||||||
"presets/agents/codex.json",
|
|
||||||
`{
|
`{
|
||||||
"name": "codex",
|
"name": "codex",
|
||||||
"argv": ["codex"],
|
"argv": ["codex"],
|
||||||
@@ -264,7 +352,10 @@ func ensureDefaults(base string) error {
|
|||||||
"ready_signal": { "idle_ms": 1000 },
|
"ready_signal": { "idle_ms": 1000 },
|
||||||
"idle_detection": {
|
"idle_detection": {
|
||||||
"strategy": "osc_title_stability",
|
"strategy": "osc_title_stability",
|
||||||
"idle_threshold_ms": 2000
|
"idle_threshold_ms": 2000,
|
||||||
|
"thinking_patterns": [
|
||||||
|
"(?i)esc to interrupt"
|
||||||
|
]
|
||||||
},
|
},
|
||||||
"chrome_trim_hints": [
|
"chrome_trim_hints": [
|
||||||
"^OpenAI Codex",
|
"^OpenAI Codex",
|
||||||
@@ -275,9 +366,6 @@ func ensureDefaults(base string) error {
|
|||||||
]
|
]
|
||||||
}
|
}
|
||||||
`,
|
`,
|
||||||
},
|
|
||||||
{
|
|
||||||
"presets/agents/opencode.json",
|
|
||||||
`{
|
`{
|
||||||
"name": "opencode",
|
"name": "opencode",
|
||||||
"argv": ["opencode"],
|
"argv": ["opencode"],
|
||||||
@@ -301,19 +389,15 @@ func ensureDefaults(base string) error {
|
|||||||
]
|
]
|
||||||
}
|
}
|
||||||
`,
|
`,
|
||||||
},
|
|
||||||
}
|
}
|
||||||
for _, d := range defaults {
|
out := make([]*Preset, 0, len(bodies))
|
||||||
full := filepath.Join(base, d.rel)
|
for _, body := range bodies {
|
||||||
if _, err := os.Stat(full); err == nil {
|
var p Preset
|
||||||
continue
|
if err := json.Unmarshal([]byte(body), &p); err != nil {
|
||||||
|
panic(err)
|
||||||
}
|
}
|
||||||
if err := os.MkdirAll(filepath.Dir(full), 0o700); err != nil {
|
p.Kind = KindAgent
|
||||||
return err
|
out = append(out, &p)
|
||||||
}
|
}
|
||||||
if err := os.WriteFile(full, []byte(d.body), 0o600); err != nil {
|
return out
|
||||||
return err
|
|
||||||
}
|
|
||||||
}
|
|
||||||
return nil
|
|
||||||
}
|
}
|
||||||
|
|||||||
131
internal/preset/preset_test.go
Normal file
131
internal/preset/preset_test.go
Normal file
@@ -0,0 +1,131 @@
|
|||||||
|
package preset
|
||||||
|
|
||||||
|
import (
|
||||||
|
"os"
|
||||||
|
"path/filepath"
|
||||||
|
"testing"
|
||||||
|
)
|
||||||
|
|
||||||
|
func TestLoadUsesBuiltInDefaultsWithoutWritingConfig(t *testing.T) {
|
||||||
|
configHome := filepath.Join(t.TempDir(), "config")
|
||||||
|
t.Setenv("XDG_CONFIG_HOME", configHome)
|
||||||
|
|
||||||
|
set, err := Load()
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("Load: %v", err)
|
||||||
|
}
|
||||||
|
if _, err := os.Stat(filepath.Join(configHome, "patterm")); !os.IsNotExist(err) {
|
||||||
|
t.Fatalf("Load created config dir or unexpected stat error: %v", err)
|
||||||
|
}
|
||||||
|
if len(set.Agents) != 3 {
|
||||||
|
t.Fatalf("agents len = %d, want 3", len(set.Agents))
|
||||||
|
}
|
||||||
|
claude := presetByName(set.Agents, "claude")
|
||||||
|
if claude == nil {
|
||||||
|
t.Fatal("missing built-in claude preset")
|
||||||
|
}
|
||||||
|
if claude.IdleDetection == nil || len(claude.IdleDetection.PermissionPatterns) == 0 {
|
||||||
|
t.Fatalf("built-in claude missing permission patterns: %+v", claude.IdleDetection)
|
||||||
|
}
|
||||||
|
codex := presetByName(set.Agents, "codex")
|
||||||
|
if codex == nil {
|
||||||
|
t.Fatal("missing built-in codex preset")
|
||||||
|
}
|
||||||
|
if codex.IdleDetection == nil || len(codex.IdleDetection.ThinkingPatterns) == 0 {
|
||||||
|
t.Fatalf("built-in codex missing thinking patterns: %+v", codex.IdleDetection)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestLoadMergesUserOverlayIntoBuiltInPreset(t *testing.T) {
|
||||||
|
configHome := t.TempDir()
|
||||||
|
t.Setenv("XDG_CONFIG_HOME", configHome)
|
||||||
|
dir := filepath.Join(configHome, "patterm", "presets", "agents")
|
||||||
|
if err := os.MkdirAll(dir, 0o700); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
writeFile(t, filepath.Join(dir, "claude.json"), `{
|
||||||
|
"name": "claude",
|
||||||
|
"argv": ["claude", "--model", "sonnet"],
|
||||||
|
"idle_detection": { "idle_threshold_ms": 3500 }
|
||||||
|
}`)
|
||||||
|
|
||||||
|
set, err := Load()
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("Load: %v", err)
|
||||||
|
}
|
||||||
|
claude := presetByName(set.Agents, "claude")
|
||||||
|
if claude == nil {
|
||||||
|
t.Fatal("missing claude preset")
|
||||||
|
}
|
||||||
|
if got := claude.Argv; len(got) != 3 || got[0] != "claude" || got[2] != "sonnet" {
|
||||||
|
t.Fatalf("argv = %#v", got)
|
||||||
|
}
|
||||||
|
if claude.IdleDetection.IdleThresholdMS != 3500 {
|
||||||
|
t.Fatalf("idle threshold = %d", claude.IdleDetection.IdleThresholdMS)
|
||||||
|
}
|
||||||
|
if len(claude.IdleDetection.PermissionPatterns) == 0 {
|
||||||
|
t.Fatalf("permission patterns were not inherited: %+v", claude.IdleDetection)
|
||||||
|
}
|
||||||
|
if claude.MCPInjection == nil || claude.MCPInjection.Kind != "flag" {
|
||||||
|
t.Fatalf("mcp injection was not inherited: %+v", claude.MCPInjection)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestLoadCanDisableBuiltInPreset(t *testing.T) {
|
||||||
|
configHome := t.TempDir()
|
||||||
|
t.Setenv("XDG_CONFIG_HOME", configHome)
|
||||||
|
dir := filepath.Join(configHome, "patterm", "presets", "agents")
|
||||||
|
if err := os.MkdirAll(dir, 0o700); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
writeFile(t, filepath.Join(dir, "opencode.json"), `{"name":"opencode","disabled":true}`)
|
||||||
|
|
||||||
|
set, err := Load()
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("Load: %v", err)
|
||||||
|
}
|
||||||
|
if presetByName(set.Agents, "opencode") != nil {
|
||||||
|
t.Fatal("opencode preset was not disabled")
|
||||||
|
}
|
||||||
|
if presetByName(set.Agents, "claude") == nil || presetByName(set.Agents, "codex") == nil {
|
||||||
|
t.Fatalf("other built-ins missing: %+v", set.Agents)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestLoadAddsCustomUserPreset(t *testing.T) {
|
||||||
|
configHome := t.TempDir()
|
||||||
|
t.Setenv("XDG_CONFIG_HOME", configHome)
|
||||||
|
dir := filepath.Join(configHome, "patterm", "presets", "processes")
|
||||||
|
if err := os.MkdirAll(dir, 0o700); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
writeFile(t, filepath.Join(dir, "test.json"), `{"name":"test","argv":["go","test","./..."]}`)
|
||||||
|
|
||||||
|
set, err := Load()
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("Load: %v", err)
|
||||||
|
}
|
||||||
|
proc := presetByName(set.Processes, "test")
|
||||||
|
if proc == nil {
|
||||||
|
t.Fatal("missing custom process preset")
|
||||||
|
}
|
||||||
|
if proc.Kind != KindCommand {
|
||||||
|
t.Fatalf("kind = %q", proc.Kind)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func presetByName(ps []*Preset, name string) *Preset {
|
||||||
|
for _, p := range ps {
|
||||||
|
if p.Name == name {
|
||||||
|
return p
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
|
||||||
|
func writeFile(t *testing.T, path, body string) {
|
||||||
|
t.Helper()
|
||||||
|
if err := os.WriteFile(path, []byte(body), 0o600); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
}
|
||||||
164
internal/protocol/frame.go
Normal file
164
internal/protocol/frame.go
Normal file
@@ -0,0 +1,164 @@
|
|||||||
|
// Package protocol defines the daemon/client control frames shared by
|
||||||
|
// transports. It intentionally contains data shapes only; app behavior stays
|
||||||
|
// in internal/app until the headless daemon split is complete.
|
||||||
|
package protocol
|
||||||
|
|
||||||
|
import (
|
||||||
|
"encoding/json"
|
||||||
|
"fmt"
|
||||||
|
"time"
|
||||||
|
)
|
||||||
|
|
||||||
|
// FrameType identifies one protocol message kind.
|
||||||
|
type FrameType string
|
||||||
|
|
||||||
|
const (
|
||||||
|
FrameHello FrameType = "hello"
|
||||||
|
FrameAuthChallenge FrameType = "auth_challenge"
|
||||||
|
FrameAuthOK FrameType = "auth_ok"
|
||||||
|
FrameAttach FrameType = "attach"
|
||||||
|
FrameDetach FrameType = "detach"
|
||||||
|
FrameProjectList FrameType = "project_list"
|
||||||
|
FrameChrome FrameType = "chrome"
|
||||||
|
FramePaneSnapshot FrameType = "pane_snapshot"
|
||||||
|
FramePaneChunk FrameType = "pane_chunk"
|
||||||
|
FrameLifecycle FrameType = "lifecycle"
|
||||||
|
FrameAttention FrameType = "attention"
|
||||||
|
FrameTrustPrompt FrameType = "trust_prompt"
|
||||||
|
FrameInput FrameType = "input"
|
||||||
|
FrameFocus FrameType = "focus"
|
||||||
|
FrameSwitchProject FrameType = "switch_project"
|
||||||
|
FrameOpenProject FrameType = "open_project"
|
||||||
|
FramePaletteCommand FrameType = "palette_command"
|
||||||
|
FrameTrustResponse FrameType = "trust_response"
|
||||||
|
FrameResize FrameType = "resize"
|
||||||
|
)
|
||||||
|
|
||||||
|
// Frame is the transport envelope. Payload is deliberately raw JSON so
|
||||||
|
// network transports can frame without knowing every message type; loopback
|
||||||
|
// transports may pass the same bytes without JSON re-encoding.
|
||||||
|
type Frame struct {
|
||||||
|
Type FrameType `json:"type"`
|
||||||
|
RequestID string `json:"request_id,omitempty"`
|
||||||
|
Payload json.RawMessage `json:"payload,omitempty"`
|
||||||
|
}
|
||||||
|
|
||||||
|
// NewFrame marshals payload into a protocol frame.
|
||||||
|
func NewFrame[T any](typ FrameType, payload T) (Frame, error) {
|
||||||
|
b, err := json.Marshal(payload)
|
||||||
|
if err != nil {
|
||||||
|
return Frame{}, fmt.Errorf("protocol: marshal %s: %w", typ, err)
|
||||||
|
}
|
||||||
|
return Frame{Type: typ, Payload: b}, nil
|
||||||
|
}
|
||||||
|
|
||||||
|
// Decode unmarshals f.Payload into v.
|
||||||
|
func Decode[T any](f Frame) (T, error) {
|
||||||
|
var v T
|
||||||
|
if len(f.Payload) == 0 {
|
||||||
|
return v, nil
|
||||||
|
}
|
||||||
|
if err := json.Unmarshal(f.Payload, &v); err != nil {
|
||||||
|
return v, fmt.Errorf("protocol: decode %s: %w", f.Type, err)
|
||||||
|
}
|
||||||
|
return v, nil
|
||||||
|
}
|
||||||
|
|
||||||
|
type Hello struct {
|
||||||
|
Version int `json:"version"`
|
||||||
|
DaemonID string `json:"daemon_id,omitempty"`
|
||||||
|
ClientID string `json:"client_id,omitempty"`
|
||||||
|
ProjectKey string `json:"project_key,omitempty"`
|
||||||
|
}
|
||||||
|
|
||||||
|
type Attach struct {
|
||||||
|
Token string `json:"token,omitempty"`
|
||||||
|
ProjectKey string `json:"project_key,omitempty"`
|
||||||
|
TermSize Size `json:"term_size"`
|
||||||
|
}
|
||||||
|
|
||||||
|
type Detach struct {
|
||||||
|
ClientID string `json:"client_id,omitempty"`
|
||||||
|
}
|
||||||
|
|
||||||
|
type Size struct {
|
||||||
|
Cols uint16 `json:"cols"`
|
||||||
|
Rows uint16 `json:"rows"`
|
||||||
|
}
|
||||||
|
|
||||||
|
type Project struct {
|
||||||
|
Key string `json:"key"`
|
||||||
|
Path string `json:"path"`
|
||||||
|
Name string `json:"name"`
|
||||||
|
LastActive time.Time `json:"last_active,omitempty"`
|
||||||
|
TabCount int `json:"tab_count"`
|
||||||
|
}
|
||||||
|
|
||||||
|
type ProjectList struct {
|
||||||
|
Projects []Project `json:"projects"`
|
||||||
|
}
|
||||||
|
|
||||||
|
type Chrome struct {
|
||||||
|
ProjectKey string `json:"project_key"`
|
||||||
|
Model json.RawMessage `json:"model"`
|
||||||
|
}
|
||||||
|
|
||||||
|
type PaneSnapshot struct {
|
||||||
|
PaneID string `json:"pane_id"`
|
||||||
|
Bytes []byte `json:"bytes"`
|
||||||
|
}
|
||||||
|
|
||||||
|
type PaneChunk struct {
|
||||||
|
PaneID string `json:"pane_id"`
|
||||||
|
Bytes []byte `json:"bytes"`
|
||||||
|
}
|
||||||
|
|
||||||
|
type LifecycleKind string
|
||||||
|
|
||||||
|
const (
|
||||||
|
LifecycleSpawned LifecycleKind = "spawned"
|
||||||
|
LifecycleExited LifecycleKind = "exited"
|
||||||
|
LifecycleClosed LifecycleKind = "closed"
|
||||||
|
LifecycleStateChanged LifecycleKind = "state_changed"
|
||||||
|
)
|
||||||
|
|
||||||
|
type Lifecycle struct {
|
||||||
|
Kind LifecycleKind `json:"kind"`
|
||||||
|
ProjectKey string `json:"project_key,omitempty"`
|
||||||
|
ChildID string `json:"child_id,omitempty"`
|
||||||
|
Child json.RawMessage `json:"child,omitempty"`
|
||||||
|
State string `json:"state,omitempty"`
|
||||||
|
}
|
||||||
|
|
||||||
|
type Input struct {
|
||||||
|
PaneID string `json:"pane_id"`
|
||||||
|
Bytes []byte `json:"bytes"`
|
||||||
|
}
|
||||||
|
|
||||||
|
type Focus struct {
|
||||||
|
PaneID string `json:"pane_id,omitempty"`
|
||||||
|
Pad string `json:"pad,omitempty"`
|
||||||
|
}
|
||||||
|
|
||||||
|
type SwitchProject struct {
|
||||||
|
Key string `json:"key"`
|
||||||
|
}
|
||||||
|
|
||||||
|
type OpenProject struct {
|
||||||
|
Path string `json:"path"`
|
||||||
|
}
|
||||||
|
|
||||||
|
type PaletteCommand struct {
|
||||||
|
Kind string `json:"kind"`
|
||||||
|
Data json.RawMessage `json:"data,omitempty"`
|
||||||
|
}
|
||||||
|
|
||||||
|
type TrustResponse struct {
|
||||||
|
ProcessID string `json:"process_id"`
|
||||||
|
Preset string `json:"preset"`
|
||||||
|
Allow bool `json:"allow"`
|
||||||
|
}
|
||||||
|
|
||||||
|
type Resize struct {
|
||||||
|
Size Size `json:"size"`
|
||||||
|
}
|
||||||
67
internal/protocol/loopback.go
Normal file
67
internal/protocol/loopback.go
Normal file
@@ -0,0 +1,67 @@
|
|||||||
|
package protocol
|
||||||
|
|
||||||
|
import (
|
||||||
|
"sync"
|
||||||
|
)
|
||||||
|
|
||||||
|
const defaultLoopbackBuffer = 64
|
||||||
|
|
||||||
|
// NewLoopbackPair returns connected in-process transports. Frames cross the
|
||||||
|
// same Send/Recv boundary as network transports, but payload bytes are passed
|
||||||
|
// directly without JSON re-encoding.
|
||||||
|
func NewLoopbackPair() (client Transport, daemon Transport) {
|
||||||
|
c2d := make(chan Frame, defaultLoopbackBuffer)
|
||||||
|
d2c := make(chan Frame, defaultLoopbackBuffer)
|
||||||
|
return &loopbackTransport{send: c2d, recv: d2c}, &loopbackTransport{send: d2c, recv: c2d}
|
||||||
|
}
|
||||||
|
|
||||||
|
type loopbackTransport struct {
|
||||||
|
send chan<- Frame
|
||||||
|
recv <-chan Frame
|
||||||
|
once sync.Once
|
||||||
|
done chan struct{}
|
||||||
|
}
|
||||||
|
|
||||||
|
func (t *loopbackTransport) init() {
|
||||||
|
if t.done == nil {
|
||||||
|
t.done = make(chan struct{})
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func (t *loopbackTransport) Send(f Frame) error {
|
||||||
|
t.init()
|
||||||
|
select {
|
||||||
|
case <-t.done:
|
||||||
|
return ErrTransportClosed
|
||||||
|
case t.send <- cloneFrame(f):
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func (t *loopbackTransport) Recv() (Frame, error) {
|
||||||
|
t.init()
|
||||||
|
select {
|
||||||
|
case <-t.done:
|
||||||
|
return Frame{}, ErrTransportClosed
|
||||||
|
case f, ok := <-t.recv:
|
||||||
|
if !ok {
|
||||||
|
return Frame{}, ErrTransportClosed
|
||||||
|
}
|
||||||
|
return f, nil
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func (t *loopbackTransport) Close() error {
|
||||||
|
t.init()
|
||||||
|
t.once.Do(func() {
|
||||||
|
close(t.done)
|
||||||
|
})
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
|
||||||
|
func cloneFrame(f Frame) Frame {
|
||||||
|
if len(f.Payload) > 0 {
|
||||||
|
f.Payload = append([]byte(nil), f.Payload...)
|
||||||
|
}
|
||||||
|
return f
|
||||||
|
}
|
||||||
51
internal/protocol/loopback_test.go
Normal file
51
internal/protocol/loopback_test.go
Normal file
@@ -0,0 +1,51 @@
|
|||||||
|
package protocol
|
||||||
|
|
||||||
|
import "testing"
|
||||||
|
|
||||||
|
func TestLoopbackUsesFramePayload(t *testing.T) {
|
||||||
|
client, daemon := NewLoopbackPair()
|
||||||
|
defer client.Close()
|
||||||
|
defer daemon.Close()
|
||||||
|
|
||||||
|
sent, err := NewFrame(FrameInput, Input{PaneID: "p_123456", Bytes: []byte("hello")})
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("NewFrame: %v", err)
|
||||||
|
}
|
||||||
|
if err := client.Send(sent); err != nil {
|
||||||
|
t.Fatalf("Send: %v", err)
|
||||||
|
}
|
||||||
|
got, err := daemon.Recv()
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("Recv: %v", err)
|
||||||
|
}
|
||||||
|
if got.Type != FrameInput {
|
||||||
|
t.Fatalf("type = %q, want %q", got.Type, FrameInput)
|
||||||
|
}
|
||||||
|
payload, err := Decode[Input](got)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("Decode: %v", err)
|
||||||
|
}
|
||||||
|
if payload.PaneID != "p_123456" || string(payload.Bytes) != "hello" {
|
||||||
|
t.Fatalf("payload = %#v", payload)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestLoopbackCopiesPayloadOnSend(t *testing.T) {
|
||||||
|
client, daemon := NewLoopbackPair()
|
||||||
|
defer client.Close()
|
||||||
|
defer daemon.Close()
|
||||||
|
|
||||||
|
f := Frame{Type: FramePaneChunk, Payload: []byte(`{"pane_id":"p","bytes":"aGVsbG8="}`)}
|
||||||
|
if err := client.Send(f); err != nil {
|
||||||
|
t.Fatalf("Send: %v", err)
|
||||||
|
}
|
||||||
|
f.Payload[0] = 'x'
|
||||||
|
|
||||||
|
got, err := daemon.Recv()
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("Recv: %v", err)
|
||||||
|
}
|
||||||
|
if got.Payload[0] != '{' {
|
||||||
|
t.Fatalf("payload was retained instead of copied: %q", string(got.Payload))
|
||||||
|
}
|
||||||
|
}
|
||||||
73
internal/protocol/transport.go
Normal file
73
internal/protocol/transport.go
Normal file
@@ -0,0 +1,73 @@
|
|||||||
|
package protocol
|
||||||
|
|
||||||
|
import (
|
||||||
|
"bufio"
|
||||||
|
"encoding/json"
|
||||||
|
"errors"
|
||||||
|
"fmt"
|
||||||
|
"io"
|
||||||
|
"net"
|
||||||
|
)
|
||||||
|
|
||||||
|
var ErrTransportClosed = errors.New("protocol: transport closed")
|
||||||
|
|
||||||
|
// Transport carries framed daemon/client protocol messages.
|
||||||
|
type Transport interface {
|
||||||
|
Send(Frame) error
|
||||||
|
Recv() (Frame, error)
|
||||||
|
Close() error
|
||||||
|
}
|
||||||
|
|
||||||
|
// ConnTransport is a JSON-lines implementation over a stream connection.
|
||||||
|
type ConnTransport struct {
|
||||||
|
conn net.Conn
|
||||||
|
r *bufio.Reader
|
||||||
|
w *bufio.Writer
|
||||||
|
}
|
||||||
|
|
||||||
|
func NewConnTransport(conn net.Conn) *ConnTransport {
|
||||||
|
return &ConnTransport{
|
||||||
|
conn: conn,
|
||||||
|
r: bufio.NewReader(conn),
|
||||||
|
w: bufio.NewWriter(conn),
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func (t *ConnTransport) Send(f Frame) error {
|
||||||
|
if t == nil || t.conn == nil {
|
||||||
|
return ErrTransportClosed
|
||||||
|
}
|
||||||
|
b, err := json.Marshal(f)
|
||||||
|
if err != nil {
|
||||||
|
return fmt.Errorf("protocol: encode frame: %w", err)
|
||||||
|
}
|
||||||
|
if _, err := t.w.Write(append(b, '\n')); err != nil {
|
||||||
|
return err
|
||||||
|
}
|
||||||
|
return t.w.Flush()
|
||||||
|
}
|
||||||
|
|
||||||
|
func (t *ConnTransport) Recv() (Frame, error) {
|
||||||
|
if t == nil || t.conn == nil {
|
||||||
|
return Frame{}, ErrTransportClosed
|
||||||
|
}
|
||||||
|
line, err := t.r.ReadBytes('\n')
|
||||||
|
if err != nil {
|
||||||
|
if errors.Is(err, io.EOF) {
|
||||||
|
return Frame{}, ErrTransportClosed
|
||||||
|
}
|
||||||
|
return Frame{}, err
|
||||||
|
}
|
||||||
|
var f Frame
|
||||||
|
if err := json.Unmarshal(line, &f); err != nil {
|
||||||
|
return Frame{}, fmt.Errorf("protocol: decode frame: %w", err)
|
||||||
|
}
|
||||||
|
return f, nil
|
||||||
|
}
|
||||||
|
|
||||||
|
func (t *ConnTransport) Close() error {
|
||||||
|
if t == nil || t.conn == nil {
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
return t.conn.Close()
|
||||||
|
}
|
||||||
@@ -6,6 +6,7 @@ import (
|
|||||||
"io"
|
"io"
|
||||||
"os"
|
"os"
|
||||||
"os/exec"
|
"os/exec"
|
||||||
|
"syscall"
|
||||||
|
|
||||||
cpty "github.com/creack/pty"
|
cpty "github.com/creack/pty"
|
||||||
)
|
)
|
||||||
@@ -19,11 +20,13 @@ type PTY struct {
|
|||||||
// Start spawns argv with stdin/stdout/stderr attached to a new PTY sized
|
// Start spawns argv with stdin/stdout/stderr attached to a new PTY sized
|
||||||
// (cols, rows). The returned PTY exposes the master fd for the parent to
|
// (cols, rows). The returned PTY exposes the master fd for the parent to
|
||||||
// read from and write to.
|
// read from and write to.
|
||||||
func Start(argv []string, env []string, cols, rows uint16) (*PTY, error) {
|
func Start(argv []string, env []string, workDir string, cols, rows uint16) (*PTY, error) {
|
||||||
if len(argv) == 0 {
|
if len(argv) == 0 {
|
||||||
return nil, fmt.Errorf("pty: empty argv")
|
return nil, fmt.Errorf("pty: empty argv")
|
||||||
}
|
}
|
||||||
cmd := exec.Command(argv[0], argv[1:]...)
|
cmd := exec.Command(argv[0], argv[1:]...)
|
||||||
|
cmd.Dir = workDir
|
||||||
|
cmd.SysProcAttr = &syscall.SysProcAttr{Setsid: true, Setctty: true}
|
||||||
if env != nil {
|
if env != nil {
|
||||||
cmd.Env = ensureTerm(env)
|
cmd.Env = ensureTerm(env)
|
||||||
} else {
|
} else {
|
||||||
@@ -88,6 +91,10 @@ func (p *PTY) Close() error {
|
|||||||
p.master = nil
|
p.master = nil
|
||||||
}
|
}
|
||||||
if p.cmd != nil && p.cmd.Process != nil {
|
if p.cmd != nil && p.cmd.Process != nil {
|
||||||
|
pid := p.cmd.Process.Pid
|
||||||
|
if pid > 0 {
|
||||||
|
_ = syscall.Kill(-pid, syscall.SIGKILL)
|
||||||
|
}
|
||||||
_ = p.cmd.Process.Kill()
|
_ = p.cmd.Process.Kill()
|
||||||
}
|
}
|
||||||
return firstErr
|
return firstErr
|
||||||
|
|||||||
84
internal/pty/pty_test.go
Normal file
84
internal/pty/pty_test.go
Normal file
@@ -0,0 +1,84 @@
|
|||||||
|
package pty
|
||||||
|
|
||||||
|
import (
|
||||||
|
"bytes"
|
||||||
|
"errors"
|
||||||
|
"os"
|
||||||
|
"path/filepath"
|
||||||
|
"strconv"
|
||||||
|
"strings"
|
||||||
|
"syscall"
|
||||||
|
"testing"
|
||||||
|
"time"
|
||||||
|
)
|
||||||
|
|
||||||
|
func TestStartUsesWorkDir(t *testing.T) {
|
||||||
|
dir := t.TempDir()
|
||||||
|
p, err := Start([]string{"sh", "-c", "pwd"}, nil, dir, 80, 24)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("Start: %v", err)
|
||||||
|
}
|
||||||
|
defer p.Close()
|
||||||
|
|
||||||
|
var out bytes.Buffer
|
||||||
|
buf := make([]byte, 256)
|
||||||
|
deadline := time.Now().Add(5 * time.Second)
|
||||||
|
for time.Now().Before(deadline) {
|
||||||
|
n, err := p.Read(buf)
|
||||||
|
if n > 0 {
|
||||||
|
out.Write(buf[:n])
|
||||||
|
if strings.Contains(out.String(), dir) {
|
||||||
|
break
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if err != nil {
|
||||||
|
break
|
||||||
|
}
|
||||||
|
}
|
||||||
|
_ = p.Wait()
|
||||||
|
|
||||||
|
if got := strings.TrimSpace(out.String()); got != dir {
|
||||||
|
t.Fatalf("pwd output = %q, want %q", got, dir)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestCloseKillsProcessGroup(t *testing.T) {
|
||||||
|
dir := t.TempDir()
|
||||||
|
pidFile := filepath.Join(dir, "sleep.pid")
|
||||||
|
env := append(os.Environ(), "PIDFILE="+pidFile)
|
||||||
|
p, err := Start([]string{"sh", "-c", "sleep 30 & echo $! > \"$PIDFILE\"; wait"}, env, "", 80, 24)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("Start: %v", err)
|
||||||
|
}
|
||||||
|
deadline := time.Now().Add(5 * time.Second)
|
||||||
|
var childPID int
|
||||||
|
for time.Now().Before(deadline) {
|
||||||
|
b, err := os.ReadFile(pidFile)
|
||||||
|
if err == nil {
|
||||||
|
childPID, _ = strconv.Atoi(strings.TrimSpace(string(b)))
|
||||||
|
if childPID > 0 {
|
||||||
|
break
|
||||||
|
}
|
||||||
|
}
|
||||||
|
time.Sleep(20 * time.Millisecond)
|
||||||
|
}
|
||||||
|
if childPID <= 0 {
|
||||||
|
_ = p.Close()
|
||||||
|
t.Fatalf("background child pid was not written")
|
||||||
|
}
|
||||||
|
|
||||||
|
if err := p.Close(); err != nil {
|
||||||
|
t.Fatalf("Close: %v", err)
|
||||||
|
}
|
||||||
|
_ = p.Wait()
|
||||||
|
|
||||||
|
deadline = time.Now().Add(5 * time.Second)
|
||||||
|
for time.Now().Before(deadline) {
|
||||||
|
err := syscall.Kill(childPID, 0)
|
||||||
|
if errors.Is(err, syscall.ESRCH) {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
time.Sleep(20 * time.Millisecond)
|
||||||
|
}
|
||||||
|
t.Fatalf("background child pid %d still exists after PTY.Close", childPID)
|
||||||
|
}
|
||||||
Reference in New Issue
Block a user