create network if doesn't already exist on server, wip test

tests/Feature/ServerControllerTest.php

@@ -1,9 +1,16 @@
 <?php
 
+use App\Data\ServerProviders\CreatedServer;
+use App\Enums\NetworkType;
+use App\Enums\ProviderType;
 use App\Models\Organisation;
+use App\Models\Provider;
 use App\Models\Server;
 use App\Models\User;
+use App\Services\ServerProviders\HetznerService;
+use Illuminate\Support\Str;
 use Inertia\Testing\AssertableInertia;
+use Mockery\MockInterface;
 
 use function Pest\Laravel\actingAs;
 
@@ -12,17 +19,31 @@ beforeEach(function () {
     // For example, using Laravel's RefreshDatabase trait
     // use Illuminate\Foundation\Testing\RefreshDatabase;
 
+    /** @var User $user */
     $this->user = User::factory()->create();
     actingAs($this->user);
 });
 
 test('index route displays servers for an organisation', function () {
     $organisation = Organisation::factory()->create();
-    Server::factory()->count(2)->create(['organisation_id' => $organisation->id]);
+    $provider = Provider::factory()->forOrganisation($organisation->id)->create();
+    $network = $organisation->networks()->create([
+        'type' => NetworkType::EXTERNAL,
+        'name' => 'keystone',
+        'external_id' => 'net-12345',
+        'provider_id' => $provider->id,
+        'ip_range' => fake()->ipv4() . '/24',
+    ]);
+
+    Server::factory()->count(2)->create([
+        'provider_id' => $provider->id,
+        'organisation_id' => $organisation->id,
+        'external_network_id' => $network->id,
+    ]);
 
     $response = $this->get(route('servers.index', ['organisation' => $organisation->id]));
     $response->assertStatus(200);
-    $response->assertInertia(fn (AssertableInertia $page) => $page
+    $response->assertInertia(fn(AssertableInertia $page) => $page
         ->component('servers/Index'));
 });
 
@@ -30,7 +51,7 @@ test('create route returns inertia view', function () {
     $organisation = Organisation::factory()->create();
     $response = $this->get(route('servers.create', ['organisation' => $organisation->id]));
     $response->assertStatus(200);
-    $response->assertInertia(fn (AssertableInertia $page) => $page
+    $response->assertInertia(fn(AssertableInertia $page) => $page
         ->component('servers/Create'));
 });
 
@@ -44,15 +65,56 @@ test('store route fails with invalid provider', function () {
         'image' => 'ubuntu-20.04',
     ]);
 
-    $response->assertSessionHas('error', 'Invalid provider');
+    $response->assertSessionHasErrors(['provider' => 'The selected provider is invalid.']);
     $response->assertStatus(302); // redirect back
 });
 
 test('store route creates a server with valid data', function () {
     $organisation = Organisation::factory()->create();
 
+    // Create a real provider first, then partially mock it
+    $provider = Provider::factory()->create([
+        'name' => 'hetzner',
+        'type' => ProviderType::HETZNER,
+        'token' => Str::uuid(),
+        'organisation_id' => $organisation->id
+    ]);
+
+    $network = $organisation->networks()->create([
+        'type' => NetworkType::EXTERNAL,
+        'name' => 'keystone',
+        'external_id' => 'net-12345',
+        'provider_id' => $provider->id,
+        'ip_range' => fake()->ipv4() . '/24',
+    ]);
+
+    $this->mock(HetznerService::class, function (MockInterface $mock) use ($network) {
+        $mock->shouldReceive('createServer')
+            ->once()
+            ->with(
+                Mockery::on(function ($arg) {
+                    return is_string($arg['name']) && strlen($arg['name']) > 0;
+                }),
+                'cx11',
+                'hel1',
+                'ubuntu-20.04',
+                $network->external_id
+            )
+            ->andReturn(new CreatedServer(
+                name: 'test-server-from-mock',
+                rootPassword: 'password123',
+                id: 'srv-12345',
+                status: 'running',
+                ipv4: '192.0.2.100',
+                ipv6: '2001:db8::100',
+                networkId: $network->external_id,
+            ));
+
+        $mock->shouldReceive('createNetwork')->never();
+    });
+
     $response = $this->post(route('servers.store', ['organisation' => $organisation->id]), [
-        'provider' => 'hetzner',
+        'provider' => $provider->id,
         'server_type' => 'cx11',
         'location' => 'hel1',
         'image' => 'ubuntu-20.04',
@@ -61,15 +123,24 @@ test('store route creates a server with valid data', function () {
     $response->assertRedirectContains('/servers/');
     $this->assertDatabaseHas('servers', [
         'organisation_id' => $organisation->id,
-        'provider' => 'hetzner',
+        'provider_id' => $provider->id,
         'region' => 'hel1',
         'os' => 'ubuntu-20.04',
+        'external_network_id' => $network->id,
     ]);
 });
 
 test('show route displays a single server', function () {
     $organisation = Organisation::factory()->create();
-    $server = Server::factory()->create(['organisation_id' => $organisation->id]);
+    $network = $organisation->networks()->create([
+        'type' => NetworkType::EXTERNAL,
+        'name' => 'keystone',
+        'external_id' => 'net-12345',
+    ]);
+    $server = Server::factory()->create([
+        'organisation_id' => $organisation->id,
+        'external_network_id' => $network->id,
+    ]);
 
     $response = $this->get(route('servers.show', [
         'organisation' => $organisation->id,
@@ -77,6 +148,6 @@ test('show route displays a single server', function () {
     ]));
 
     $response->assertStatus(200);
-    $response->assertInertia(fn (AssertableInertia $page) => $page
+    $response->assertInertia(fn(AssertableInertia $page) => $page
         ->component('servers/Show'));
 });